David Woloszyn [Mon, 24 Apr 2023 04:22:20 +0000 (14:22 +1000)]
MDL-75913 behat: Use alternatives to Atto in tests
David Woloszyn [Thu, 12 Jan 2023 03:19:54 +0000 (14:19 +1100)]
MDL-75913 behat: Switch to TinyMCE editor iframe
David Woloszyn [Thu, 22 Dec 2022 04:41:01 +0000 (15:41 +1100)]
MDL-75913 behat: Private files data generator
Andrew Nicols [Mon, 19 Dec 2022 08:50:13 +0000 (16:50 +0800)]
MDL-75913 behat: Add support for file uploads in page generators
Andrew Nicols [Mon, 19 Dec 2022 08:50:08 +0000 (16:50 +0800)]
MDL-75913 behat: Add support for file uploads in generators
Andrew Nicols [Fri, 16 Jun 2023 04:04:12 +0000 (12:04 +0800)]
weekly release 4.3dev
Andrew Nicols [Fri, 16 Jun 2023 04:04:07 +0000 (12:04 +0800)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Sara Arjona [Thu, 15 Jun 2023 08:16:57 +0000 (10:16 +0200)]
Merge branch 'MDL-78165-master' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 15 Jun 2023 08:01:15 +0000 (16:01 +0800)]
MDL-78165 mod_bigbluebuttonbn: Fetch cron status using API
Ilya Tregubov [Thu, 15 Jun 2023 04:12:59 +0000 (12:12 +0800)]
Merge branch 'MDL-70152-master-fix' of https://github.com/ilyatregubov/moodle
Andrew Nicols [Thu, 15 Jun 2023 04:03:35 +0000 (12:03 +0800)]
Merge branch 'MDL-78310-master' of https://github.com/aanabit/moodle
Andrew Nicols [Thu, 15 Jun 2023 04:02:11 +0000 (12:02 +0800)]
Merge branch 'MDL-77224' of https://github.com/paulholden/moodle
Simey Lameze [Thu, 15 Jun 2023 02:28:38 +0000 (10:28 +0800)]
MDL-70152 behat: reply to post using data generator
Jun Pataleta [Thu, 15 Jun 2023 03:59:53 +0000 (11:59 +0800)]
Merge branch 'MDL-78333' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 15 Jun 2023 03:53:06 +0000 (11:53 +0800)]
Merge branch 'MDL-78341-progress-bar-style' of https://github.com/brendanheywood/moodle
Jake Dallimore [Thu, 15 Jun 2023 03:48:58 +0000 (11:48 +0800)]
Merge branch 'MDL-78475' of https://github.com/paulholden/moodle
Jun Pataleta [Thu, 15 Jun 2023 03:31:22 +0000 (11:31 +0800)]
Merge branch 'MDL-73325-master' of https://github.com/ntdat1904/datnguyen_moodle
Andrew Nicols [Thu, 15 Jun 2023 03:26:08 +0000 (11:26 +0800)]
Merge branch 'MDL-78066-master' of https://github.com/snake/moodle
Andrew Nicols [Thu, 15 Jun 2023 03:23:05 +0000 (11:23 +0800)]
Merge branch 'MDL-78461' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 15 Jun 2023 03:06:58 +0000 (11:06 +0800)]
Merge branch 'MDL-78385' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 15 Jun 2023 03:01:56 +0000 (11:01 +0800)]
Merge branch 'MDL-78187-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Thu, 15 Jun 2023 02:58:56 +0000 (10:58 +0800)]
Merge branch 'MDL-69231-master' of https://github.com/lameze/moodle
Ilya Tregubov [Thu, 15 Jun 2023 02:36:12 +0000 (10:36 +0800)]
Merge branch 'MDL-77542' of https://github.com/paulholden/moodle
Ilya Tregubov [Thu, 15 Jun 2023 02:22:26 +0000 (10:22 +0800)]
Merge branch 'MDL-76733-master' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 15 Jun 2023 01:59:32 +0000 (09:59 +0800)]
Merge branch 'MDL-78165-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Thu, 15 Jun 2023 01:55:50 +0000 (09:55 +0800)]
Merge branch 'MDL-78478-master' of https://github.com/dasistwas/moodle
Jake Dallimore [Tue, 2 May 2023 05:28:49 +0000 (13:28 +0800)]
MDL-78066 enrol_lti: fix deep linking error in multiple grade items case
If an activity, like workshop or forum, has multiple grade items,
declarative binding of the grade item (line item) isn't supported.
Instead of throwing an exception, handle the case more elegantly
and just omit the 'add to gradebook' option for these activities.
Jake Dallimore [Tue, 2 May 2023 05:26:01 +0000 (13:26 +0800)]
MDL-78066 enrol_lti: test showing multi-grade-items failure
This test demonstrates the failure of the repository to properly fetch
published resources which are compatible with declarative line item
binding.
Andrew Nicols [Thu, 15 Jun 2023 01:28:05 +0000 (09:28 +0800)]
MDL-76733 mod_assign: Remove JS requirement for time-based tests
Converting these tests to use an onlinetext submission and drop the JS
requirement means that they are much less susceptible to runtime issues,
and not susceptible to those caused by JS at all.
Andrew Nicols [Thu, 15 Jun 2023 01:28:05 +0000 (09:28 +0800)]
MDL-76733 mod_assign: Address random failure
This random failure was happening because of the time required to render
and interact with the file picker which sometimes exceeded 2 seconds,
depending on the speed of the machine running the tests.
Converting these tests to use an onlinetext submission and drop the JS
requirement means that they are much less susceptible to runtime issues,
and not susceptible to those caused by JS at all.
Ilya Tregubov [Thu, 15 Jun 2023 01:21:11 +0000 (09:21 +0800)]
Merge branch 'MDL-78207-master' of https://github.com/sarjona/moodle
Ilya Tregubov [Thu, 15 Jun 2023 01:03:14 +0000 (09:03 +0800)]
Merge branch 'MDL-78102-master' of https://github.com/sarjona/moodle
AMOS bot [Thu, 15 Jun 2023 00:16:30 +0000 (00:16 +0000)]
Automatically generated installer lang files
Jun Pataleta [Wed, 14 Jun 2023 16:05:15 +0000 (00:05 +0800)]
Merge branch 'MDL-78306-master' of https://github.com/andrewnicols/moodle
Sara Arjona [Wed, 14 Jun 2023 15:49:49 +0000 (17:49 +0200)]
Merge branch 'MDL-69653' of https://github.com/paulholden/moodle
Paul Holden [Fri, 6 Jan 2023 09:14:58 +0000 (09:14 +0000)]
MDL-69653 cache: final removal of deprecated lock methods.
meirzamoodle [Wed, 14 Jun 2023 15:04:58 +0000 (22:04 +0700)]
MDL-78187 Libraries: Upgrade ADODB to 5.22.5
Sara Arjona [Wed, 14 Jun 2023 14:54:47 +0000 (16:54 +0200)]
Merge branch 'MDL-78055' of https://github.com/paulholden/moodle
Sara Arjona [Wed, 14 Jun 2023 14:51:00 +0000 (16:51 +0200)]
Merge branch 'MDL-74824' of https://github.com/paulholden/moodle
Sara Arjona [Wed, 14 Jun 2023 14:22:09 +0000 (16:22 +0200)]
Merge branch 'MDL-76733-master' of https://github.com/andrewnicols/moodle
Andrew Nicols [Mon, 22 May 2023 01:09:12 +0000 (09:09 +0800)]
MDL-78306 core: Correct modal jsdoc
Andrew Nicols [Thu, 18 May 2023 07:45:25 +0000 (15:45 +0800)]
MDL-78306 core: Migrate core/config to ESM
Andrew Nicols [Thu, 18 May 2023 07:43:24 +0000 (15:43 +0800)]
MDL-78306 core: Convert modal_backdrop to ESM
Andrew Nicols [Thu, 18 May 2023 07:37:22 +0000 (15:37 +0800)]
MDL-78306 core: Convert modal_events to ESM
Andrew Nicols [Thu, 18 May 2023 07:35:47 +0000 (15:35 +0800)]
MDL-78306 core: Convert modal_factory to ESM
Andrew Nicols [Thu, 18 May 2023 06:35:48 +0000 (14:35 +0800)]
MDL-78306 mod_quiz: Convert AMD modals to ESM
Andrew Nicols [Thu, 18 May 2023 06:25:16 +0000 (14:25 +0800)]
MDL-78306 message: Convert notification_processor_settings modal to ESM
Andrew Nicols [Thu, 18 May 2023 06:06:17 +0000 (14:06 +0800)]
MDL-78306 core: Convert calendar modals to ESM
Andrew Nicols [Thu, 18 May 2023 05:42:46 +0000 (13:42 +0800)]
MDL-78306 calendar: Remove unused dependencies
Andrew Nicols [Thu, 18 May 2023 05:41:55 +0000 (13:41 +0800)]
MDL-78306 tool_dataprivacy: Convert data request modal to ESM
Andrew Nicols [Thu, 18 May 2023 06:19:46 +0000 (14:19 +0800)]
MDL-78306 core: Provide helper method to register modals classes
Andrew Nicols [Thu, 18 May 2023 05:42:19 +0000 (13:42 +0800)]
MDL-78306 core: Convert core/modal to ESM
Andrew Nicols [Tue, 30 May 2023 03:05:50 +0000 (11:05 +0800)]
MDL-78306 core: Allow use of .finally()
Meirza [Tue, 9 May 2023 04:12:19 +0000 (11:12 +0700)]
MDL-78165 lib: Added class properties that are not declared in classes
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
David Bogner [Wed, 14 Jun 2023 13:13:54 +0000 (15:13 +0200)]
MDL-78478 forms: Fix repeated elements in dynamic forms
Paul Holden [Fri, 12 May 2023 14:05:12 +0000 (15:05 +0100)]
MDL-78055 themes: account for undefined extrascsscallback config.
Where a theme didn't define this property, it would raise debugging
deprecation warnings in PHP8.1.
Paul Holden [Wed, 14 Jun 2023 11:58:13 +0000 (12:58 +0100)]
MDL-78385 course: fix non-AJAX activity indentation URL parameter.
Sara Arjona [Wed, 14 Jun 2023 11:41:28 +0000 (13:41 +0200)]
Merge branch 'MDL-71325' of https://github.com/paulholden/moodle
Paul Holden [Wed, 14 Jun 2023 11:34:21 +0000 (12:34 +0100)]
MDL-78475 communication: earlier install check for rendering links.
Sara Arjona [Wed, 14 Jun 2023 11:32:28 +0000 (13:32 +0200)]
Merge branch 'MDL-78253' of https://github.com/paulholden/moodle
Sara Arjona [Wed, 14 Jun 2023 11:18:15 +0000 (13:18 +0200)]
Merge branch 'MDL-76715-master' of https://github.com/aanabit/moodle
Sara Arjona [Wed, 14 Jun 2023 11:08:13 +0000 (13:08 +0200)]
Merge branch 'MDL-64648-master_enrol_manual_expirynotify_default_in_enrol_instance' of https://github.com/vtos/moodle
Jun Pataleta [Wed, 14 Jun 2023 08:03:23 +0000 (16:03 +0800)]
Merge branch 'MDL-78466-master' of https://github.com/andrewnicols/moodle
Jake Dallimore [Wed, 14 Jun 2023 06:16:04 +0000 (14:16 +0800)]
Merge branch 'MDL-78144-master' of https://github.com/meirzamoodle/moodle
Ilya Tregubov [Wed, 14 Jun 2023 05:24:06 +0000 (13:24 +0800)]
Merge branch 'MDL-70152-master' of https://github.com/andelacruz/moodle
Jun Pataleta [Wed, 14 Jun 2023 04:18:24 +0000 (12:18 +0800)]
Merge branch 'MDL-76445-master-patch' of https://github.com/ilyatregubov/moodle
Andrew Nicols [Tue, 13 Jun 2023 15:07:01 +0000 (23:07 +0800)]
MDL-78466 cache: Add new result_found helper
This helper is intended to prevent recurrences of this issue by moving
the guess-work to something well tested.
Meirza [Thu, 11 May 2023 08:35:06 +0000 (15:35 +0700)]
MDL-78144 libraries: Added #[AllowDynamicProperties] to ltiprovider
To prevent the PHP 8.2 warning about Dynamic Properties' deprecation,
the #[\AllowDynamicProperties] attributes was added.
Ilya Tregubov [Wed, 14 Jun 2023 03:11:30 +0000 (11:11 +0800)]
Merge branch 'MDL-78328-master' of https://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 14 Jun 2023 02:15:44 +0000 (10:15 +0800)]
Merge branch 'MDL-78313-blocks-performance' of https://github.com/brendanheywood/moodle
Andrew Nicols [Tue, 13 Jun 2023 13:48:23 +0000 (21:48 +0800)]
MDL-78466 cache: Perform strict test on static cache values
If a statically accelerated cache returns an empty array then the value
was still fetched from the non-static cache store.
The check of the `$result` should be strictly checked against `false`,
which is the value used if no value was found.
Ilya Tregubov [Wed, 14 Jun 2023 00:57:43 +0000 (08:57 +0800)]
MDL-76445 gradereport_singleview: Fix Behat test
When you unenrol a user, the notification blocks some tertiary
navigation links.
Brendan Heywood [Tue, 13 Jun 2023 12:06:28 +0000 (22:06 +1000)]
MDL-78341 tool_httpsreplace: Make progress order deterministic
Brendan Heywood [Wed, 24 May 2023 09:00:07 +0000 (19:00 +1000)]
MDL-78341 core: Improve the progress bar style
Paul Holden [Tue, 13 Jun 2023 13:03:41 +0000 (14:03 +0100)]
MDL-78461 core: fix base plugininfo class reference to root directory.
vtos [Tue, 13 Jun 2023 11:25:47 +0000 (13:25 +0200)]
MDL-64648 enrol_manual: fixed default setting of 'expirynotify'
When creating a course, a manual enrolment instance is added by default. The instance settings should inherit the values of those
for the manual enrolment plugin and properly calculate its extra settings. The 'expirynotify' setting wasn't inherited correctly
in case it had 'Enroller + Enrolled' value.
A functional test was added to test the behaviour of settings inheritance.
Sara Arjona [Mon, 29 May 2023 16:04:36 +0000 (18:04 +0200)]
MDL-78207 course: Add tests to cover activitybadge feature
Sara Arjona [Thu, 25 May 2023 15:38:52 +0000 (17:38 +0200)]
MDL-78207 resource: Move file type to activity badge
One of the resource settings, the file type, has been moved to the
activity badge near the activity name.
The rest of the information will be displayed using the afterlink
feature.
However, for now, the activity page still displays all the information
together (that's why resource_get_optional_details() supports now one
new parameter, $showtype, to define whether the file type should be
displayed or not).
Sara Arjona [Thu, 25 May 2023 15:37:31 +0000 (17:37 +0200)]
MDL-78207 forum: Move unread messages to activity badge
Sara Arjona [Thu, 25 May 2023 15:26:39 +0000 (17:26 +0200)]
MDL-78207 course: Add new module badges feature
The new activity card design proposed for Moodle 4.3 differentiates badge
information from other HTML content (displayed using the afterlink feature).
This commit adds a new activitybadge class that can be extended by any
module to display any content in a badge near the activity name. These
are the main features:
- The badge content is always plain text (no HTML).
- The badge style can be set (by default is initialized with badge-none,
but it can be set by any module).
- An optional URL to redirect the user when the badge is clicked.
- An optional ID to add the element in case the module wants to add some
JS to the badge events.
- Optionally, any other extra HTML attributes to the badge element (for
example, data attributes).
Sara Arjona [Wed, 24 May 2023 15:59:17 +0000 (17:59 +0200)]
MDL-78207 course: Move afterlink at the end of the card
Sara Arjona [Wed, 24 May 2023 09:15:35 +0000 (11:15 +0200)]
MDL-78102 badges: Check empty backpack email/password
For backpack connection using OBv2.0, email and password can't be
blank.
This patch adds some extra checks to validate this and displays an
error to the users before trying to connect to the backpack.
Besides, the error displayed when any error is returned by the
backpack (like invalid credentials), has also been improved, to
make it clearer for the users.
Amaia Anabitarte [Mon, 17 Apr 2023 16:58:57 +0000 (18:58 +0200)]
MDL-76715 mod_data: Remove data_records when the last field is deleted
Brendan Heywood [Tue, 30 May 2023 02:31:01 +0000 (12:31 +1000)]
MDL-78313 admin: Improve performance of manage blocks page
Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
Ilya Tregubov [Tue, 13 Jun 2023 07:43:07 +0000 (15:43 +0800)]
Merge branch 'MDL-76445-master-2' of https://github.com/mihailges/moodle
Mihail Geshoski [Fri, 9 Jun 2023 08:14:22 +0000 (16:14 +0800)]
MDL-76445 gradereport_singleview: Deprecate load_users()
Replaces current usages of
\gradereport_singleview\local\screen::load_users() with
get_gradable_users() and deprecates load_users(). The only
remaining calls of this method are unit test related.
Mihail Geshoski [Fri, 9 Jun 2023 04:44:01 +0000 (12:44 +0800)]
MDL-76445 gradereport_singleview: Deprecate initial zero state view
Deprecates the \gradereport_singleview\local\screen\select class which
is used to generate the initial view to select the singleview item type
and the strings used by the related mustache template.
This view is no longer used as we do not provide direct links to it
anymore.
Mihail Geshoski [Thu, 30 Mar 2023 14:34:53 +0000 (22:34 +0800)]
MDL-76445 gradereport_singleview: Usability fixes
Mihail Geshoski [Wed, 29 Mar 2023 04:44:39 +0000 (12:44 +0800)]
MDL-76445 gradereport_user: Usability fixes
Mihail Geshoski [Wed, 29 Mar 2023 02:59:13 +0000 (10:59 +0800)]
MDL-76445 grade: Helper that returns all gradable users in a course
Jake Dallimore [Tue, 13 Jun 2023 06:44:25 +0000 (14:44 +0800)]
Merge branch 'MDL-73052-master' of https://github.com/sarjona/moodle
Jun Pataleta [Tue, 13 Jun 2023 05:43:48 +0000 (13:43 +0800)]
Merge branch 'MDL-78175-master' of https://github.com/ferranrecio/moodle
Andrew Nicols [Tue, 13 Jun 2023 03:04:20 +0000 (11:04 +0800)]
MDL-78297 core: Bump version to update cache config
The missing version bump caused cache configuration to not be updated,
and the static acceleration cache size was therefore not updated. The
result here was that the static acceleration cache was constantly
emptied leading to an increased page load time.
Amaia Anabitarte [Mon, 12 Jun 2023 14:36:28 +0000 (16:36 +0200)]
MDL-78310 mod_resource: Change 'Show type' setting default value
Changing 'Show type' admin setting default value to 'Yes'
Jun Pataleta [Mon, 12 Jun 2023 12:37:55 +0000 (20:37 +0800)]
Merge branch 'MDL-74263-master' of https://github.com/jleyva/moodle
Jun Pataleta [Mon, 12 Jun 2023 08:10:20 +0000 (16:10 +0800)]
Merge branch 'MDL-75937-master' of https://github.com/stevandoMoodle/moodle
Stevani Andolo [Fri, 26 May 2023 03:09:14 +0000 (11:09 +0800)]
MDL-75937 admin: Fixed config data display inconsistency
Jake Dallimore [Mon, 12 Jun 2023 07:06:17 +0000 (15:06 +0800)]
Merge branch 'MDL-78167-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Mon, 12 Jun 2023 04:25:58 +0000 (12:25 +0800)]
Merge branch 'MDL-78166-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Mon, 12 Jun 2023 02:26:34 +0000 (10:26 +0800)]
Merge branch 'MDL-78355' of https://github.com/paulholden/moodle