Sujith Haridasan [Sun, 9 Jan 2022 15:27:54 +0000 (20:57 +0530)]
MDL-73335 question: Add the tertiary nav for question bank
The tertiary navigation has been added to the question bank.
- Url selector has been added for the pages:
Questions, Categories, Import and Export
- A separate page to "Add category" has been added.
The "Add category" is available as a tertiary nav button.
- Updated the tests for the changes made.
This commit is mostly Sujith's work, with further changes by
Tim Hunt <T.J.Hunt@open.ac.uk> so we share the blame/credit.
AMOS BEGIN
CPY [questioncats,mod_quiz],[questioncategories,core_question]
AMOS END
Sujith Haridasan [Sat, 5 Feb 2022 13:50:15 +0000 (19:20 +0530)]
MDL-73335 mod_quiz: Add tertiary nav for the quiz module
The tertiary navigation added for quiz module.
- Added tertiary nav buttons for the edit, attempt and view page
- urlselector is added to the overrides page to access user/groups
- The secondary tabs are highlighted when user navigates to
each page in quiz.
- Updated the behat tests for the changes made.
This commit is mostly Sujith's work, with further changes by
Tim Hunt <T.J.Hunt@open.ac.uk> so we share the blame/credit.
Sujith Haridasan [Sun, 9 Jan 2022 11:31:43 +0000 (17:01 +0530)]
Revert "MDL-71915 mod_quiz: Update the behat tests"
This reverts commit
1149f255fe9a2e1d35b8ac200b48b8c9d8f5a672.
Sujith Haridasan [Sat, 5 Feb 2022 13:46:08 +0000 (19:16 +0530)]
Revert "MDL-71915 mod_quiz: Update the tertiary nav"
This reverts commit
6ba821dc019c33682a3149632d6969db5ad62a31.
Sujith Haridasan [Sun, 9 Jan 2022 08:45:53 +0000 (14:15 +0530)]
Revert "MDL-71915 question: Update the behat tests"
This reverts commit
f000755ba1f4357f1a4e697e7e72dcb752f1ce07.
Sujith Haridasan [Sun, 9 Jan 2022 07:42:48 +0000 (13:12 +0530)]
Revert "MDL-71915 question: Update the tertiary nav"
This reverts commit
26eabeccf40c3a5e40c593ff3f3b07fe6bf6f5bc.
Sujith Haridasan [Sun, 9 Jan 2022 07:26:34 +0000 (12:56 +0530)]
Revert "MDL-71915 mod_quiz: Render add question when user can edit the quiz"
This reverts commit
29ebc9f1532352f4c2ca00b36d2e108883e9bc7e.
Sara Arjona [Fri, 11 Feb 2022 14:55:38 +0000 (15:55 +0100)]
on-demand release 4.0dev+
Sara Arjona [Fri, 11 Feb 2022 14:55:33 +0000 (15:55 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Adrian Greeve [Fri, 11 Feb 2022 01:46:39 +0000 (09:46 +0800)]
MDL-73354 mod_assign: Added removed group check to overrides.
Jun Pataleta [Fri, 11 Feb 2022 04:03:23 +0000 (12:03 +0800)]
Merge branch 'MDL-72928-rebase' of https://github.com/Chocolate-lightning/moodle
Jun Pataleta [Wed, 9 Feb 2022 08:03:32 +0000 (16:03 +0800)]
MDL-72928 core: Remove Remember username
Mathew May [Fri, 14 Jan 2022 08:06:30 +0000 (16:06 +0800)]
MDL-72928 login: Update styling and functionality
Eloy Lafuente (stronk7) [Thu, 10 Feb 2022 20:12:19 +0000 (21:12 +0100)]
Merge branch 'MDL-73836' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 10 Feb 2022 15:39:06 +0000 (16:39 +0100)]
Merge branch 'MDL-73669-master' of https://github.com/marinaglancy/moodle
Jun Pataleta [Thu, 10 Feb 2022 14:56:24 +0000 (22:56 +0800)]
Merge branch 'MDL-73784-master' of https://github.com/HuongNV13/moodle
Jun Pataleta [Thu, 10 Feb 2022 14:41:47 +0000 (22:41 +0800)]
Merge branch 'MDL-73811' of https://github.com/paulholden/moodle
Paul Holden [Thu, 10 Feb 2022 12:38:25 +0000 (12:38 +0000)]
MDL-73836 reportbuilder: allow pre-defined action title attribute.
Ilya Tregubov [Thu, 10 Feb 2022 12:18:34 +0000 (14:18 +0200)]
Merge branch 'MDL-73764' of https://github.com/stronk7/moodle
Jake Dallimore [Thu, 10 Feb 2022 07:59:57 +0000 (15:59 +0800)]
Merge branch 'MDL-73448-master' of https://github.com/peterRd/moodle
Peter Dias [Thu, 27 Jan 2022 00:35:05 +0000 (08:35 +0800)]
MDL-73448 scorm: Remove displayactivityname in scorm.
Peter Dias [Fri, 7 Jan 2022 06:05:53 +0000 (14:05 +0800)]
MDL-73448 scorm: Update scorm tertiary navigation
* Left align scorm content
* Add headings
* Remove exit buttons when in separate window
Shamim Rezaie [Thu, 10 Feb 2022 06:21:10 +0000 (17:21 +1100)]
Merge branch 'MDL-73722' of https://github.com/paulholden/moodle
Jake Dallimore [Thu, 10 Feb 2022 06:14:41 +0000 (14:14 +0800)]
Merge branch 'MDL-73354-master' of git://github.com/abgreeve/moodle
AMOS bot [Thu, 10 Feb 2022 00:07:52 +0000 (00:07 +0000)]
Automatically generated installer lang files
Shamim Rezaie [Wed, 9 Feb 2022 22:42:25 +0000 (09:42 +1100)]
Merge branch 'MDL-73772-master' of https://github.com/aanabit/moodle
Amaia Anabitarte [Fri, 4 Feb 2022 11:48:28 +0000 (12:48 +0100)]
MDL-73772 reports: Fix Activity completion report with no group select
Ilya Tregubov [Wed, 9 Feb 2022 11:28:43 +0000 (13:28 +0200)]
Merge branch 'MDL-73773' of https://github.com/paulholden/moodle
Ilya Tregubov [Wed, 9 Feb 2022 10:06:25 +0000 (12:06 +0200)]
Merge branch 'MDL-71713-master' of https://github.com/cescobedo/moodle
Jun Pataleta [Wed, 9 Feb 2022 09:45:54 +0000 (17:45 +0800)]
Merge branch 'MDL-73633-master' of git://github.com/mihailges/moodle
Adrian Greeve [Tue, 8 Feb 2022 02:01:55 +0000 (10:01 +0800)]
fixup! MDL-73354 mod_assign: General tidy up of tertiary navigation.
Adrian Greeve [Tue, 8 Feb 2022 02:01:43 +0000 (10:01 +0800)]
fixup! MDL-73354 mod_assign: Overrides page updates to tertiary navigation.
Adrian Greeve [Thu, 20 Jan 2022 07:20:52 +0000 (15:20 +0800)]
MDL-73354 mod_assign: Fixed broken timed assignment feature.
Adrian Greeve [Tue, 18 Jan 2022 06:37:20 +0000 (14:37 +0800)]
MDL-73354 mod_assign: Removed unused test code.
Adrian Greeve [Fri, 14 Jan 2022 07:46:26 +0000 (15:46 +0800)]
MDL-73354 advanced grading: Updated management page.
The management page will no longer show the activity name in the
title if using secondary navigation.
Adrian Greeve [Thu, 13 Jan 2022 04:55:19 +0000 (12:55 +0800)]
MDL-73354 mod_assign: Overrides page updates to tertiary navigation.
Adrian Greeve [Wed, 12 Jan 2022 06:52:52 +0000 (14:52 +0800)]
MDL-73354 mod_assign: General tidy up of tertiary navigation.
AMOS bot [Wed, 9 Feb 2022 00:07:38 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Fri, 4 Feb 2022 11:14:00 +0000 (12:14 +0100)]
MDL-73764 behat: Verify the report works and all files in core are ok
Eloy Lafuente (stronk7) [Fri, 4 Feb 2022 08:41:14 +0000 (09:41 +0100)]
MDL-73764 tool_xmldb: Regenerate all the files detected by the report
Note that, instead of going one by one to them from the XMLDB Editor
(load, makes some tiny change, save, revert the change, save), the
report includes a commented line that, once uncommented, does regenerate
the file while reporting.
I've left it there as a commodity for the developer.
Eloy Lafuente (stronk7) [Thu, 3 Feb 2022 22:59:25 +0000 (23:59 +0100)]
MDL-73764 tool_xmldb: New report to show all xml files needing reconcile
People uses to edit the install.xml files manually, here and there. That
uses to come with small mistakes, like wrong white-space indentation,
some attributes out of order...
While none of them are critical, they add a lot of noise when somebody
is correctly editing a file with the XMLDB Editor because it, correctly,
overwrites the whole file and then diffs show a lot of unrelated changes.
So, this report will inform us about any file needing to be regenerated
because it has been manually edited (in a different way than the way
the editor has).
Note that the report is very basic, with minimal ouput, manually
generating the HTML, like the rest of the XMLDB Editor actions do. We
are not using renderers neither templates here.
Also note that it includes a commented line of code that, once
uncommented, enables the report to, also, fix the wrong files. Useful
for developers.
Paul Holden [Tue, 8 Feb 2022 16:35:59 +0000 (16:35 +0000)]
MDL-73811 reportbuilder: ensure audience cards are uniquely keyed.
Ilya Tregubov [Tue, 8 Feb 2022 12:54:21 +0000 (14:54 +0200)]
on-demand release 4.0dev+
cescobedo [Mon, 17 Jan 2022 11:43:03 +0000 (12:43 +0100)]
MDL-71713 auth_cas: Set Moodle files after phpCAS upgrade
cescobedo [Mon, 17 Jan 2022 11:32:43 +0000 (12:32 +0100)]
MDL-71713 auth_cas: Upgrade phpCAS to 1.4.0
Andrew Nicols [Tue, 8 Feb 2022 04:03:42 +0000 (12:03 +0800)]
Merge branch 'MDL-73631' of https://github.com/paulholden/moodle
Jun Pataleta [Tue, 8 Feb 2022 03:36:59 +0000 (11:36 +0800)]
Merge branch 'MDL-72246-master-2' of https://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 2 Feb 2022 08:10:59 +0000 (16:10 +0800)]
MDL-72246 core_completion: Only fetch other completion data on requested
Prior to this patch, the code was fetching all completion data for all
activities in a course, even when the activity was not requested. This
leads to recursion issues as the data has not been added to the cache
before this operation occurs.
To handle this situation, only the requested CM is fetched in full, and
a boolean flag is used to store whether the full data has been fetched.
When returning a partially fetched value from the cache, the flag is
used to determine whether more data must be fetched, and the cache
updated.
The flag is filtered out before the value is returned.
Note: Many of the tests were updated as these were inspecting private
features of the API which should not really be tested.
Andrew Nicols [Thu, 3 Feb 2022 05:27:24 +0000 (13:27 +0800)]
MDL-72246 core_completion: Test coverage improvements for completion
Andrew Nicols [Thu, 3 Feb 2022 03:09:50 +0000 (11:09 +0800)]
MDL-72246 core_completion: Stop testing the inner workings of get_data()
Andrew Nicols [Tue, 8 Feb 2022 02:59:34 +0000 (10:59 +0800)]
Merge branch 'MDL-73716' of https://github.com/stronk7/moodle
Andrew Nicols [Tue, 8 Feb 2022 02:57:40 +0000 (10:57 +0800)]
Merge branch 'MDL-73116' of https://github.com/roland04/moodle
Andrew Nicols [Tue, 8 Feb 2022 02:54:44 +0000 (10:54 +0800)]
Merge branch 'MDL-73766-master' of https://github.com/lucaboesch/moodle
Víctor Déniz [Mon, 7 Feb 2022 18:13:20 +0000 (18:13 +0000)]
Merge branch 'MDL-73279' of https://github.com/call-learning/moodle
Eloy Lafuente (stronk7) [Mon, 7 Feb 2022 11:01:19 +0000 (12:01 +0100)]
Merge branch 'MDL-73601-master' of https://github.com/aanabit/moodle
Mikel Martín [Mon, 29 Nov 2021 10:59:36 +0000 (11:59 +0100)]
MDL-73116 reportbuilder: Use triggerElement parameter to return focus
Mikel Martín [Thu, 18 Nov 2021 11:31:43 +0000 (12:31 +0100)]
MDL-73116 core: Add triggerElement parameter to saveCancel dialogue
triggerElement parameter is used to return the focus after modal is hidden
Eloy Lafuente (stronk7) [Mon, 7 Feb 2022 09:42:17 +0000 (10:42 +0100)]
MDL-73716 phpunit: remove old simpletest static members
And replace them by phpunit @covers annotations including
all the classes declared or extended in the removed members.
It's not awesome coverage, but better than nothing.
Shamim Rezaie [Mon, 7 Feb 2022 07:40:39 +0000 (18:40 +1100)]
Merge branch 'MDL-73684-master' of https://github.com/marinaglancy/moodle
Luca Bösch [Thu, 3 Feb 2022 21:11:45 +0000 (22:11 +0100)]
MDL-73766 theme_boost: have login page use loginto string
Andrew Nicols [Mon, 7 Feb 2022 06:23:31 +0000 (14:23 +0800)]
Merge branch 'MDL-73697-master' of https://github.com/ferranrecio/moodle
Shamim Rezaie [Mon, 7 Feb 2022 05:41:26 +0000 (16:41 +1100)]
Merge branch 'MDL-73644-master' of https://github.com/lameze/moodle
Shamim Rezaie [Mon, 7 Feb 2022 05:36:39 +0000 (16:36 +1100)]
Merge branch 'MDL-73480-master' of https://github.com/bmbrands/moodle
Andrew Nicols [Mon, 7 Feb 2022 05:34:01 +0000 (13:34 +0800)]
Merge branch 'MDL-73659' of https://github.com/stronk7/moodle
Simey Lameze [Thu, 20 Jan 2022 07:18:17 +0000 (15:18 +0800)]
MDL-73644 core: link confirm module CL to related JSDoc
Huong Nguyen [Mon, 7 Feb 2022 03:57:16 +0000 (10:57 +0700)]
MDL-73784 usertours: Update tour steps to use Moodle langstring
Huong Nguyen [Mon, 7 Feb 2022 03:42:34 +0000 (10:42 +0700)]
MDL-73784 usertours: Support multiple PIXICON placeholder
Huong Nguyen [Mon, 7 Feb 2022 02:48:53 +0000 (09:48 +0700)]
MDL-73784 usertours: Make End tour button's label translatable
We can use the Moodle language format for End tour button's label now
Huong Nguyen [Mon, 7 Feb 2022 02:45:24 +0000 (09:45 +0700)]
MDL-73784 usertours: Deprecation of the step::get_string_from_input
Modified code to just simply call helper::get_string_from_input() rather than duplicating the code
Huong Nguyen [Mon, 7 Feb 2022 02:39:39 +0000 (09:39 +0700)]
MDL-73784 usertours: Improve the tours maching
- Introduce some new constants like MY, MYCOURSES, FRONTPAGE_MY...
- The Tour now can detect the URL match is pointing to Dashboard (/my/) or My Course (/my/courses.php) correctly
Andrew Nicols [Mon, 7 Feb 2022 02:12:20 +0000 (10:12 +0800)]
Merge branch 'master_MDL-73666-questionimagebug' of https://github.com/catalyst/moodle-MDL-70329
Andrew Nicols [Mon, 7 Feb 2022 01:53:09 +0000 (09:53 +0800)]
Merge branch 'MDL-71712-master' of https://github.com/aanabit/moodle
Marc-Alexandre Ghaly [Sat, 29 Jan 2022 02:58:44 +0000 (21:58 -0500)]
MDL-73666 core_question: Question bank usage and comment modal fix
Fix for question bank modals not showing question images.
Eloy Lafuente (stronk7) [Fri, 21 Jan 2022 21:59:40 +0000 (22:59 +0100)]
MDL-73659 phpunit: restore_date, api, rule, plugin, manager & helper
All restore_date_test, api_test, rule_test, plugin_test,
manager_test, helper_test testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Special mention to:
- All restore_date_test cases have been put under xxx\backup
level 2 (valid API) namespace.
Sara Arjona [Fri, 4 Feb 2022 17:18:46 +0000 (18:18 +0100)]
on-demand release 4.0dev+
Paul Holden [Fri, 4 Feb 2022 11:59:36 +0000 (11:59 +0000)]
MDL-73669 behat: correctly deprecate step for using flat navigation.
Marina Glancy [Fri, 4 Feb 2022 16:16:10 +0000 (17:16 +0100)]
MDL-73669 core_enrol: move deprecated behat steps to own file
Steps were initially deprecated in MDL-72090
Marina Glancy [Fri, 4 Feb 2022 16:14:57 +0000 (17:14 +0100)]
MDL-73669 core_calendar: move deprecated behat steps to own file
Steps were initially deprecated in MDL-72810
Marina Glancy [Fri, 4 Feb 2022 16:13:08 +0000 (17:13 +0100)]
MDL-73669 behat: allow multiple files with deprecated steps
Sara Arjona [Fri, 4 Feb 2022 14:54:44 +0000 (15:54 +0100)]
MDL-71696 question: Fix random PHPUnit error with question order
Sara Arjona [Fri, 4 Feb 2022 09:34:21 +0000 (10:34 +0100)]
MDL-71696 question: Fix Oracle GROUP BY error - Round 2
Eloy Lafuente (stronk7) [Fri, 4 Feb 2022 08:48:17 +0000 (09:48 +0100)]
Merge branch 'MDL-71696-behat-oracle-fix' of https://github.com/sarjona/moodle
Sara Arjona [Fri, 4 Feb 2022 08:26:18 +0000 (09:26 +0100)]
MDL-71696 core_question: Fix Oracle GROUP BY error
Paul Holden [Fri, 4 Feb 2022 11:59:36 +0000 (11:59 +0000)]
MDL-73773 behat: correctly deprecate step for using flat navigation.
Jun Pataleta [Fri, 4 Feb 2022 02:36:50 +0000 (10:36 +0800)]
Merge branch 'MDL-73651-master' of git://github.com/rezaies/moodle
Shamim Rezaie [Thu, 3 Feb 2022 02:00:40 +0000 (13:00 +1100)]
MDL-73651 calendar: search in localised module type names as well
Víctor Déniz [Thu, 3 Feb 2022 22:20:20 +0000 (22:20 +0000)]
Merge branch 'MDL-73514' of https://github.com/stronk7/moodle
Víctor Déniz [Thu, 3 Feb 2022 22:02:39 +0000 (22:02 +0000)]
Merge branch 'MDL-73517' of https://github.com/stronk7/moodle
Víctor Déniz [Thu, 3 Feb 2022 21:45:50 +0000 (21:45 +0000)]
Merge branch 'MDL-73758-master' of https://github.com/snake/moodle
Eloy Lafuente (stronk7) [Thu, 3 Feb 2022 21:38:28 +0000 (22:38 +0100)]
Merge branch 'MDL-71696-fix-oracle' of https://github.com/sarjona/moodle
Víctor Déniz [Thu, 3 Feb 2022 21:29:09 +0000 (21:29 +0000)]
Merge branch 'MDL-73605' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 3 Feb 2022 21:27:02 +0000 (22:27 +0100)]
Merge branch 'MDL-73765-master-twenty-three-minutes' of https://github.com/mudrd8mz/moodle
Sara Arjona [Thu, 3 Feb 2022 18:28:27 +0000 (19:28 +0100)]
MDL-71696 question: Fix Oracle failures with ambiguous colum
David Mudrák [Thu, 3 Feb 2022 18:17:42 +0000 (19:17 +0100)]
MDL-73765 task: Fix calculation of random minute in the task schedule
The random minute was incorrectly set to a random value from the range
0 - 23 instead of 0 - 59 due to this copy & paste mistake.
Sara Arjona [Thu, 3 Feb 2022 14:10:01 +0000 (15:10 +0100)]
MDL-71696 question: Align new tables with install/upgrade
Amended because, in all cases, install.xml wins and we
have make upgrade.php to match it...
But in the question_versions->status case, that needs to
be NOT_NULL, so upgrade was correct and install.xml has
been changed for it.
Note this has been changed without using the editor because
it has been detected that there are other changes in the xml
file that have been added manually, we'll create a "reconcile"
issue to fix that (mainly whitespace).
So, yes, please, always use the editor.
Ilya Tregubov [Thu, 3 Feb 2022 14:37:55 +0000 (16:37 +0200)]
Merge branch 'MDL-73664-master' of https://github.com/aanabit/moodle
Eloy Lafuente (stronk7) [Thu, 3 Feb 2022 14:25:18 +0000 (15:25 +0100)]
Merge branch 'MDL-73507-master' of https://github.com/lameze/moodle
Gareth Barnard [Tue, 1 Feb 2022 15:30:46 +0000 (15:30 +0000)]
MDL-73719 themes: Redundant theme_reset_all_caches callback.
Eloy Lafuente (stronk7) [Thu, 3 Feb 2022 13:59:00 +0000 (14:59 +0100)]
Merge branch 'MDL-73728-master' of https://github.com/andrewnicols/moodle
Paul Holden [Mon, 17 Jan 2022 23:11:17 +0000 (23:11 +0000)]
MDL-73605 mod_forum: add label/help to the subscription mode options.