integration.git
2 years agoMDL-75012 js: Remove orphaned source maps baef734ef7ae33507b98d759ac498dd3bbdbfa80
Jun Pataleta [Thu, 2 Mar 2023 05:04:55 +0000 (13:04 +0800)]
MDL-75012 js: Remove orphaned source maps

2 years agoMDL-75012 core: Fix upgrade.txt conflicts 8ce226081c54d5113b2771f148035e45b0772ed1
Jun Pataleta [Thu, 2 Mar 2023 04:57:28 +0000 (12:57 +0800)]
MDL-75012 core: Fix upgrade.txt conflicts

2 years agoMerge branch 'MDL-75012-master-5' of https://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 2 Mar 2023 04:34:34 +0000 (12:34 +0800)]
Merge branch 'MDL-75012-master-5' of https://github.com/andrewnicols/moodle

2 years agoMerge branch 'MDL-77386-master' of https://github.com/ferranrecio/moodle
Andrew Nicols [Thu, 2 Mar 2023 04:06:27 +0000 (12:06 +0800)]
Merge branch 'MDL-77386-master' of https://github.com/ferranrecio/moodle

2 years agoMerge branch 'MDL-76825-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Thu, 2 Mar 2023 04:05:07 +0000 (12:05 +0800)]
Merge branch 'MDL-76825-master' of https://github.com/meirzamoodle/moodle

2 years agoMerge branch 'MDL-75719-master-4' of https://github.com/ilyatregubov/moodle
Jun Pataleta [Thu, 2 Mar 2023 04:02:44 +0000 (12:02 +0800)]
Merge branch 'MDL-75719-master-4' of https://github.com/ilyatregubov/moodle

2 years agoMDL-75012 js: Full build of all grunt things
Andrew Nicols [Tue, 28 Feb 2023 03:01:10 +0000 (11:01 +0800)]
MDL-75012 js: Full build of all grunt things

2 years agoMDL-75012 js: Bump Babel dependencies ee0e2bcc8f55e719b32b905fc31b44a317c0ad60
Andrew Nicols [Tue, 28 Feb 2023 02:17:15 +0000 (10:17 +0800)]
MDL-75012 js: Bump Babel dependencies

Please note that whilst some dependencies have higher versions
available, these are not compatible at this time.

2 years agoMDL-75012 js: Remove unused babel-preset-minify dependency ed3c951001a1c57db9eb8e498f64523bb1d9c1d5
Andrew Nicols [Tue, 28 Feb 2023 02:24:04 +0000 (10:24 +0800)]
MDL-75012 js: Remove unused babel-preset-minify dependency

2 years agoMDL-75012 js: Drop support for modules built pre-babel 84c650489ab097771b50e6c63d26ffdd001db037
Andrew Nicols [Fri, 24 Feb 2023 01:22:14 +0000 (09:22 +0800)]
MDL-75012 js: Drop support for modules built pre-babel

We now include more polyfills than we have ever done, and some of these
cause false-positives on our code to address modules which do not have a
name.

We started adding module names to modules in Moodle 3.8 at _build_ time
and kept support for modules which were not transpiled using Babel
before that point.

We no longer need to support this as all pre-3.8 Moodle versions are
long out of support. The most recent to go out of support was Moodle
3.5, which went completely out of support in May 2021.

We should not support code written and minified without a transpilation
phase from this time any longer.

2 years agoMDL-77141 gradereport_user: Adjust course name to fix test
Andrew Nicols [Thu, 2 Mar 2023 03:49:38 +0000 (11:49 +0800)]
MDL-77141 gradereport_user: Adjust course name to fix test

2 years agoMerge branch 'MDL-77141-master' of https://github.com/lucaboesch/moodle
Andrew Nicols [Thu, 2 Mar 2023 03:49:00 +0000 (11:49 +0800)]
Merge branch 'MDL-77141-master' of https://github.com/lucaboesch/moodle

2 years agoMerge branch 'MDL-77461-master' of https://github.com/andrewnicols/moodle
Jake Dallimore [Thu, 2 Mar 2023 03:42:23 +0000 (11:42 +0800)]
Merge branch 'MDL-77461-master' of https://github.com/andrewnicols/moodle

2 years agoMerge branch 'MDL-77400-master' of https://github.com/dpalou/moodle
Jake Dallimore [Thu, 2 Mar 2023 03:27:04 +0000 (11:27 +0800)]
Merge branch 'MDL-77400-master' of https://github.com/dpalou/moodle

2 years agoMerge branch 'MDL-77368' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 2 Mar 2023 03:18:34 +0000 (11:18 +0800)]
Merge branch 'MDL-77368' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-61458' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 2 Mar 2023 03:16:57 +0000 (11:16 +0800)]
Merge branch 'MDL-61458' of https://github.com/paulholden/moodle

2 years agoMDL-77461 behat: Use get_course_id instead of DB fetch
Andrew Nicols [Thu, 2 Mar 2023 03:05:54 +0000 (11:05 +0800)]
MDL-77461 behat: Use get_course_id instead of DB fetch

2 years agoMDL-75719 completion: Add Behat scenario for completion states.
Ilya Tregubov [Fri, 20 Jan 2023 06:41:04 +0000 (14:41 +0800)]
MDL-75719 completion: Add Behat scenario for completion states.

2 years agoMDL-75719 completion: Fix unit tests and Behat tests.
Ilya Tregubov [Tue, 17 Jan 2023 01:53:30 +0000 (09:53 +0800)]
MDL-75719 completion: Fix unit tests and Behat tests.

Fix tests since we changed behavior of completions (completion
state an UI).

2 years agoMDL-75719 completion: Fix viewed criteria.
Ilya Tregubov [Tue, 17 Jan 2023 01:59:56 +0000 (09:59 +0800)]
MDL-75719 completion: Fix viewed criteria.

When we unlock completion criteria and save changes 'viewed' criteria
still should be completed if user has viewed activity before. Seems
that that was broken by recent changes. Fixing here.

2 years agoMDL-75719 completion: Fix completion state for hidden grade items.
Ilya Tregubov [Tue, 17 Jan 2023 01:37:14 +0000 (09:37 +0800)]
MDL-75719 completion: Fix completion state for hidden grade items.

For hidden grade items we used to mark students as completed if
they have any grade. But this was not working correctly when we
also set pass grade for activity and completion criteria based
on pass grade. So we will have these completion states

Competion criteria 'Receive grade':
No grade - COMPLETION_INCOMPLETE
Grade visible, achieved passing grade - COMPLETION_COMPLETE_PASS
Grade visible, failed passing grade - COMPLETION_COMPLETE_FAIL
Grade hidden - COMPLETION_COMPLETE

Completion criteris 'Receive passing grade'
No grade - COMPLETION_INCOMPLETE
Grade visible, achieved passing grade - COMPLETION_COMPLETE_PASS
Grade visible, failed passing grade - COMPLETION_COMPLETE_FAIL
Grade hidden, achieved passing grade - COMPLETION_COMPLETE_PASS
Grade hidden, failed passing grade - COMPLETION_COMPLETE_FAIL_HIDDEN

2 years agoMerge branch 'MDL-77318-master' of https://github.com/Utdanningsdirektoratet/moodle
Jake Dallimore [Thu, 2 Mar 2023 02:55:45 +0000 (10:55 +0800)]
Merge branch 'MDL-77318-master' of https://github.com/Utdanningsdirektoratet/moodle

2 years agoMerge branch 'MDL-77150' of https://github.com/roland04/moodle
Andrew Nicols [Thu, 2 Mar 2023 02:46:49 +0000 (10:46 +0800)]
Merge branch 'MDL-77150' of https://github.com/roland04/moodle

2 years agoMerge branch 'MDL-75534-master-forum-usermodified-zero' of https://github.com/mudrd8m...
Andrew Nicols [Thu, 2 Mar 2023 02:38:15 +0000 (10:38 +0800)]
Merge branch 'MDL-75534-master-forum-usermodified-zero' of https://github.com/mudrd8mz/moodle

2 years agoMerge branch 'MDL-76298' of https://github.com/timhunt/moodle
Jake Dallimore [Thu, 2 Mar 2023 02:12:43 +0000 (10:12 +0800)]
Merge branch 'MDL-76298' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-77413-master' of https://github.com/andelacruz/moodle
Jun Pataleta [Thu, 2 Mar 2023 01:46:02 +0000 (09:46 +0800)]
Merge branch 'MDL-77413-master' of https://github.com/andelacruz/moodle

2 years agoMerge branch 'MDL-77391' of https://github.com/jrchamp/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:26:13 +0000 (09:26 +0800)]
Merge branch 'MDL-77391' of https://github.com/jrchamp/moodle

2 years agoMerge branch 'MDL-77321' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:24:44 +0000 (09:24 +0800)]
Merge branch 'MDL-77321' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-77412' of https://github.com/sumaiyamannan/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:23:49 +0000 (09:23 +0800)]
Merge branch 'MDL-77412' of https://github.com/sumaiyamannan/moodle

2 years agoMerge branch 'MDL-40600-master-duplicate_section' of https://github.com/alexmorrisnz...
Andrew Nicols [Thu, 2 Mar 2023 01:23:05 +0000 (09:23 +0800)]
Merge branch 'MDL-40600-master-duplicate_section' of https://github.com/alexmorrisnz/moodle

2 years agoMerge branch 'MDL-77135-master' of https://github.com/aanabit/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:19:14 +0000 (09:19 +0800)]
Merge branch 'MDL-77135-master' of https://github.com/aanabit/moodle

2 years agoMerge branch 'MDL-75753-master' of https://github.com/call-learning/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:14:06 +0000 (09:14 +0800)]
Merge branch 'MDL-75753-master' of https://github.com/call-learning/moodle

2 years agoMDL-77277 theme_boost: Add reference to CL update
Andrew Nicols [Thu, 2 Mar 2023 01:13:09 +0000 (09:13 +0800)]
MDL-77277 theme_boost: Add reference to CL update

2 years agoMerge branch 'MDL-77277-master' of https://github.com/skodak/moodle
Andrew Nicols [Thu, 2 Mar 2023 01:11:22 +0000 (09:11 +0800)]
Merge branch 'MDL-77277-master' of https://github.com/skodak/moodle

2 years agoMerge branch 'MDL-74586-master-sqlrss' of https://github.com/mudrd8mz/moodle
Jun Pataleta [Thu, 2 Mar 2023 00:58:28 +0000 (08:58 +0800)]
Merge branch 'MDL-74586-master-sqlrss' of https://github.com/mudrd8mz/moodle

2 years agoMerge branch 'MDL-76938_restore_comments' of https://github.com/davosmith/moodle
Jun Pataleta [Thu, 2 Mar 2023 00:42:15 +0000 (08:42 +0800)]
Merge branch 'MDL-76938_restore_comments' of https://github.com/davosmith/moodle

2 years agoMerge branch 'MDL-77430' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 1 Mar 2023 15:59:40 +0000 (23:59 +0800)]
Merge branch 'MDL-77430' of https://github.com/stronk7/moodle

2 years agoMerge branch 'MDL-77417' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 1 Mar 2023 15:54:34 +0000 (23:54 +0800)]
Merge branch 'MDL-77417' of https://github.com/stronk7/moodle

2 years agoMDL-77277 theme_boost: remove Bootstrap version reference
Petr Skoda [Wed, 1 Mar 2023 12:01:18 +0000 (13:01 +0100)]
MDL-77277 theme_boost: remove Bootstrap version reference

2 years agoMerge branch 'MDL-77250-master' of https://github.com/lameze/moodle
Jun Pataleta [Wed, 1 Mar 2023 09:08:07 +0000 (17:08 +0800)]
Merge branch 'MDL-77250-master' of https://github.com/lameze/moodle

2 years agoMerge branch 'MDL-76897' of https://github.com/timhunt/moodle
Jake Dallimore [Wed, 1 Mar 2023 04:43:58 +0000 (12:43 +0800)]
Merge branch 'MDL-76897' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-77299-master' of https://github.com/meirzamoodle/moodle
Andrew Nicols [Wed, 1 Mar 2023 03:14:36 +0000 (11:14 +0800)]
Merge branch 'MDL-77299-master' of https://github.com/meirzamoodle/moodle

2 years agoMDL-77299 mod_quiz: Added missing class properties.
Meirza [Tue, 28 Feb 2023 02:47:16 +0000 (09:47 +0700)]
MDL-77299 mod_quiz: Added missing class properties.

In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.

Co-authored-by: Tim Hunt <t.j.Hunt@open.ac.uk>
2 years agoMDL-77299 question: Added class properties that are not declared.
Meirza [Wed, 8 Feb 2023 16:37:33 +0000 (23:37 +0700)]
MDL-77299 question: Added class properties that are not declared.

In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.

Co-authored-by: Tim Hunt <t.j.Hunt@open.ac.uk>
2 years agoMerge branch 'MDL-58945' of https://github.com/timhunt/moodle
Andrew Nicols [Wed, 1 Mar 2023 02:54:13 +0000 (10:54 +0800)]
Merge branch 'MDL-58945' of https://github.com/timhunt/moodle

2 years agoMerge branch 'MDL-68776' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 1 Mar 2023 02:53:08 +0000 (10:53 +0800)]
Merge branch 'MDL-68776' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-74585' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 1 Mar 2023 02:51:26 +0000 (10:51 +0800)]
Merge branch 'MDL-74585' of https://github.com/paulholden/moodle

2 years agoMerge branch 'MDL-77322_basicauth_checkbox' of https://github.com/leonstr/moodle
Andrew Nicols [Wed, 1 Mar 2023 02:49:21 +0000 (10:49 +0800)]
Merge branch 'MDL-77322_basicauth_checkbox' of https://github.com/leonstr/moodle

2 years agoMerge branch 'MDL-72727' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 1 Mar 2023 02:46:09 +0000 (10:46 +0800)]
Merge branch 'MDL-72727' of https://github.com/paulholden/moodle

2 years agoMDL-77277 tool_componentlibrary: import Bootstrap v4.6.2
Petr Skoda [Fri, 17 Feb 2023 12:05:17 +0000 (13:05 +0100)]
MDL-77277 tool_componentlibrary: import Bootstrap v4.6.2

2 years agoMDL-77277 theme_boost: import Bootstrap v4.6.2
Petr Skoda [Wed, 18 Jan 2023 15:21:30 +0000 (16:21 +0100)]
MDL-77277 theme_boost: import Bootstrap v4.6.2

2 years agoMDL-61458 tool_lp: remove custom cohort autocomplete form selector.
Paul Holden [Thu, 2 Feb 2023 21:56:10 +0000 (21:56 +0000)]
MDL-61458 tool_lp: remove custom cohort autocomplete form selector.

The previous commit replaced the only remaining usage of it with the
equivalent core cohort form element. Prior to that, 21a0008f had done
the same.

2 years agoMDL-77150 reportbuilder: Fix report attributes classes are ignored
Mikel Martín [Fri, 10 Feb 2023 14:18:12 +0000 (15:18 +0100)]
MDL-77150 reportbuilder: Fix report attributes classes are ignored

Fix report attributes with key 'class' being ingored when adding them to report classes.

2 years agoMDL-77150 core_table: Fix classes added as columnsattributes are ignored
Mikel Martín [Tue, 7 Feb 2023 13:51:36 +0000 (14:51 +0100)]
MDL-77150 core_table: Fix classes added as columnsattributes are ignored

Fix columnattributes with key 'class' being ingored by adding them to every 'column_class'.

2 years agoMDL-77391 question admin: further improve query peformance in qtypes.php
Jonathan Champ [Thu, 23 Feb 2023 19:01:53 +0000 (14:01 -0500)]
MDL-77391 question admin: further improve query peformance in qtypes.php

2 years agoMerge branch 'MDL-77425' of https://github.com/stronk7/moodle
Andrew Nicols [Tue, 28 Feb 2023 15:03:49 +0000 (23:03 +0800)]
Merge branch 'MDL-77425' of https://github.com/stronk7/moodle

2 years agoMerge branch 'MDL-73018_bump-travis-and-gha-to-use-php81-instead-of-php80' of https...
Andrew Nicols [Tue, 28 Feb 2023 15:02:57 +0000 (23:02 +0800)]
Merge branch 'MDL-73018_bump-travis-and-gha-to-use-php81-instead-of-php80' of https://github.com/ziegenberg/moodle

2 years agoMDL-74586 rss: Make rss_get_userid_from_token() use table index
David Mudrák [Mon, 27 Feb 2023 17:26:41 +0000 (18:26 +0100)]
MDL-74586 rss: Make rss_get_userid_from_token() use table index

Due to missing `AND k.script = 'rss'` condition, the query did not make
use of the existing script-value compound index defined for the table.
So it had to perform the full sequential scan for all rows when
searching for the token. This had serious performance issues on sites
with many users, especially in case on non-existing token / key.

2 years agoMDL-77430 plugininfo: php81 deprecation warnings on missing plugins
Eloy Lafuente (stronk7) [Tue, 28 Feb 2023 10:34:21 +0000 (11:34 +0100)]
MDL-77430 plugininfo: php81 deprecation warnings on missing plugins

Whenever some plugin is missing from disk but installed, the plugins
page (and the upgrade) shows them as "missing from disk". Still, the
code tries to do things with their directory that, now, is null.

That was silently defaulting to '' in previous php versions, but
php81 emits a deprecated warning. So we have to check for them.

2 years agoMerge branch 'MDL-76992-master' of https://github.com/aanabit/moodle
Jun Pataleta [Tue, 28 Feb 2023 10:26:12 +0000 (18:26 +0800)]
Merge branch 'MDL-76992-master' of https://github.com/aanabit/moodle

2 years agoMDL-73018 ci: Move highest PHP to 8.1 (from current 8.0)
Daniel Ziegenberg [Sun, 22 May 2022 18:25:51 +0000 (20:25 +0200)]
MDL-73018 ci: Move highest PHP to 8.1 (from current 8.0)

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
2 years agoMDL-77400 reportbuilder: Fix enrolment status return type
Dani Palou [Tue, 28 Feb 2023 08:06:33 +0000 (09:06 +0100)]
MDL-77400 reportbuilder: Fix enrolment status return type

2 years agoMDL-76992 core_courseindex: Apply indentation in the course index
Amaia Anabitarte [Wed, 8 Feb 2023 21:28:41 +0000 (22:28 +0100)]
MDL-76992 core_courseindex: Apply indentation in the course index

2 years agoMDL-77413 Behat: Minor changes to optimise the existing tests
Angelia Dela Cruz [Tue, 28 Feb 2023 09:12:48 +0000 (17:12 +0800)]
MDL-77413 Behat: Minor changes to optimise the existing tests

2 years agoMDL-77413 Behat: Add coverage to verify groups can have a picture
Angelia Dela Cruz [Mon, 27 Feb 2023 05:46:21 +0000 (13:46 +0800)]
MDL-77413 Behat: Add coverage to verify groups can have a picture

2 years agoMerge branch 'MDL-77248-master' of https://github.com/andrewnicols/moodle
Jun Pataleta [Tue, 28 Feb 2023 07:46:54 +0000 (15:46 +0800)]
Merge branch 'MDL-77248-master' of https://github.com/andrewnicols/moodle

2 years agoMDL-77248 mod_bigbluebuttonbn: Remove unused dpa pages
Andrew Nicols [Wed, 15 Feb 2023 14:08:20 +0000 (22:08 +0800)]
MDL-77248 mod_bigbluebuttonbn: Remove unused dpa pages

2 years agoMDL-77248 mod_bigbluebuttonbn: Set dpa accepted when creating activities
Andrew Nicols [Wed, 15 Feb 2023 04:05:02 +0000 (12:05 +0800)]
MDL-77248 mod_bigbluebuttonbn: Set dpa accepted when creating activities

This only applies when creating activities using the test data
generator.

2 years agoMDL-77248 core: Move pre_enable_plugin_actions callback to enable_plugin
Andrew Nicols [Mon, 13 Feb 2023 14:11:43 +0000 (22:11 +0800)]
MDL-77248 core: Move pre_enable_plugin_actions callback to enable_plugin

Note: The original callback was incorrectly using the $PAGE output,
which cannot be relied upon in this callback. The best we can do here is
to add a notification to explain the situation.

2 years agoMDL-77248 core_admin: Tidy up coding style of admin/modules
Andrew Nicols [Mon, 13 Feb 2023 05:31:33 +0000 (13:31 +0800)]
MDL-77248 core_admin: Tidy up coding style of admin/modules

2 years agoMDL-75012 js: Put shifter on a diet 784098fe9e6dec5a39317d91ea08c771ff893b76
Andrew Nicols [Wed, 22 Feb 2023 07:17:36 +0000 (15:17 +0800)]
MDL-75012 js: Put shifter on a diet

This commit switches to a new custom version of Shifter which sees it
put on a massive diet.

Many of the standard Shifter features are totally unused by Moodle, but
they add dependency spaghetti. Some of those dependencies will start to
cause us issues as they have not been updated for a very long time, are
no longer maintained, and are no longer compatible with anything
resembling a recent version of NodeJS.

2 years agoMDL-75012 js: Bump shifter to new version b3f7721cdd18dc0598c6b1fb79dedc8fb18d2ba3
Andrew Nicols [Tue, 7 Feb 2023 04:12:23 +0000 (12:12 +0800)]
MDL-75012 js: Bump shifter to new version

This resolves an issue identified in 77083 which identified that GitHub
hashes shouldn't be treated as repeatable.

Whilst GitHub have reverted this change, it's still worth making this
change.

2 years agoMDL-75012 js: Use our own jsdoc wrapper 5d0631b6a16d012b41c94c4f7c512989e17433dd
Andrew Nicols [Fri, 3 Feb 2023 14:48:04 +0000 (22:48 +0800)]
MDL-75012 js: Use our own jsdoc wrapper

grunt-jsdoc is abandoned and only works with an older version of jsdoc.

This is a very simple wrapper around jsdoc itself.

2 years agoMDL-75012 js: Audit fix 472fc27ab94c134037039e4ecd95d7b9210afb2e
Andrew Nicols [Fri, 3 Feb 2023 13:36:41 +0000 (21:36 +0800)]
MDL-75012 js: Audit fix

2 years agoMDL-75012 js: Bump node-sass 7c3db6d4583bee040391f55b5719dbb8f14380f3
Andrew Nicols [Fri, 3 Feb 2023 13:28:41 +0000 (21:28 +0800)]
MDL-75012 js: Bump node-sass

2 years agoMDL-75012 js: Update browserslist 19f5ffb28ab4af3fcb05bc9e7afb2c196bef93ff
Andrew Nicols [Fri, 3 Feb 2023 05:47:50 +0000 (13:47 +0800)]
MDL-75012 js: Update browserslist

To avoid build changes we exclude older versions of Android browser

2 years agoMDL-75012 js: Bump stylelint and components 1c73373b3d2aa417d1aae0699f7e61e1b75d3a5d
Andrew Nicols [Fri, 3 Feb 2023 03:24:18 +0000 (11:24 +0800)]
MDL-75012 js: Bump stylelint and components

2 years agoMDL-75012 js: Remove grunt-contrib-uglify abb687759651b59ced572ec77d99fa468cf63d6d
Andrew Nicols [Fri, 3 Feb 2023 02:54:57 +0000 (10:54 +0800)]
MDL-75012 js: Remove grunt-contrib-uglify

We stopped using this when we updated our processes to support ESMs in
MDL-62497. Removal of the dependency was missed at the time.

2 years agoMDL-75012 js: Bump standard dependencies f70d9a3eef11b25c1683332c94c89bd7aaf91aab
Andrew Nicols [Fri, 3 Feb 2023 02:18:57 +0000 (10:18 +0800)]
MDL-75012 js: Bump standard dependencies

This change bumps dependencies which have no impact upon the build
process

2 years agoMDL-75012 core: Bump NodeJS version requirements 6d0fdd8fd8c26b50fae894839a63880f8ca6009c
Andrew Nicols [Fri, 4 Nov 2022 04:35:37 +0000 (12:35 +0800)]
MDL-75012 core: Bump NodeJS version requirements

2 years agoMerge branch 'MDL-76956-master' of https://github.com/sammarshallou/moodle
Jun Pataleta [Tue, 28 Feb 2023 02:07:01 +0000 (10:07 +0800)]
Merge branch 'MDL-76956-master' of https://github.com/sammarshallou/moodle

2 years agoMerge branch 'MDL-77276-master' of https://github.com/sarjona/moodle
Jun Pataleta [Tue, 28 Feb 2023 02:05:04 +0000 (10:05 +0800)]
Merge branch 'MDL-77276-master' of https://github.com/sarjona/moodle

2 years agoMerge branch 'MDL-76990-master' of https://github.com/aanabit/moodle
Jun Pataleta [Tue, 28 Feb 2023 01:45:32 +0000 (09:45 +0800)]
Merge branch 'MDL-76990-master' of https://github.com/aanabit/moodle

2 years agoMDL-72727 mod_forum: prevent default favourite toggle click event.
Paul Holden [Mon, 27 Feb 2023 17:21:46 +0000 (17:21 +0000)]
MDL-72727 mod_forum: prevent default favourite toggle click event.

Allow the repository call to the web service method to complete before
re-directing, otherwise the call may not complete and/or races against
the page reload causing random Behat errors.

2 years agoMDL-77412 reportbuilder: Make groupconcat aggregation method sortable.
Sumaiya Javed [Mon, 27 Feb 2023 21:39:00 +0000 (10:39 +1300)]
MDL-77412 reportbuilder: Make groupconcat aggregation method sortable.

2 years agoMDL-77321 reportbuilder: cache list of loaded reports per user.
Paul Holden [Mon, 27 Feb 2023 21:09:39 +0000 (21:09 +0000)]
MDL-77321 reportbuilder: cache list of loaded reports per user.

Since 0188af39 we've cached loaded reports, however there was an
edge case in those report sources that relied on the current user
as part of their own initialization (e.g. checking capabilities).

Co-authored-by: Marina Glancy <marina@moodle.com>
2 years agoMDL-76897 quiz: fix incorrect StdClass
Tim Hunt [Mon, 27 Feb 2023 17:44:33 +0000 (17:44 +0000)]
MDL-76897 quiz: fix incorrect StdClass

2 years agoMDL-76897 quiz: deprecate unused quiz_calculate_best_attempt
Tim Hunt [Fri, 24 Feb 2023 15:16:23 +0000 (15:16 +0000)]
MDL-76897 quiz: deprecate unused quiz_calculate_best_attempt

2 years agoMDL-76897 quiz: quiz_save_best_grade -> recompute_final_grade
Tim Hunt [Fri, 24 Feb 2023 14:27:25 +0000 (14:27 +0000)]
MDL-76897 quiz: quiz_save_best_grade -> recompute_final_grade

also, the associated quiz_calculate_best_grade (only used here)
moved to a protected method.

2 years agoMDL-76897 quiz: quiz_set_grade -> update_quiz_maximum_grade
Tim Hunt [Fri, 24 Feb 2023 13:43:48 +0000 (13:43 +0000)]
MDL-76897 quiz: quiz_set_grade -> update_quiz_maximum_grade

2 years agoMDL-76897 quiz: quiz_update_all_final_grades -> grade_calculator
Tim Hunt [Wed, 8 Feb 2023 21:49:11 +0000 (21:49 +0000)]
MDL-76897 quiz: quiz_update_all_final_grades -> grade_calculator

2 years agoMDL-76897 quiz: quiz_update_all_attempt_sumgrades -> grade_calculator
Tim Hunt [Wed, 8 Feb 2023 18:08:47 +0000 (18:08 +0000)]
MDL-76897 quiz: quiz_update_all_attempt_sumgrades -> grade_calculator

2 years agoMDL-76897 quiz: get the context more efficiently where possible
Tim Hunt [Mon, 27 Feb 2023 17:43:32 +0000 (17:43 +0000)]
MDL-76897 quiz: get the context more efficiently where possible

2 years agoMDL-76897 quiz: streamline initalisation of $quiz, $cm, $course
Tim Hunt [Wed, 8 Feb 2023 17:41:39 +0000 (17:41 +0000)]
MDL-76897 quiz: streamline initalisation of $quiz, $cm, $course

2 years agoMDL-76990 core_course: Recover move right/left functionality
Amaia Anabitarte [Wed, 8 Feb 2023 16:04:04 +0000 (17:04 +0100)]
MDL-76990 core_course: Recover move right/left functionality

2 years agoMDL-77425 travis: Ensure databases shutdown have time to complete
Eloy Lafuente (stronk7) [Mon, 27 Feb 2023 11:18:51 +0000 (12:18 +0100)]
MDL-77425 travis: Ensure databases shutdown have time to complete

This is only randomly affecting to Moodle 4.2 with PostgreSQL 13
that, for some reason, returns the control to the script before
some files (.pid) have been deleted as part of the database
shutdown.

It seems that adding 1 second of sleep it's enough to workaround
that problem (there are examples of that in various Travis discussions).

So we are adding here 2 seconds, to ensure we are in the safe side
towards consistent passes. And we are applying the same strategy
also to the MySQL installation, just to keep them 100% parallel.

2 years agoMDL-61458 tool_cohortroles: switch to core user/cohort form elements.
Paul Holden [Thu, 2 Feb 2023 11:31:27 +0000 (11:31 +0000)]
MDL-61458 tool_cohortroles: switch to core user/cohort form elements.

Remove last dependency on tool_lp plugin.

2 years agoMerge branch 'MDL-77288-master' of https://github.com/lucaboesch/moodle
Paul Holden [Mon, 27 Feb 2023 10:38:51 +0000 (10:38 +0000)]
Merge branch 'MDL-77288-master' of https://github.com/lucaboesch/moodle

2 years agoMDL-77417 behat: behat_error_handler meets deprecation error types
Eloy Lafuente (stronk7) [Mon, 27 Feb 2023 08:33:08 +0000 (09:33 +0100)]
MDL-77417 behat: behat_error_handler meets deprecation error types

Right now, any E_DEPRECATED, E_USER_DEPRECATED error type leads
to exception in behat runs, because the behat error handled is
not aware of them. See MDL-38041 for the initial implementation.

We don't want that to happen and they must behave like other "low"
error types (notices, warnings...), that will be reported in logs
or output, but won't trigger any exception, so the test can continue.

This commit just adds those 2 "new" error types to the handler,
providing the very same behaviour for them than the rest.

2 years agoMDL-76825 tiny: restyling link on focus for sufficient colour contrast.
Meirza [Thu, 16 Feb 2023 02:46:59 +0000 (09:46 +0700)]
MDL-76825 tiny: restyling link on focus for sufficient colour contrast.

Text elements must have sufficient colour contrast against the background,
restyling the link element when it is focused is to ensure colour contrast of at least 4.5:1