Paul Holden [Mon, 12 Sep 2022 20:43:19 +0000 (21:43 +0100)]
MDL-75734 reportbuilder: remove Oracle restrictions on text columns.
We can filter long text columns in Oracle with appropriate API, so
can remove previous restrictions. See also recent change in
208adcf3
for similar.
Eloy Lafuente (stronk7) [Thu, 22 Sep 2022 15:05:39 +0000 (17:05 +0200)]
weekly release 4.1dev
Eloy Lafuente (stronk7) [Thu, 22 Sep 2022 15:05:36 +0000 (17:05 +0200)]
NOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Thu, 22 Sep 2022 13:32:35 +0000 (15:32 +0200)]
MDL-75153 behat: Add the skip_interim tag to a failing test
Note the failures are unrelated to this issue, but we needed
an ongoing issue to add the tag and this was picked.
The problem, only reproducible @ CI servers will be fixed here:
https://tracker.moodle.org/browse/MDL-75820
Eloy Lafuente (stronk7) [Wed, 21 Sep 2022 12:26:01 +0000 (14:26 +0200)]
Merge branch 'MDL-74762-Master' of https://github.com/catalyst/moodle-MDL-72752
Nathan Nguyen [Wed, 21 Sep 2022 02:10:12 +0000 (12:10 +1000)]
MDL-74762 qbank_statistics: fix unit test failure with Oracle DB
Jun Pataleta [Tue, 20 Sep 2022 07:12:34 +0000 (15:12 +0800)]
Merge branch 'MDL-75777' of https://github.com/stronk7/moodle
Víctor Déniz [Tue, 20 Sep 2022 07:08:55 +0000 (08:08 +0100)]
Merge branch 'MDL-74941-master' of https://github.com/lucaboesch/moodle
Steve Bader [Wed, 7 Sep 2022 19:48:30 +0000 (15:48 -0400)]
MDL-74941 qtype_calculated: Copy dataset from previous question version
Luca Bösch [Fri, 2 Sep 2022 16:56:52 +0000 (18:56 +0200)]
MDL-74941 qtype_calculated: Fix for usage calculation
The patch for the helper functions is by Nathan Nguyen
<nathannguyen@catalyst-au.net> whom I wish to thank.
Ilya Tregubov [Tue, 20 Sep 2022 05:06:05 +0000 (09:06 +0400)]
Merge branch 'master-MDL-74993' of https://github.com/golenkovm/moodle
Ilya Tregubov [Tue, 20 Sep 2022 05:01:42 +0000 (09:01 +0400)]
Merge branch 'MDL-75153-master-2' of https://github.com/mihailges/moodle
Mihail Geshoski [Thu, 15 Sep 2022 17:09:28 +0000 (01:09 +0800)]
MDL-75153 grade: Fix incorrect xpath in the behat step definitions
Mihail Geshoski [Tue, 13 Sep 2022 05:51:01 +0000 (13:51 +0800)]
MDL-75153 grade: Update behat tests
Mihail Geshoski [Tue, 13 Sep 2022 06:11:41 +0000 (14:11 +0800)]
MDL-75153 grade: Deprecate select_in_gradebook_navigation_selector()
Deprecates the select_in_gradebook_navigation_selector() function in
behat_grade.php and removes all usages. The select menu field supports
the same functionality and this function can be simply replaced with
behat_forms::i_set_the_field_to().
Mihail Geshoski [Mon, 12 Sep 2022 06:07:31 +0000 (14:07 +0800)]
MDL-75153 grade: Update the general tertiary nav selector in gradebook
Updates the general tertiary nav selector in gradebook to use the new
structure that utilizes the existing select_menu output component.
Mihail Geshoski [Mon, 12 Sep 2022 06:05:38 +0000 (14:05 +0800)]
MDL-75153 theme: Add template and styling for the tertiary nav selector
Adds new template dedicated for the general tertiary navigation element
which utilizes the exising select_menu output component. Also, adds
custom styling to the tertiary navigation selector element.
Mihail Geshoski [Tue, 13 Sep 2022 05:26:22 +0000 (13:26 +0800)]
MDL-75153 form: Behat support for group structures in select menu field
Adds behat support for group structures in the select menu field. When
looking for a particular option you can further specify the group under
which this option should be located by using the '>' delimiter
(e.g. "Group name > Option name"). In addition to that, this commit
intorduces new step definition which can be used to check whether the
select menu field contains a particular option.
Mihail Geshoski [Mon, 12 Sep 2022 05:41:56 +0000 (13:41 +0800)]
MDL-75153 output: Styling improvements in the select_menu component
Mihail Geshoski [Mon, 12 Sep 2022 02:47:37 +0000 (10:47 +0800)]
MDL-75153 output: Fix the group option and label support in select_menu
The following commit fixes the current logic that is used to return the
selected option and take into account structures with group options.
Also, it adds a default value to the $labelattributes class property to
to fix the issues that occur then the label is not explicitely set by
set_label().
Ilya Tregubov [Mon, 19 Sep 2022 10:00:49 +0000 (14:00 +0400)]
Merge branch 'MDL-75065-master' of https://github.com/devlionco/moodle
Eloy Lafuente (stronk7) [Sun, 18 Sep 2022 14:21:46 +0000 (16:21 +0200)]
MDL-75777 phpunit: Move tests to use correct names and ns (take#6)
Applied the following changes to various testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Jun Pataleta [Mon, 19 Sep 2022 05:02:02 +0000 (13:02 +0800)]
Merge branch 'MDL-75757' of https://github.com/stronk7/moodle
Jun Pataleta [Mon, 19 Sep 2022 04:01:53 +0000 (12:01 +0800)]
Merge branch 'MDL-75186-master' of https://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Sat, 17 Sep 2022 17:53:13 +0000 (19:53 +0200)]
MDL-75757 phpunit: Add some tolerance to a few failing assertions
Recently, PHPUnit (all versions) did some changes about how the
comparators worked and this has caused some float comparisons
to stop working.
We need to move them to assertEqualsWithDelta(), allowing a small
tolerance to workaround the floats comparison problem.
0.00001 has been decided. And applied to all the similar assertions
within the unittest function, so if more cases are added to them
better be copied with the agreed tolerance.
Víctor Déniz [Fri, 16 Sep 2022 13:23:49 +0000 (14:23 +0100)]
Merge branch 'MDL-74762-Master' of https://github.com/catalyst/moodle-MDL-72752
Jun Pataleta [Fri, 16 Sep 2022 13:16:58 +0000 (21:16 +0800)]
Merge branch 'MDL-75295_master' of https://github.com/TomoTsuyuki/moodle
Nathan Nguyen [Mon, 30 May 2022 10:15:10 +0000 (20:15 +1000)]
MDL-74762 qbank_statistics: improve performance loading the data
This issue greatly improves the performance of displaying statistics in
the question bank.
1. The required quiz statistics are now pre-computed by a scheduled task.
2. Cached statistics in the database are now never cleaned up, so the
pre-computed stats are always available.
3. The way the cached statistics are loaded for each question
that is being displayed is now a bit more efficient.
4. Related to that, there is a new callback which activities can implement,
if they want their question statistics to be included in the ones shown
in the question bank.
Note, there is still further improvement possible to load the statistics
for all questions being displayed in bulk. However, that must wait for a
future issue, MDL-75576. The other improvements in this issue are
significant and we did not want to delay releasing them.
Co-authored-by: Jonathan Champ <jrchamp@ncsu.edu>
Co-authored-by: Tim Hunt <t.j.hunt@open.ac.uk>
Tomo Tsuyuki [Fri, 16 Sep 2022 09:31:05 +0000 (19:31 +1000)]
MDL-75295 assignfeedback_editpdf: Convert PDF to png at once
Sara Arjona [Fri, 16 Sep 2022 09:23:14 +0000 (11:23 +0200)]
Merge branch 'MDL-75108-master' of https://github.com/sammarshallou/moodle
Sara Arjona [Fri, 16 Sep 2022 09:20:36 +0000 (11:20 +0200)]
Merge branch 'MDL-75149-master' of https://github.com/ferranrecio/moodle
Sara Arjona [Tue, 9 Aug 2022 08:23:37 +0000 (10:23 +0200)]
MDL-75186 mod_data: Export saved presets
Jun Pataleta [Fri, 16 Sep 2022 02:49:23 +0000 (10:49 +0800)]
Merge branch 'MDL-73933-master' of https://github.com/ferranrecio/moodle
Ferran Recio [Tue, 12 Apr 2022 13:53:29 +0000 (15:53 +0200)]
MDL-73933 core_courseformat: hide and show reactive action
Hide, show and stealth actions were still using the old YUI
module. Now they are using the new course editor
Sara Arjona [Thu, 15 Sep 2022 14:11:47 +0000 (16:11 +0200)]
weekly release 4.1dev
Sara Arjona [Thu, 15 Sep 2022 14:11:47 +0000 (16:11 +0200)]
NOBUG: Fixed file access permissions
Sara Arjona [Thu, 15 Sep 2022 14:11:45 +0000 (16:11 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jun Pataleta [Thu, 15 Sep 2022 03:34:56 +0000 (11:34 +0800)]
Merge branch 'MDL-75398-master' of https://github.com/junpataleta/moodle
Ferran Recio [Mon, 8 Aug 2022 13:31:19 +0000 (15:31 +0200)]
MDL-75398 core_courseformat: deprecate 4th cmname construct param
Jun Pataleta [Thu, 15 Sep 2022 01:55:55 +0000 (09:55 +0800)]
Merge branch 'MDL-75716' of https://github.com/stronk7/moodle
Jun Pataleta [Thu, 15 Sep 2022 01:24:50 +0000 (09:24 +0800)]
Merge branch 'MDL-75714' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Wed, 14 Sep 2022 21:28:08 +0000 (23:28 +0200)]
MDL-75714 navigation: Cover a couple of situations with behat
- Guest user attempting to access to single-activity course.
- Not enrolled user attempt to access to single-activity course.
Both should, by default, land to the "cannot access/enrol" page.
Stefan Hanauska [Sat, 10 Sep 2022 13:44:09 +0000 (15:44 +0200)]
MDL-75714 navigation: Check if node is false
Víctor Déniz [Wed, 14 Sep 2022 21:30:33 +0000 (22:30 +0100)]
Merge branch 'MDL-75558-master' of https://github.com/ssj365/moodle
Víctor Déniz [Wed, 14 Sep 2022 19:30:37 +0000 (20:30 +0100)]
Merge branch 'MDL-75723' of https://github.com/paulholden/moodle
Víctor Déniz [Wed, 14 Sep 2022 19:23:44 +0000 (20:23 +0100)]
Merge branch 'MDL-74965-master' of https://github.com/ssj365/moodle
Víctor Déniz [Wed, 14 Sep 2022 19:00:06 +0000 (20:00 +0100)]
Merge branch 'MDL-75625-master' of https://github.com/ferranrecio/moodle
Víctor Déniz [Wed, 14 Sep 2022 18:50:56 +0000 (19:50 +0100)]
Merge branch 'MDL-75369-master' of https://github.com/sammarshallou/moodle
Víctor Déniz [Wed, 14 Sep 2022 18:36:45 +0000 (19:36 +0100)]
Merge branch 'MDL-74140' of https://github.com/paulholden/moodle
Víctor Déniz [Wed, 14 Sep 2022 18:13:01 +0000 (19:13 +0100)]
Merge branch 'MDL-75639-master' of https://github.com/dravek/moodle
Sara Arjona [Wed, 14 Sep 2022 16:04:51 +0000 (18:04 +0200)]
Merge branch 'MDL-75413-master' of https://github.com/sarjona/moodle
Shamiso.Jaravaza [Wed, 14 Sep 2022 15:08:55 +0000 (09:08 -0600)]
MDL-74965 mod_bigbluebuttonbn: Fix error in role
Sara Arjona [Thu, 25 Aug 2022 14:39:09 +0000 (16:39 +0200)]
MDL-75413 mod_data: Add resources preset
Ferran Recio [Fri, 5 Aug 2022 12:38:01 +0000 (14:38 +0200)]
MDL-75149 mod_data: add preview to presets
Sara Arjona [Wed, 14 Sep 2022 09:41:42 +0000 (11:41 +0200)]
Merge branch 'MDL-74010' of https://github.com/paulholden/moodle
Jun Pataleta [Wed, 14 Sep 2022 03:33:47 +0000 (11:33 +0800)]
Merge branch 'MDL-69888-user-fully-setup-cache' of https://github.com/brendanheywood/moodle
Jun Pataleta [Tue, 13 Sep 2022 21:54:36 +0000 (05:54 +0800)]
Merge branch 'MDL-71129-master' of https://github.com/aanabit/moodle
Jun Pataleta [Tue, 13 Sep 2022 21:33:09 +0000 (05:33 +0800)]
Merge branch 'MDL-75308' of https://github.com/paulholden/moodle
Jun Pataleta [Tue, 13 Sep 2022 12:25:57 +0000 (20:25 +0800)]
Merge branch 'MDL-75637' of https://github.com/paulholden/moodle
sam marshall [Wed, 31 Aug 2022 10:40:34 +0000 (11:40 +0100)]
MDL-75369 Redis: Remove unnecessary ping after connect
The Redis cache store and session handler both do a 'ping()' after
connecting to Redis. This is unnecessary because the connect() call
has just checked the network connection and it's hardly likely that
the server has gone down since then.
According to my profiling, both connect() and ping() take
measurable time when talking to a separate server, i.e. a few
milliseconds. So it's not the case that connect() doesn't really
talk to the server, as I initially wondered.
If using Redis on a separate (non-localhost) server for both session
and cache store, removing these ping calls can save a millisecond
or two per request.
Eloy Lafuente (stronk7) [Sun, 11 Sep 2022 17:34:26 +0000 (19:34 +0200)]
MDL-75716 phpunit: Move tests to use correct names and ns (take#5)
Applied the following changes to various testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Special mention to:
- In lib/tests/blocklib_test.php 2 helper classes have been
moved to tests/fixtures, because they needed to be namespace-free.
Sara Arjona [Mon, 12 Sep 2022 12:56:02 +0000 (14:56 +0200)]
Merge branch 'MDL-74635' of https://github.com/paulholden/moodle
Paul Holden [Fri, 9 Sep 2022 14:51:42 +0000 (15:51 +0100)]
MDL-75723 reportbuilder: show loading icon when toggling edit mode.
Sara Arjona [Mon, 12 Sep 2022 10:30:23 +0000 (12:30 +0200)]
Merge branch 'MDL-75051' of https://github.com/mkassaei/moodle
Paul Holden [Thu, 26 May 2022 22:30:57 +0000 (23:30 +0100)]
MDL-74635 tag: add select all/none tags for bulk actions.
anisa kusumadewi [Thu, 19 May 2022 14:01:57 +0000 (16:01 +0200)]
MDL-71129 core_h5p: Added index for pathnamehash to h5p table
Paul Holden [Mon, 12 Sep 2022 08:55:00 +0000 (09:55 +0100)]
MDL-74140 reportbuilder: debugging panel while editing reports.
Mikhail Golenkov [Thu, 16 Jun 2022 09:05:33 +0000 (19:05 +1000)]
MDL-74993 course: Output cm id when throwing Invalid course module id
AMOS bot [Sun, 11 Sep 2022 00:08:02 +0000 (00:08 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Sat, 10 Sep 2022 08:00:40 +0000 (10:00 +0200)]
weekly release 4.1dev
Jun Pataleta [Fri, 9 Sep 2022 12:49:12 +0000 (20:49 +0800)]
Merge branch 'MDL-75708' of https://github.com/paulholden/moodle
Paul Holden [Fri, 2 Sep 2022 11:03:47 +0000 (12:03 +0100)]
MDL-75637 core: add journal database preset to standard plugin list.
Paul Holden [Fri, 9 Sep 2022 10:03:45 +0000 (11:03 +0100)]
MDL-75708 reportbuilder: consider stress tests as requiring longtest.
We should respect the value of the PHPUNIT_LONGTEST constant in the
report source stress tests, as it was discovered after
165e26fa that
the default configuration of some CIs (GHA) was not sufficient to run
them.
Hence, use the PHPUNIT_LONGTEST to determine whether to execute said
tests. Note this constant is enabled on internal CI.
Mahmoud Kassaei [Mon, 27 Jun 2022 05:22:28 +0000 (06:22 +0100)]
MDL-75051 Questions: Selecting idnumber in the question bank,
the copy/pasting, includes extraneous text in Chrome
David Matamoros [Sun, 4 Sep 2022 06:21:03 +0000 (08:21 +0200)]
MDL-75639 reportbuilder: Add new option to date filter
- In the past: to filter by all dates in the past
- In the future: to filter by all dates in the future
Jun Pataleta [Fri, 9 Sep 2022 00:36:43 +0000 (08:36 +0800)]
weekly release 4.1dev
Jun Pataleta [Thu, 8 Sep 2022 02:08:55 +0000 (10:08 +0800)]
Merge branch 'MDL-74435-master' of https://github.com/lameze/moodle
Jun Pataleta [Thu, 8 Sep 2022 01:40:10 +0000 (09:40 +0800)]
Merge branch 'MDL-75227' of https://github.com/call-learning/moodle
Simey Lameze [Thu, 8 Sep 2022 01:32:36 +0000 (09:32 +0800)]
MDL-74435 core_user: behat test polish and fixes
Peter Burnett [Mon, 6 Jun 2022 08:43:36 +0000 (18:43 +1000)]
MDL-74435 user: Trim whitespace from user search fields
Jun Pataleta [Thu, 8 Sep 2022 01:05:05 +0000 (09:05 +0800)]
Merge branch 'MDL-74081-master' of https://github.com/call-learning/moodle
Michael Hawkins [Fri, 19 Aug 2022 06:34:09 +0000 (14:34 +0800)]
MDL-68066 output: Apply disable lambda rendering to Mustache renderer
Lars Bonczek [Fri, 19 Aug 2022 06:32:01 +0000 (14:32 +0800)]
MDL-68066 output: Mustache - Add option to disable lambda rendering
This commit is based on an outstanding pull request to the Mustache repo
Laurent David [Thu, 28 Jul 2022 20:14:48 +0000 (16:14 -0400)]
MDL-75227 mod_bigbluebuttonbn: Optimize User logs retrieval
* When loading a course with the Recent Activity block the bigbluebuttonbn_print_recent_activity
takes too much time to load the logs. Using the courseid (index of log table) improves the
time taken by the query.
Laurent David [Thu, 3 Mar 2022 16:54:48 +0000 (17:54 +0100)]
MDL-74081 mod_bigbluebuttonbn: Fix codechecker related issues
* Opening braces should be on the same line
* Unwanted MOODLE_INTERNAL
* Behat edit_instance.feature should use "activity editing" page locator
* Coverage indication
Paul Holden [Mon, 17 Jan 2022 21:15:38 +0000 (21:15 +0000)]
MDL-72012 mod_h5pactivity: respect user access when getting report.
Jun Pataleta [Wed, 7 Sep 2022 12:40:53 +0000 (20:40 +0800)]
MDL-75283 core: Fetch proper column mapping for sort
Calling \core_user\fields::get_sql() incerements a static uniqueid
variable. This should be called only once and not make a separate call
for the sort mapping data as it doing so will result to an incorrect
table alias for the sort mapping data.
Ilya Tregubov [Wed, 7 Sep 2022 12:36:58 +0000 (16:36 +0400)]
Merge branch 'MDL-75555-master' of https://github.com/justusdieckmann/moodle
Ilya Tregubov [Wed, 7 Sep 2022 11:48:56 +0000 (15:48 +0400)]
Merge branch 'MDL-74782-master' of https://github.com/ssj365/moodle
Sara Arjona [Wed, 7 Sep 2022 11:10:05 +0000 (13:10 +0200)]
Merge branch 'MDL-74866-master' of https://github.com/HuongNV13/moodle
Jun Pataleta [Wed, 7 Sep 2022 05:51:42 +0000 (13:51 +0800)]
Merge branch 'MDL-75411-master' of https://github.com/sarjona/moodle
Jun Pataleta [Wed, 7 Sep 2022 05:28:35 +0000 (13:28 +0800)]
Merge branch 'MDL-75252-master' of https://github.com/sarjona/moodle
stevando [Mon, 8 Aug 2022 05:07:37 +0000 (13:07 +0800)]
MDL-75283 admin: Update admin user fetching to use sort helper
Jun Pataleta [Wed, 7 Sep 2022 04:59:42 +0000 (12:59 +0800)]
Merge branch 'MDL-75553-master' of https://github.com/junpataleta/moodle
Jun Pataleta [Tue, 6 Sep 2022 22:12:48 +0000 (06:12 +0800)]
MDL-75553 mod_data: Fix wording of data fields in Behat tests
Huong Nguyen [Thu, 28 Jul 2022 08:11:42 +0000 (15:11 +0700)]
MDL-74866 bennu: Fix parameter parsing
Some parameter values are wrapped by DQUOTE character.
We need to go through and get the actual value inside the quoted string.
Paul Holden [Mon, 8 Aug 2022 20:54:05 +0000 (21:54 +0100)]
MDL-75405 block_html: safer unserialize during old block conversion.
Jun Pataleta [Tue, 6 Sep 2022 22:40:58 +0000 (06:40 +0800)]
Merge branch 'MDL-74749-master' of https://github.com/junpataleta/moodle
Jun Pataleta [Tue, 6 Sep 2022 22:29:00 +0000 (06:29 +0800)]
MDL-74749 mod_bigbluebuttonbn: Run import button check scenario in nonJS
David Mudrák [Fri, 2 Sep 2022 13:47:44 +0000 (15:47 +0200)]
MDL-75553 lang: Fix Behat regressions in scenario files