Paul Holden [Wed, 6 Oct 2021 16:28:35 +0000 (17:28 +0100)]
MDL-72588 reportbuilder: performance improvement to report loader.
Statically cache list of loaded reports during request lifecycle,
this ensures that computationally heavy initialisation routines
in system reports are only executed once (e.g. the access tab).
Paul Holden [Thu, 30 Sep 2021 22:43:49 +0000 (23:43 +0100)]
MDL-72588 reportbuilder: fix dynamic loading of report parameters.
This fixes an issue for system reports that are initialised with
parameters (such as the access report). Previously these parameters
were not preserved, when sorting/paging them via AJAX requests.
We now defer the initialisation of the report until the table
filterset has been set, ensuring all parameters are available.
David Matamoros [Wed, 29 Sep 2021 14:04:19 +0000 (16:04 +0200)]
MDL-72588 reportbuilder: add report access tab.
This tab includes a system report that provides a listing of all
users who can access the report, taking into account all audiences
that have been created for it. Update page of users available
reports to obey audience configuration.
Fix filters JS form to ensure it is only loaded once.
Co-authored-by: Mikel Martín <mikel@moodle.com>
Mikel Martín [Tue, 28 Sep 2021 11:49:37 +0000 (13:49 +0200)]
MDL-72588 reportbuilder: interface for managing report audiences.
Add new tab to editor, allowing user to select from available audience
types in order to grant access to their reports.
Co-authored-by: David Matamoros <davidmc@moodle.com>
David Matamoros [Tue, 28 Sep 2021 16:42:13 +0000 (18:42 +0200)]
MDL-72588 reportbuilder: implement audience helpers and classes.
Create the base audience class, to be extended by all audience types
across the site. Implement types allowing audiences to be created per
user, cohort or system role assignment.
The helper class is used for interrogating report audience instances
and retrieving access lists of those users able to view specific
reports.
Co-authored-by: Paul Holden <paulh@moodle.com>
Mikel Martín [Mon, 27 Sep 2021 13:06:31 +0000 (15:06 +0200)]
MDL-72588 reportbuilder: convert editing interface into a tab.
In preparation for further tabs in this interface, convert the report
editor to use the Dynamic tabs API.
At the same time, update the editor JS and it's modules to add listeners
on `document` instead of the report element itself, which will move in
and out of the current DOM in the future as tabs are switched.
Co-authored-by: Paul Holden <paulh@moodle.com>
David Matamoros [Mon, 27 Sep 2021 10:27:09 +0000 (12:27 +0200)]
MDL-72588 reportbuilder: define schema/models for report audiences.
Víctor Déniz [Tue, 26 Oct 2021 11:36:28 +0000 (12:36 +0100)]
on-demand release 4.0dev+
Víctor Déniz [Tue, 26 Oct 2021 11:36:23 +0000 (12:36 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Ilya Tregubov [Mon, 25 Oct 2021 14:13:54 +0000 (16:13 +0200)]
Merge branch 'MDL-72280' of git://github.com/paulholden/moodle
Ilya Tregubov [Mon, 25 Oct 2021 06:21:55 +0000 (08:21 +0200)]
Merge branch 'master-MDL-70323' of https://github.com/golenkovm/moodle
Andrew Nicols [Mon, 25 Oct 2021 05:18:21 +0000 (13:18 +0800)]
Merge branch 'MDL-71750-master' of https://github.com/NashTechOpenUniversity/moodle
Mikhail Golenkov [Wed, 11 Aug 2021 01:52:49 +0000 (11:52 +1000)]
MDL-70323 core_h5p: Add H5P crossOrigin setting
AMOS bot [Sun, 24 Oct 2021 00:07:34 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Fri, 24 Sep 2021 21:46:45 +0000 (22:46 +0100)]
MDL-72280 course: implement course datasource for custom reporting.
Create new entity for exposing report data on course categories,
joining it to the course entity to provide data for the reportbuilder
editor.
Co-authored-by: Carlos Castillo <carlos.castillo@moodle.com>
Ilya Tregubov [Fri, 22 Oct 2021 10:49:26 +0000 (12:49 +0200)]
on-demand release 4.0dev+
Ilya Tregubov [Fri, 22 Oct 2021 06:46:23 +0000 (08:46 +0200)]
Merge branch 'MDL-69371' of git://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 22 Oct 2021 06:31:38 +0000 (08:31 +0200)]
MDL-69371 behat: Raise privacy exports allowed size
Note that this issue is not the one causing this problem alone
but just one more causing the download limits to be surpassed.
Allowing 1000 more bytes to have some margin, as far as we are
adding lots of new css stuff here and there.
Thong Bui [Thu, 23 Sep 2021 02:04:36 +0000 (09:04 +0700)]
MDL-71750 File upload: Disable submittion when uploading multiple files
Fixed issue "Save" and "Submit and finish" button is not disabled when file uploading in the ticket MDL-71644
Jun Pataleta [Fri, 22 Oct 2021 04:59:38 +0000 (12:59 +0800)]
Merge branch 'MDL-69371-master-fix' of git://github.com/abgreeve/moodle
abgreeve [Fri, 22 Oct 2021 02:32:14 +0000 (10:32 +0800)]
MDL-69371 behat: Update to step definition.
This extends the step to look for the file manager on
admin pages as well which has a slightly different html
signature to look for.
Víctor Déniz [Thu, 21 Oct 2021 22:29:41 +0000 (23:29 +0100)]
Merge branch 'MDL-72607-master_fix_media_vimeo_url_parser' of https://github.com/praxisdigital/moodle
Eloy Lafuente (stronk7) [Thu, 21 Oct 2021 21:21:51 +0000 (23:21 +0200)]
Merge branch 'two_failures' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Thu, 21 Oct 2021 18:45:30 +0000 (20:45 +0200)]
Merge branch 'MDL-72228' of https://github.com/paulholden/moodle
Ferran Recio [Thu, 21 Oct 2021 18:17:38 +0000 (20:17 +0200)]
MDL-71663 core_courseformat: fix merge conflict
Ferran Recio [Thu, 21 Oct 2021 17:13:06 +0000 (19:13 +0200)]
MDL-71663: fix editor in classic
Jun Pataleta [Thu, 21 Oct 2021 15:40:26 +0000 (23:40 +0800)]
Merge branch 'MDL-72878-master' of git://github.com/ilyatregubov/moodle
Eloy Lafuente (stronk7) [Thu, 21 Oct 2021 15:35:51 +0000 (17:35 +0200)]
Merge branch 'MDL-69371-master-fix' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 21 Oct 2021 14:54:48 +0000 (22:54 +0800)]
MDL-69371 output: Render lang_menu only when necessary
Sara Arjona [Thu, 21 Oct 2021 14:38:24 +0000 (16:38 +0200)]
Merge branch 'MDL-72567-master' of git://github.com/lucaboesch/moodle
Ilya Tregubov [Thu, 21 Oct 2021 12:59:20 +0000 (14:59 +0200)]
MDL-72878 behat: Fix behat failing in chrome.
Element is on edge of browser. Changing window size.
Jun Pataleta [Thu, 21 Oct 2021 10:35:04 +0000 (18:35 +0800)]
MDL-69371 output: Allow null return for export_for_single_select()
Jun Pataleta [Thu, 21 Oct 2021 10:14:47 +0000 (18:14 +0800)]
MDL-69371 output: Allow null return for export_for_action_menu()
abgreeve [Thu, 21 Oct 2021 09:16:48 +0000 (17:16 +0800)]
Merge branch 'MDL-69371-master-4' of git://github.com/bmbrands/moodle
Andrew Nicols [Thu, 21 Oct 2021 08:27:02 +0000 (16:27 +0800)]
Merge branch 'MDL-71953-behat' of git://github.com/HuongNV13/moodle
Luca Bösch [Mon, 13 Sep 2021 18:39:36 +0000 (20:39 +0200)]
MDL-72567 courseformat: Have course index support activity name filters
Huong Nguyen [Thu, 21 Oct 2021 07:51:32 +0000 (14:51 +0700)]
MDL-71953 calendar: Fix behat failures
Eloy Lafuente (stronk7) [Thu, 21 Oct 2021 07:25:58 +0000 (09:25 +0200)]
Merge branch 'MDL-72013-master-int' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 21 Oct 2021 06:02:58 +0000 (14:02 +0800)]
Merge branch 'MDL-71953-master' of git://github.com/HuongNV13/moodle
Andrew Nicols [Thu, 14 Oct 2021 08:43:51 +0000 (16:43 +0800)]
MDL-72013 js: Configure eslint-jsdoc plugin
This change adds configuration for the eslint-jsdoc plugin in order to
detect the following errors with jsdoc blocks:
* missing params
* params in incorrect order
* params with no type defined
* properties incorrectly defined
* incorrect use of @package
* incorrect values for @access
In addition, warnings will be thrown where indentation is incorrect.
Andrew Nicols [Thu, 14 Oct 2021 08:43:29 +0000 (16:43 +0800)]
MDL-72013 js: Add eslint-jsdoc plugin
Andrew Nicols [Thu, 14 Oct 2021 08:46:34 +0000 (16:46 +0800)]
MDL-72013 js: Fix jsdocs to meet stricter eslint
Andrew Nicols [Thu, 21 Oct 2021 04:56:23 +0000 (12:56 +0800)]
Merge branch 'MDL-72507-master' of https://github.com/NashTechOpenUniversity/moodle
Huong Nguyen [Sun, 1 Aug 2021 14:18:51 +0000 (21:18 +0700)]
MDL-71953 calendar: Accessibility improvement for manage subscription
- Create new web services for manage subscription (Update calendar subscription)
- Modified delete subscription feature to use Web service.
- Midified update subscription feature to use in-place editbale
- Delete subscription feature now have a confirmation box before processing.
- Fixed some accessibility issues
- Used 'Delete' instead of 'Remove' for deleting subscriptions
Andrew Nicols [Thu, 21 Oct 2021 01:29:19 +0000 (09:29 +0800)]
Merge branch 'MDL-71663-master' of git://github.com/ferranrecio/moodle
Paul Holden [Wed, 13 Oct 2021 20:08:58 +0000 (21:08 +0100)]
MDL-72228 theme_boost: remove class to account for blocks presence.
Course pages use the the drawers layout file, which included a class
to identify whether the page included blocks (`has-blocks`), applying
a width offset to the main region settings menu.
Since
4fa713b0 all course-level blocks are hidden away by default in
a drawer, so the `has-blocks` class had the effect of shifting the
action menu away from the intended right hand side of the page.
Ferran Recio [Wed, 30 Jun 2021 16:06:56 +0000 (18:06 +0200)]
MDL-71663 core_courseformat: add move tool
Ilya Tregubov [Wed, 20 Oct 2021 10:59:29 +0000 (12:59 +0200)]
Merge branch 'MDL-72639' of git://github.com/paulholden/moodle
Ilya Tregubov [Wed, 20 Oct 2021 09:53:15 +0000 (11:53 +0200)]
Merge branch 'MDL-52456-master-whitespace-fix' of git://github.com/ilyatregubov/moodle
Ilya Tregubov [Wed, 20 Oct 2021 09:51:12 +0000 (11:51 +0200)]
MDL-52456 quiz: Fix illegal white space.
Ilya Tregubov [Wed, 20 Oct 2021 09:33:14 +0000 (11:33 +0200)]
Merge branch 'MDL-52456-master' of https://github.com/NashTechOpenUniversity/moodle
Ilya Tregubov [Wed, 20 Oct 2021 07:50:59 +0000 (09:50 +0200)]
Merge branch 'MDL-70795-fix-export-data-size' of git://github.com/ilyatregubov/moodle
Jun Pataleta [Wed, 20 Oct 2021 07:45:22 +0000 (15:45 +0800)]
Merge branch 'MDL-72352-master-v2' of git://github.com/peterRd/moodle
Paul Holden [Wed, 20 Oct 2021 07:20:32 +0000 (08:20 +0100)]
MDL-70795 tool_dataprivacy: increase exported data download size.
Peter Dias [Tue, 31 Aug 2021 02:08:03 +0000 (10:08 +0800)]
MDL-72352 navigation: Unit tests
Peter Dias [Fri, 27 Aug 2021 07:57:33 +0000 (15:57 +0800)]
MDL-72352 navigation: Add filters to moremenu
Adrian Greeve [Thu, 26 Aug 2021 07:55:19 +0000 (15:55 +0800)]
MDL-72352 navigation: Third party settings with children displayed.
This makes sure that we are backwards compatible with plugins that
have extended the course or module settings navigation and have
containers.
Andrew Nicols [Wed, 20 Oct 2021 06:12:40 +0000 (14:12 +0800)]
Merge branch 'MDL-72851-master' of git://github.com/ilyatregubov/moodle
Andrew Nicols [Wed, 20 Oct 2021 01:04:57 +0000 (09:04 +0800)]
Merge branch 'MDL-71211-master-v03' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 21:05:43 +0000 (23:05 +0200)]
Merge branch 'MDL-72596-master' of https://github.com/sammarshallou/moodle
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 20:17:04 +0000 (22:17 +0200)]
Merge branch 'MDL-72849-master' of https://github.com/sammarshallou/moodle
sam marshall [Thu, 16 Sep 2021 15:26:47 +0000 (16:26 +0100)]
MDL-72596 core_cache: Track cache I/O size in perfdebug
For cache types which mean this information can be obtained without a
significant performance cost (i.e. just by calling strlen and not
having to serialize something that wasn't serialized already),
this change calculates the size of data read from or written to cache
in each request and includes it in the perfdebug table at bottom of
output (when that is turned on).
This supports the following cache types:
* File store
* Redis (only if caching is enabled)
Ilya Tregubov [Tue, 19 Oct 2021 14:40:42 +0000 (16:40 +0200)]
MDL-72851 core: Bump $lastmajordbchanges to trigger upgrade immediately.
Fixing regression of MDL-52206.
Ilya Tregubov [Tue, 19 Oct 2021 13:56:57 +0000 (15:56 +0200)]
Merge branch 'MDL-70795' of git://github.com/paulholden/moodle
Thong Bui [Mon, 12 Jul 2021 07:22:10 +0000 (14:22 +0700)]
MDL-52456 Quiz: notification message for students.
Notification message for students after questions have been manually graded.
David Matamoros [Wed, 25 Aug 2021 10:57:55 +0000 (12:57 +0200)]
MDL-70795 reportbuilder: allow user to view custom reports.
Reports can be viewed via two methods. Non-editing users can
access them via their report listing page, and report editors
can switch between editing and preview mode while working on
their reports.
Clean up remaining string definitions.
Co-authored-by: Mikel Martín <mikel@moodle.com>
Paul Holden [Tue, 10 Aug 2021 16:44:31 +0000 (17:44 +0100)]
MDL-70795 reportbuilder: editor elements to set column aggregation.
Aggregation of report columns allows the report editor to perform
common types of data aggregation (concatenation, sum, count, etc)
on given columns.
David Matamoros [Wed, 15 Sep 2021 15:10:00 +0000 (15:10 +0000)]
MDL-70795 reportbuilder: report configuration for default sorting.
Co-authored-By: Mikel Martín <mikel@moodle.com>
Mikel Martín [Tue, 21 Sep 2021 15:11:00 +0000 (17:11 +0200)]
MDL-70795 reportbuilder: theme updates for custom report editor.
Includes nice interactions for element drag & drop, consistent
styling for templates and tidy up of element alignment/spacing.
David Matamoros [Fri, 13 Aug 2021 16:41:53 +0000 (16:41 +0000)]
MDL-70795 reportbuilder: custom report filters editor.
Implement module for filters editing, allowing the report
editor to define which filters are available when users
are viewing the report.
These filters allow those users viewing the report to further
limit the data being displayed (after conditions have been
applied), by selecting their own values for each filter.
Co-authored-by: Paul Holden <paulh@moodle.com>
Paul Holden [Tue, 14 Sep 2021 10:12:25 +0000 (10:12 +0000)]
MDL-70795 reportbuilder: custom report condition editor.
Report conditions allow report creators to limit which data
is displayed when the report is viewed. Users viewing the
report cannot override these condition values.
Paul Holden [Thu, 22 Jul 2021 12:32:55 +0000 (13:32 +0100)]
MDL-70795 reportbuilder: beginnings of the report editor.
Implement UI elements for editing columns of a report, taking their
definitions from the selected datasource.
Co-authored-By: David Matamoros <davidmc@moodle.com>
Co-authored-By: Mikel Martín <mikel@moodle.com>
David Matamoros [Tue, 6 Jul 2021 16:10:30 +0000 (16:10 +0000)]
MDL-70795 reportbuilder: add interface for creating reports.
Implement elements for creating/editing reports, along with
new system report for listing and accompanying JS modules for
user interaction.
Create "Users" datasource as proof-of-concept.
Co-authored-By: Paul Holden <paulh@moodle.com>
Paul Holden [Mon, 5 Jul 2021 10:51:20 +0000 (11:51 +0100)]
MDL-70795 reportbuilder: define updated schema for custom reports.
Define new filter/column models, and updated database schema to
match.
sam marshall [Tue, 19 Oct 2021 12:47:20 +0000 (13:47 +0100)]
MDL-72849 tool_behat: Use of xpath name() not compatible with Firefox
The xpath name() function returns upper-case e.g. 'IMG' in Firefox and
lower-case e.g. 'img' in Chrome.
Ilya Tregubov [Tue, 19 Oct 2021 12:44:35 +0000 (14:44 +0200)]
Merge branch 'MDL-71270-master' of git://github.com/mickhawkins/moodle
Bas Brands [Mon, 18 Oct 2021 09:01:28 +0000 (11:01 +0200)]
MDL-69371 core_renderer: Move unit test for language renderable
abgreeve [Thu, 14 Oct 2021 01:14:42 +0000 (09:14 +0800)]
MDL-69371 core_renderer: New core language renderable.
abgreeve [Wed, 13 Oct 2021 03:02:27 +0000 (11:02 +0800)]
MDL-69371 core_login: simplification of behat steps
Bas Brands [Wed, 13 Oct 2021 07:35:58 +0000 (09:35 +0200)]
MDL-69371 theme_boost: allow configuring a login background image
Bas Brands [Tue, 13 Apr 2021 10:01:28 +0000 (12:01 +0200)]
MDL-69371 theme_boost: redesign the moodle login page
Ilya Tregubov [Mon, 13 Sep 2021 08:15:56 +0000 (10:15 +0200)]
MDL-71211 core_course: Keep the status of course index.
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 10:52:08 +0000 (12:52 +0200)]
on-demand release 4.0dev+
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 10:52:08 +0000 (12:52 +0200)]
NOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 10:52:03 +0000 (12:52 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Thong Bui [Fri, 24 Sep 2021 02:10:58 +0000 (09:10 +0700)]
MDL-72507 Quiz: Quiz auto-save does not detect uploaded files
Eloy Lafuente (stronk7) [Tue, 19 Oct 2021 08:21:54 +0000 (10:21 +0200)]
Merge branch 'MDL-60917-Master' of https://github.com/tuanngocnguyen/moodle
Andrew Nicols [Tue, 19 Oct 2021 03:23:06 +0000 (11:23 +0800)]
Merge branch 'MDL-71571-master' of https://github.com/kabalin/moodle
Nathan Nguyen [Tue, 19 Oct 2021 03:03:55 +0000 (14:03 +1100)]
MDL-60917 core_search: fix unit test
Andrew Nicols [Tue, 19 Oct 2021 03:19:54 +0000 (11:19 +0800)]
MDL-71785 mod_quiz: Correct string as per reviewer feedback
Andrew Nicols [Tue, 19 Oct 2021 03:19:06 +0000 (11:19 +0800)]
Merge branch 'MDL-71785_master' of https://github.com/StudiUM/moodle
Jun Pataleta [Tue, 19 Oct 2021 02:59:51 +0000 (10:59 +0800)]
Merge branch 'MDL-72825-master' of git://github.com/HuongNV13/moodle
Andrew Nicols [Tue, 19 Oct 2021 02:05:37 +0000 (10:05 +0800)]
Merge branch 'MDL-72725-master' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Mon, 18 Oct 2021 18:31:19 +0000 (20:31 +0200)]
Merge branch 'MDL-60917-Master' of https://github.com/tuanngocnguyen/moodle
Sara Arjona [Mon, 18 Oct 2021 15:38:27 +0000 (17:38 +0200)]
Merge branch 'MDL-72590-master' of git://github.com/lucaboesch/moodle
Luca Bösch [Wed, 15 Sep 2021 18:37:03 +0000 (20:37 +0200)]
MDL-72590 enrol: Course in success message after unenroll passes filter
Sara Arjona [Mon, 18 Oct 2021 10:59:37 +0000 (12:59 +0200)]
Merge branch 'MDL-72064-master' of https://github.com/NashTechOpenUniversity/moodle
Eloy Lafuente (stronk7) [Mon, 18 Oct 2021 09:43:09 +0000 (11:43 +0200)]
Merge branch 'MDL-72720-master-fix' of github.com:sarjona/moodle
Sara Arjona [Mon, 18 Oct 2021 09:30:49 +0000 (11:30 +0200)]
MDL-72720 logstore: Display config changes as expected
Michael Hawkins [Mon, 18 Oct 2021 09:12:44 +0000 (17:12 +0800)]
MDL-71270 core: Updated security.txt expiry