Paul Holden [Tue, 10 Aug 2021 18:17:31 +0000 (19:17 +0100)]
MDL-72309 course: make category a required field in forms.
Course category fields were changed en masse from simple select
elements to autocompletes in
93d72205, but weren't defined as
required fields. This could lead to exceptions and/or unexpected
behaviour if their values were cleared prior to form submission.
Eloy Lafuente (stronk7) [Sat, 2 Oct 2021 20:05:06 +0000 (22:05 +0200)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Sat, 2 Oct 2021 20:05:00 +0000 (22:05 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Sat, 2 Oct 2021 06:16:55 +0000 (08:16 +0200)]
Merge branch 'MDL-72714' of git://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 1 Oct 2021 20:40:10 +0000 (22:40 +0200)]
MDL-72714 behat: Make the window larger earlier
The step that causes the problem is:
And I navigate to "Badges > Add a new badge" in current page administration
(because "Add a new badge" is exactly on the edge (bottom) of the window)
So we need to make the window large before it, not after it, or the
"Add a new badge" link won't be ever clicked.
Víctor Déniz [Fri, 1 Oct 2021 18:10:41 +0000 (19:10 +0100)]
Merge branch 'MDL-72329' of https://github.com/stronk7/moodle
Eloy Lafuente (stronk7) [Fri, 1 Oct 2021 14:58:45 +0000 (16:58 +0200)]
MDL-72329 phpunit: Avoid === on floats and raw reserved word
In general it's a bad idea to compare floats with ===,
because depending of different systems precision, can
come to mismatches after certain decimal position.
So we replace them by:
- assetIsFloat() : to verify the type.
- assertEqualsWithDelta() : to compare values with some delta allowed.
Also, "raw" is Oracle reserved word, so renaming to "someraw" in tests.
Sujith Haridasan [Fri, 1 Oct 2021 04:43:24 +0000 (10:13 +0530)]
MDL-72396 core: Fix the primary active tab for my/index.php
Fix the primary active tab for my/index.php
Víctor Déniz [Fri, 1 Oct 2021 10:10:59 +0000 (11:10 +0100)]
Merge branch 'MDL-72714-master' of git://github.com/ilyatregubov/moodle
Andrew Nicols [Fri, 1 Oct 2021 09:00:27 +0000 (17:00 +0800)]
Merge branch 'MDL-72329' of https://github.com/stronk7/moodle
Ilya Tregubov [Fri, 1 Oct 2021 08:44:52 +0000 (10:44 +0200)]
Merge branch 'MDL-71610-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Fri, 1 Oct 2021 08:41:31 +0000 (10:41 +0200)]
MDL-72329 phpunit: Fix some tests
- XMLDB_TYPE_FLOAT definition was incorrect, meaning no decimals for
some DBs.
- Avoid using reserved words in column names.
Andrew Nicols [Fri, 1 Oct 2021 07:56:36 +0000 (15:56 +0800)]
MDL-71610 behat: Add custom steps for edit mode checks
Andrew Nicols [Fri, 1 Oct 2021 07:15:40 +0000 (15:15 +0800)]
MDL-71610 gradereport_grader: Specify the pagelayout for grader report
Ilya Tregubov [Thu, 30 Sep 2021 13:52:12 +0000 (15:52 +0200)]
MDL-72714 behat: Fix Behat failures for chrome 94.
Jun Pataleta [Fri, 1 Oct 2021 03:43:25 +0000 (11:43 +0800)]
Merge branch 'MDL-72449-master' of git://github.com/andrewnicols/moodle
abgreeve [Fri, 1 Oct 2021 03:21:40 +0000 (11:21 +0800)]
Merge branch 'MDL-69682' of git://github.com/paulholden/moodle
Andrew Nicols [Fri, 1 Oct 2021 03:02:28 +0000 (11:02 +0800)]
Merge branch 'MDL-72329-master' of https://github.com/dravek/moodle
Andrew Nicols [Fri, 1 Oct 2021 02:26:56 +0000 (10:26 +0800)]
Merge branch 'MDL-71347' of https://github.com/paulholden/moodle
Andrew Nicols [Fri, 1 Oct 2021 02:21:30 +0000 (10:21 +0800)]
Merge branch 'MDL-72673-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Fri, 1 Oct 2021 02:14:51 +0000 (10:14 +0800)]
Merge branch 'MDL-72544' of git://github.com/paulholden/moodle
Andrew Nicols [Fri, 1 Oct 2021 01:43:39 +0000 (09:43 +0800)]
Merge branch 'MDL-70862' of https://github.com/marcusboon/moodle
Eloy Lafuente (stronk7) [Thu, 30 Sep 2021 21:19:06 +0000 (23:19 +0200)]
Merge branch 'MDL-72484' of git://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 30 Sep 2021 21:16:21 +0000 (23:16 +0200)]
Merge branch 'MDL-72587-master' of git://github.com/dpalou/moodle
Eloy Lafuente (stronk7) [Thu, 30 Sep 2021 18:12:39 +0000 (20:12 +0200)]
Merge branch 'MDL-72396-master' of https://github.com/sharidas/moodle
Víctor Déniz [Thu, 30 Sep 2021 14:40:25 +0000 (15:40 +0100)]
Merge branch 'MDL-72496-master_assert_tag' of https://github.com/call-learning/moodle
Laurent David [Thu, 23 Sep 2021 15:39:34 +0000 (17:39 +0200)]
MDL-72496 question tests: fix assertTag if tag not found
* The basic_test::assertTag method will issue a warning as $tag is not
found, failing the PHP Unit test that uses this method.
* Add tests to check that assertTag is working
abgreeve [Thu, 30 Sep 2021 04:50:45 +0000 (12:50 +0800)]
Merge branch 'MDL-71610-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 30 Sep 2021 02:42:50 +0000 (10:42 +0800)]
MDL-71610 theme_classic: Check whether editing mode is enabled in behat
Andrew Nicols [Thu, 30 Sep 2021 04:17:06 +0000 (12:17 +0800)]
Merge branch 'MDL-72545' of https://github.com/paulholden/moodle
abgreeve [Thu, 30 Sep 2021 01:57:35 +0000 (09:57 +0800)]
Merge branch 'MDL-72275-master-2' of git://github.com/mickhawkins/moodle
Andrew Nicols [Thu, 30 Sep 2021 01:52:56 +0000 (09:52 +0800)]
Merge branch 'MDL-71727-master-v03' of git://github.com/ferranrecio/moodle
AMOS bot [Thu, 30 Sep 2021 00:07:32 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Wed, 29 Sep 2021 21:31:22 +0000 (23:31 +0200)]
Merge branch 'MDL-72462' of https://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Wed, 29 Sep 2021 21:27:15 +0000 (23:27 +0200)]
Merge branch 'MDL-71970-master' of git://github.com/sarjona/moodle
Ilya Tregubov [Wed, 29 Sep 2021 13:40:39 +0000 (15:40 +0200)]
Merge branch 'MDL-71610-master' of git://github.com/bmbrands/moodle
Ferran Recio [Tue, 22 Jun 2021 13:39:16 +0000 (15:39 +0200)]
MDL-71727 course: sync dragged elements
Two new mutations are added to indicate that a section
or a cm is being dragged. The logic related to refresh
a section or a cm has been moved to components to
simplify the code.
Ferran Recio [Wed, 25 Aug 2021 11:39:02 +0000 (13:39 +0200)]
MDL-71828 courseformat: course index section link toggler
Bas Brands [Wed, 4 Aug 2021 08:14:56 +0000 (10:14 +0200)]
MDL-71610 core_behat: access site admin manage tags link
Bas Brands [Tue, 6 Jul 2021 10:02:19 +0000 (12:02 +0200)]
MDL-71610 core_behat: use new edit mode step in feature files
Bas Brands [Tue, 6 Jul 2021 09:27:22 +0000 (11:27 +0200)]
MDL-71610 core_behat: update edit mode steps
Bas Brands [Tue, 6 Jul 2021 08:27:24 +0000 (10:27 +0200)]
MDL-71610 theme_boost: switch to standard editing mode for gradebook
the gradebook need to use the standard $USER->editing to check if editing mode is turned on
Bas Brands [Tue, 6 Jul 2021 08:19:09 +0000 (10:19 +0200)]
MDL-71610 theme_boost: remove edit button from Boost
Bas Brands [Tue, 6 Jul 2021 08:01:05 +0000 (10:01 +0200)]
MDL-71610 theme_boost: add a edit mode switch
Ilya Tregubov [Tue, 28 Sep 2021 13:51:58 +0000 (15:51 +0200)]
Merge branch 'MDL-72675' of git://github.com/paulholden/moodle
Shamim Rezaie [Tue, 28 Sep 2021 10:15:06 +0000 (20:15 +1000)]
Merge branch 'MDL-72060-master' of git://github.com/lameze/moodle
Adrian Perez [Thu, 1 Jul 2021 09:03:56 +0000 (11:03 +0200)]
MDL-72060 mod_lti: fix comparison if user is gradable
Dani Palou [Thu, 23 Sep 2021 15:00:33 +0000 (17:00 +0200)]
MDL-72587 message: Support getting both read and unread messages
Andrew Nicols [Tue, 28 Sep 2021 07:17:23 +0000 (15:17 +0800)]
Merge branch 'MDL-67686' of git://github.com/paulholden/moodle
Ilya Tregubov [Tue, 28 Sep 2021 06:03:14 +0000 (08:03 +0200)]
Merge branch 'MDL-72643-master' of git://github.com/sammarshallou/moodle
Andrew Nicols [Tue, 28 Sep 2021 05:36:11 +0000 (13:36 +0800)]
Merge branch 'MDL-72031-master' of https://github.com/NashTechOpenUniversity/moodle
AMOS bot [Tue, 28 Sep 2021 00:07:50 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Mon, 27 Sep 2021 21:33:47 +0000 (23:33 +0200)]
Merge branch 'MDL-72658-master-welcometosite' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Mon, 27 Sep 2021 21:19:34 +0000 (23:19 +0200)]
Merge branch 'MDL-72328-master' of https://github.com/sammarshallou/moodle
Paul Holden [Thu, 2 Sep 2021 07:55:00 +0000 (08:55 +0100)]
MDL-72462 forms: style checkbox/radio field labels consistently.
Fixes small regression from
942dc9de that moved indentation of form
fields to the label node, but only for those labels with specific
class.
Paul Holden [Fri, 3 Sep 2021 13:46:40 +0000 (14:46 +0100)]
MDL-72484 report_eventlist: looser check for event 'other' docs.
Ilya Tregubov [Mon, 27 Sep 2021 16:34:12 +0000 (18:34 +0200)]
Merge branch 'MDL-71943-master' of git://github.com/dravek/moodle
David Matamoros [Tue, 31 Aug 2021 13:06:31 +0000 (15:06 +0200)]
MDL-71943 core: Dynamic (AJAX) tabs in Moodle LMS
sam marshall [Wed, 22 Sep 2021 10:42:33 +0000 (11:42 +0100)]
MDL-72643 core: Improve display_size
Allows display_size to use a fixed unit for easy comparison of
multiple results, and fixed decimal places for the same reason.
Improves behaviour by using consistent decimal places and a
consistent space before the unit (the previous one only has a space
before 'bytes', not before 'KB').
Of existing uses, all the ones that displayed a 'maxbytes' type
configuration setting (which are likely to have an 'exact' size
and would be better shown as 512 KB rather than 512.0 KB) have been
changed to use 0 decimal places, to preserve previous behaviour.
All the uses which were showing an actual file or memory size have
been left as default (1 decimal place).
Ilya Tregubov [Mon, 27 Sep 2021 09:45:22 +0000 (11:45 +0200)]
Merge branch 'MDL-72335-master' of git://github.com/cescobedo/moodle
Sara Arjona [Tue, 7 Sep 2021 15:15:55 +0000 (17:15 +0200)]
MDL-71970 h5plib_v124: Replace references to new Moodle\H5Pxxx namespace
The joubel/core and joubel/editor libraries have been moved to Moodle
namespace.
This commit adds the new namespace to the places where these classes
are used.
Besides, a couple of minor changes have been done to replace the _test.php
classname and remove some unnecessary defined('MOODLE_INTERNAL').
Sara Arjona [Tue, 7 Sep 2021 15:09:16 +0000 (17:09 +0200)]
MDL-71970 h5plib_v124: Add namespace to H5P editor library
The joubel/editor is a third-party library. A namespace has been added to
avoid collision with other plugins using it (such as mod_hvp).
That way, they will be able to have a different version without
side effects.
Sara Arjona [Tue, 7 Sep 2021 15:04:52 +0000 (17:04 +0200)]
MDL-71970 h5plib_v124: Add namespace to H5P core library
The joubel/core is a third-party library. A namespace has been added to
avoid collision with other plugins using it (such as mod_hvp).
That way, they will be able to have a different version without
side effects.
cescobedo [Thu, 2 Sep 2021 15:45:18 +0000 (17:45 +0200)]
MDL-72335 tool_health: Remove tool_health from core
Paul Holden [Fri, 24 Sep 2021 11:35:03 +0000 (12:35 +0100)]
MDL-72675 repository_picasa: remove plugin config after uninstall.
It was missed as part of the original plugin uninstallation change
in
128ebcc4.
Jun Pataleta [Fri, 24 Sep 2021 08:36:58 +0000 (16:36 +0800)]
MDL-72673 mod_glossary: Generate unique ID for Keywords select element
Paul Holden [Tue, 8 Jun 2021 16:09:53 +0000 (17:09 +0100)]
MDL-69682 theme_boost: remove minimum height of tables.
The change that introduced this property (
a3124b15) is no longer
required, and it caused visual glitches on tables containing a
single row.
Paul Holden [Fri, 10 Sep 2021 07:06:30 +0000 (08:06 +0100)]
MDL-72545 reportbuilder: reload form fragment after filter reset.
Instead of performing a page reload after resetting report filters,
we can use the fragment API to re-render the form after the user
presses the reset button.
Paul Holden [Fri, 10 Sep 2021 07:06:26 +0000 (08:06 +0100)]
MDL-72544 output: set default core/toast message type to information.
Update existing code to set type to warning as appropriate.
Paul Holden [Tue, 31 Aug 2021 16:17:55 +0000 (17:17 +0100)]
MDL-67686 task: add duration filter to task logs report.
Paul Holden [Wed, 1 Sep 2021 07:38:14 +0000 (08:38 +0100)]
MDL-67686 reportbuilder: new duration filter type.
This report filter can be used for filtering reports by given
duration, via selection of time value and unit (seconds, minutes,
hours, etc).
Ilya Tregubov [Fri, 24 Sep 2021 06:49:32 +0000 (08:49 +0200)]
Merge branch 'MDL-71828-master' of git://github.com/ferranrecio/moodle
David Matamoros [Tue, 14 Sep 2021 13:44:12 +0000 (15:44 +0200)]
MDL-72329 tool_dataprivacy: Fix type comparisons in unit tests
David Matamoros [Tue, 14 Sep 2021 12:25:07 +0000 (14:25 +0200)]
MDL-72329 competency: Fix contextid comparison
David Matamoros [Mon, 13 Sep 2021 08:24:00 +0000 (10:24 +0200)]
MDL-72329 reportbuilder: Remove custom persistent getter
David Matamoros [Fri, 10 Sep 2021 14:13:58 +0000 (16:13 +0200)]
MDL-72329 core: Persistent method get needs to return correct type
Michael Hawkins [Fri, 17 Sep 2021 08:45:03 +0000 (16:45 +0800)]
MDL-72275 timeline: Add default offset to template
This value was being passed in the template, but the template
had 0 hardcoded instead of injecting the context value. With the other
bug fixes in this issue correctly loading the "All" view properly on
page load, this uncovered that at load time, the course view would not
load overdue items, which also meant a behat test was failing.
Michael Hawkins [Tue, 7 Sep 2021 05:52:56 +0000 (13:52 +0800)]
MDL-72275 timeline: Make time dropdown options display consistently
The 6 month option was highlighted on load if previously selected,
which was not the case for any other options. This has been removed
so it behaves consistently.
Michael Hawkins [Wed, 18 Aug 2021 19:01:37 +0000 (03:01 +0800)]
MDL-72275 timeline: Fixed non-loading issue in dates sort
Incorrect setting/getting of the "seen" data attribute resulted in no
information being fetched when switching from course view back to dates
view.
Michael Hawkins [Wed, 18 Aug 2021 18:58:45 +0000 (02:58 +0800)]
MDL-72275 timeline: Display "all" time on page load fix
When the timeframe filter was set to "all" when the timeline
block was initially loaded, an incorrect value rendered into
the template meant the timeframe limit was set to 0 (which will
return no results) instead of setting no limit (which would fetch all
action events, as intended).
Marcus Boon [Thu, 4 Feb 2021 08:16:30 +0000 (18:16 +1000)]
MDL-70862 gradebook: Add callback so that we can add tabs in gradebook
AMOS bot [Fri, 24 Sep 2021 00:07:53 +0000 (00:07 +0000)]
Automatically generated installer lang files
David Mudrák [Thu, 23 Sep 2021 18:57:22 +0000 (20:57 +0200)]
MDL-72658 lang: Let welcome message use other than just firstname
The patch allows for strings welcomeback and welcometosite to be
customised and use other user names than just the firstname.
Supported are placeholder properties matching all known name fields:
firstnamephonetic, lastnamephonetic, middlename, alternatename,
firstname and lastname. Special values fullname and alternativefullname
are supported, too.
By default, the firstname is kept for compatibility with the original
feature design.
Ilya Tregubov [Thu, 23 Sep 2021 16:21:49 +0000 (18:21 +0200)]
weekly release 4.0dev
Ilya Tregubov [Thu, 23 Sep 2021 16:21:47 +0000 (18:21 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Thu, 23 Sep 2021 08:38:58 +0000 (10:38 +0200)]
Merge branch 'MDL-71964-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 23 Sep 2021 06:10:05 +0000 (14:10 +0800)]
MDL-71964 user: Fix preference lang string key
* Plus use example domain for user email in the Behat test
Jun Pataleta [Thu, 23 Sep 2021 04:23:46 +0000 (12:23 +0800)]
Merge branch 'MDL-72426-master' of git://github.com/lameze/moodle
Jun Pataleta [Thu, 23 Sep 2021 03:32:27 +0000 (11:32 +0800)]
Merge branch 'MDL-71964-master' of git://github.com/junpataleta/moodle
Dongsheng Cai [Sun, 5 Sep 2021 13:08:30 +0000 (23:08 +1000)]
MDL-71964 dashboard: add welcome message for all users
AMOS bot [Thu, 23 Sep 2021 00:07:48 +0000 (00:07 +0000)]
Automatically generated installer lang files
Ferran Recio [Wed, 25 Aug 2021 11:39:02 +0000 (13:39 +0200)]
MDL-71828 courseformat: course index section link toggler
Eloy Lafuente (stronk7) [Wed, 22 Sep 2021 18:00:18 +0000 (20:00 +0200)]
Merge branch 'MDL-72110-master-v3' of https://github.com/sharidas/moodle
Ilya Tregubov [Wed, 22 Sep 2021 17:22:59 +0000 (19:22 +0200)]
Merge branch 'MDL-66549-master' of git://github.com/ilyatregubov/moodle
Jun Pataleta [Wed, 22 Sep 2021 13:17:32 +0000 (21:17 +0800)]
Merge branch 'MDL-71664-master-v04' of git://github.com/ferranrecio/moodle
arjun-kallapur [Tue, 3 Sep 2019 18:50:28 +0000 (11:50 -0700)]
MDL-66549 grades: Double arrow sort order should be ascending first
Ilya Tregubov [Wed, 22 Sep 2021 11:34:28 +0000 (13:34 +0200)]
Merge branch 'MDL-72042-master' of git://github.com/sarjona/moodle
Ferran Recio [Tue, 22 Jun 2021 11:27:59 +0000 (13:27 +0200)]
MDL-71664 course: add browser native drag and drop
Eloy Lafuente (stronk7) [Wed, 22 Sep 2021 08:48:07 +0000 (10:48 +0200)]
Merge branch 'MDL-72593-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 22 Sep 2021 06:44:17 +0000 (14:44 +0800)]
Merge branch 'MDL-71037-master-8' of git://github.com/ilyatregubov/moodle