Paul Holden [Wed, 28 Dec 2022 10:08:10 +0000 (10:08 +0000)]
MDL-76760 tool_behat: defer library loading until service execution.
Ensures that API documentation can be generated without requiring
the presence of the `vendor/` directory.
Ilya Tregubov [Thu, 22 Dec 2022 12:16:24 +0000 (19:16 +0700)]
weekly release 4.2dev
Ilya Tregubov [Thu, 22 Dec 2022 12:16:22 +0000 (19:16 +0700)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Ilya Tregubov [Thu, 22 Dec 2022 03:09:10 +0000 (10:09 +0700)]
Merge branch 'MDL-76667' of https://github.com/paulholden/moodle
Ilya Tregubov [Thu, 22 Dec 2022 03:01:42 +0000 (10:01 +0700)]
Merge branch 'MDL-74609-patch' of https://github.com/ilyatregubov/moodle
Paul Holden [Wed, 21 Dec 2022 14:17:50 +0000 (14:17 +0000)]
Merge branch 'MDL-75965-master' of https://github.com/HuongNV13/moodle
Tim Hunt [Wed, 21 Dec 2022 20:42:45 +0000 (20:42 +0000)]
MDL-74609 Quiz: question number customisation - fixup Behat
Andrew Nicols [Wed, 21 Dec 2022 13:11:04 +0000 (21:11 +0800)]
MDL-75105 tool_behat: Coding style fixes
Andrew Nicols [Wed, 21 Dec 2022 12:57:40 +0000 (20:57 +0800)]
Merge branch 'MDL-75105_master' of https://github.com/marxjohnson/moodle
Andrew Nicols [Wed, 21 Dec 2022 12:54:31 +0000 (20:54 +0800)]
Merge branch 'MDL-74609' of https://github.com/mkassaei/moodle
Paul Holden [Wed, 21 Dec 2022 09:56:16 +0000 (09:56 +0000)]
Merge branch 'MDL-75667-master' of https://github.com/farhan6318/moodle
Paul Holden [Wed, 21 Dec 2022 09:49:55 +0000 (09:49 +0000)]
Merge branch 'MDL-75914-master' of https://github.com/meirzamoodle/moodle
AMOS bot [Thu, 22 Dec 2022 00:07:46 +0000 (00:07 +0000)]
Automatically generated installer lang files
Mahmoud Kassaei [Mon, 5 Dec 2022 11:00:23 +0000 (11:00 +0000)]
MDL-74609 Quiz: allow the displayed question numbers to be customised
Meirza [Thu, 15 Dec 2022 05:13:24 +0000 (12:13 +0700)]
MDL-75914 webservice: Added fake URL to avoid debugging output.
Webservice doesn't need to set the page URL. Hence,
any function that requires a page URL will raise debugging output.
The patch fixes it by adding a fake URL for the webservice.
The patch also removed assertDebuggingCalled because it is no longer needed.
Mark Johnson [Thu, 30 Jun 2022 14:34:29 +0000 (15:34 +0100)]
MDL-75105 tool_behat: List available data generators
This will find all data generators that can be used in behat via the
'the following "something" exist:' step, and display them in a select
list on the step definitions page.
When a generator is selected, it will fetch the required fields for that
generator and display them on the page.
Huong Nguyen [Thu, 8 Dec 2022 03:09:11 +0000 (10:09 +0700)]
MDL-75965 question_multichoice: Misalignment of feedback icons
Ilya Tregubov [Wed, 21 Dec 2022 02:49:43 +0000 (09:49 +0700)]
Merge branch 'MDL-76727-master' of https://github.com/andrewnicols/moodle
Farhan Karmali [Mon, 19 Dec 2022 05:14:38 +0000 (10:44 +0530)]
MDL-75667 admin: Fix cross db query issue for blocks
Paul Holden [Tue, 20 Dec 2022 10:27:32 +0000 (10:27 +0000)]
Merge branch 'MDL-75279' of https://github.com/spvickers/moodle
Paul Holden [Tue, 20 Dec 2022 09:42:32 +0000 (09:42 +0000)]
Merge branch 'MDL-76138-master' of https://github.com/Chocolate-lightning/moodle
Mihail Geshoski [Thu, 17 Nov 2022 06:47:51 +0000 (14:47 +0800)]
MDL-76138 gradereport_grader: Create basic action bar
Andrew Nicols [Tue, 20 Dec 2022 01:25:40 +0000 (09:25 +0800)]
MDL-76727 core: Allow phpcs configuration to be overridden locally
This change reduces the priority of the shipped phpcs configuration to
allow for local overrides.
This is beneficial in several situations:
- when users wish to apply stricter or additional standards
- when the integration team wishes to trial new rules
Stephen Vickers [Wed, 20 Jul 2022 18:36:38 +0000 (19:36 +0100)]
MDL-75279 mod_lti: Add username to NRPS response
Paul Holden [Mon, 19 Dec 2022 10:23:03 +0000 (10:23 +0000)]
Merge branch 'MDL-72906' of https://github.com/tdjones/moodle
Ilya Tregubov [Mon, 19 Dec 2022 02:43:38 +0000 (09:43 +0700)]
Merge branch 'MDL-74779-master' of https://github.com/ssj365/moodle
AMOS bot [Fri, 16 Dec 2022 21:03:08 +0000 (21:03 +0000)]
Automatically generated installer lang files
Paul Holden [Fri, 16 Dec 2022 13:44:56 +0000 (13:44 +0000)]
Merge branch 'MDL-75667-master' of https://github.com/farhan6318/moodle
Farhan Karmali [Wed, 21 Sep 2022 08:38:56 +0000 (14:08 +0530)]
MDL-75667 admin: Avoid DB calls within loops on admin/blocks.php
Paul Holden [Fri, 16 Dec 2022 09:53:40 +0000 (09:53 +0000)]
Merge branch 'MDL-76026' of https://github.com/AnupamaSarjoshi/moodle
Andrew Nicols [Fri, 16 Dec 2022 01:05:48 +0000 (09:05 +0800)]
weekly release 4.2dev
Andrew Nicols [Thu, 15 Dec 2022 06:45:41 +0000 (14:45 +0800)]
MDL-74923 quiz: Remove erroneous merge conflict line
Andrew Nicols [Wed, 14 Dec 2022 23:35:46 +0000 (07:35 +0800)]
Merge branch 'MDL-74923' of https://github.com/timhunt/moodle
Tim Hunt [Fri, 9 Dec 2022 23:58:41 +0000 (23:58 +0000)]
MDL-74923 quiz: tidy the report base classes
Tim Hunt [Fri, 9 Dec 2022 12:42:57 +0000 (12:42 +0000)]
MDL-74923 quiz: move report base classes to local folder
Sara Arjona [Wed, 14 Dec 2022 17:34:44 +0000 (18:34 +0100)]
Merge branch 'MDL-76674' of https://github.com/stronk7/moodle
Sara Arjona [Wed, 14 Dec 2022 17:12:50 +0000 (18:12 +0100)]
Merge branch 'MDL-75805' of https://github.com/paulholden/moodle
Sara Arjona [Wed, 14 Dec 2022 16:51:44 +0000 (17:51 +0100)]
Merge branch 'MDL-71096' of https://github.com/stronk7/moodle
Sara Arjona [Wed, 14 Dec 2022 16:29:13 +0000 (17:29 +0100)]
Merge branch 'MDL-75943' of https://github.com/roland04/moodle
Eloy Lafuente (stronk7) [Wed, 14 Dec 2022 14:49:23 +0000 (15:49 +0100)]
MDL-76674 core_lang: Add string for new America/Ciudad_Juarez
Paul Holden [Wed, 14 Dec 2022 13:22:01 +0000 (13:22 +0000)]
Merge branch 'MDL-76666' of https://github.com/stronk7/moodle
Mikel Martín [Thu, 20 Oct 2022 10:28:49 +0000 (12:28 +0200)]
MDL-75943 reportbuilder: Refactor scss to support force card/table view
Mikel Martín [Thu, 20 Oct 2022 10:27:27 +0000 (12:27 +0200)]
MDL-75943 reportbuilder: Add custom attributes to reports
Eloy Lafuente (stronk7) [Tue, 13 Dec 2022 22:26:01 +0000 (23:26 +0100)]
MDL-76666 local_langimport: Better handling of long locales
Under some linux versions, and depending of the configured
locale categories, it's possible to get a current locally
which length > 255 when calling to setlocale(LC_ALL, 0).
Later, if that long locale is tried to be restored, there
is a "setlocale(): Specified locale name is too long" warning
error.
When that happens we need to split the long locale into
individual chunks and set all the (six) locale categories
supported one by one.
Covered with tests, note that, in practice, this only
happens with linux because it supports 12 locale categories
@ OS level. Both BSD (6) and Windows (5) hardly can reach the limit.
No matter of that, the tests have been designed to ensure that
they pass on all OSs, just the new code only will be executed
on linux.
Sara Arjona [Wed, 14 Dec 2022 08:57:03 +0000 (09:57 +0100)]
Merge branch 'MDL-75441-master' of https://github.com/aanabit/moodle
Anupama Sarjoshi [Fri, 9 Dec 2022 18:52:51 +0000 (18:52 +0000)]
MDL-76026 Question bank: Fix errors related to categories renaming
This part of the code in 'question_category_object.php' 'update_category' method was used before Moodle 4.0 version for renaming
the random questions in an updated category. For Moodle 4.0 and later versions, it is unnecessary as the details of
random questions are no more stored in 'question' table but in 'question_set_references' table.
The method call move_question_set_references handles the same.
Amaia Anabitarte [Fri, 25 Nov 2022 11:03:47 +0000 (12:03 +0100)]
MDL-75441 mod_forum: Show add new post button to guest users
Tim Hunt [Thu, 8 Dec 2022 16:44:52 +0000 (16:44 +0000)]
MDL-74923 quiz: move admin setting classes to mod_quiz\admin namespace
Tim Hunt [Thu, 8 Dec 2022 16:13:21 +0000 (16:13 +0000)]
MDL-74923 quiz: tidy qubaids classes
Including removing an almost duplicate task
Tim Hunt [Thu, 8 Dec 2022 15:39:23 +0000 (15:39 +0000)]
MDL-74923 quiz: move qubaids_for_quiz & ..._user to classes folder
Tim Hunt [Thu, 8 Dec 2022 15:22:31 +0000 (15:22 +0000)]
MDL-74923 quiz: clean up the display_options class
Tim Hunt [Wed, 7 Dec 2022 23:02:31 +0000 (23:02 +0000)]
MDL-74923 quiz: move mod_quiz_display_options to classes folder
Sara Arjona [Tue, 13 Dec 2022 14:34:22 +0000 (15:34 +0100)]
Merge branch 'MDL-73503-master' of https://github.com/sh-csg/moodle
Paul Holden [Tue, 13 Dec 2022 08:44:08 +0000 (08:44 +0000)]
MDL-76667 forms: mark modal form as submitted upon success.
Ensure the form change checker module doesn't warn user about it.
Andrew Nicols [Tue, 13 Dec 2022 12:56:32 +0000 (20:56 +0800)]
Merge branch 'MDL-76235' of https://github.com/paulholden/moodle
Andrew Nicols [Tue, 13 Dec 2022 12:34:34 +0000 (20:34 +0800)]
Merge branch 'MDL-74874' of https://github.com/uzimike/moodle
Andrew Nicols [Tue, 13 Dec 2022 12:30:57 +0000 (20:30 +0800)]
Merge branch 'MDL-76509-master' of https://github.com/safatshahin/moodle
Andrew Nicols [Tue, 13 Dec 2022 03:38:06 +0000 (11:38 +0800)]
Merge branch 'MDL-76536' of https://github.com/paulholden/moodle
Andrew Nicols [Tue, 13 Dec 2022 03:05:25 +0000 (11:05 +0800)]
MDL-76293 gradebook: Address coding violations
This includes a data provider which had the 'test_' prefix and was
therefore run as a test.
Andrew Nicols [Tue, 13 Dec 2022 03:00:30 +0000 (11:00 +0800)]
Merge branch 'MDL-76293' of https://github.com/mkassaei/moodle
Safat [Fri, 9 Dec 2022 02:44:48 +0000 (13:44 +1100)]
MDL-76509 core: Upgrade error resolve for slot tags
Shamiso.Jaravaza [Mon, 5 Dec 2022 15:31:27 +0000 (08:31 -0700)]
MDL-74779 mod_bigbluebuttonbn: Fix recording sort
AMOS BEGIN
MOV [config_recordings_sortorder,mod_bigbluebuttonbn],[config_recordings_asc_sort,mod_bigbluebuttonbn]
MOV [config_recordings_sortorder_description,mod_bigbluebuttonbn],[config_recordings_asc_sort_description,mod_bigbluebuttonbn]
AMOS END
Stefan Hanauska [Mon, 12 Dec 2022 20:12:02 +0000 (21:12 +0100)]
MDL-73503 report: Add filtering by section to report_progress
Sara Arjona [Mon, 12 Dec 2022 16:54:31 +0000 (17:54 +0100)]
Merge branch 'MDL-75594-master' of https://github.com/sh-csg/moodle
Sara Arjona [Mon, 12 Dec 2022 16:34:07 +0000 (17:34 +0100)]
Merge branch 'MDL-72451_master' of https://github.com/marxjohnson/moodle
Stefan Hanauska [Mon, 12 Dec 2022 13:39:53 +0000 (14:39 +0100)]
MDL-75594 course: Add beforemod parameter
Andrew Nicols [Mon, 12 Dec 2022 13:20:56 +0000 (21:20 +0800)]
Merge branch 'MDL-71261' of https://github.com/timhunt/moodle
Rex Lorenzo [Sat, 3 Apr 2021 01:01:21 +0000 (18:01 -0700)]
MDL-71261 mod_quiz: Quiz user override should only get enrolled users
Also update similar code in mod_assign to use the improved APIs.
Co-Authored-By: Tim Hunt <T.J.Hunt@open.ac.uk>
Sara Arjona [Mon, 12 Dec 2022 10:23:12 +0000 (11:23 +0100)]
Merge branch 'MDL-75571' of https://github.com/jacdsouza/moodle
Andrew Nicols [Sun, 11 Dec 2022 12:20:02 +0000 (20:20 +0800)]
Merge branch 'MDL-76398' of https://github.com/paulholden/moodle
Andrew Nicols [Sun, 11 Dec 2022 12:08:09 +0000 (20:08 +0800)]
Merge branch 'm42_MDL-72461_Moodle_JS_Files_Should_Be_Always_Served_By_JS_Handler' of https://github.com/scara/moodle
Jackson D'souza [Mon, 28 Nov 2022 12:03:39 +0000 (12:03 +0000)]
MDL-75571 tool_componentlibrary: Custom activity icon
Jackson D'souza [Mon, 28 Nov 2022 12:01:17 +0000 (12:01 +0000)]
MDL-75571 theme_boost: Activity icon
* Use Activity get_icon_url helper method to fetch icon.
Jackson D'souza [Mon, 28 Nov 2022 12:00:15 +0000 (12:00 +0000)]
MDL-75571 block_timeline: Display custom activity icon if available.
Jackson D'souza [Tue, 15 Nov 2022 13:27:35 +0000 (13:27 +0000)]
MDL-75571 calendar: Activity icon
* Use Activity get_icon_url helper method to fetch icon.
Sara Arjona [Fri, 9 Dec 2022 15:18:00 +0000 (16:18 +0100)]
Merge branch 'MDL-76274-master' of https://github.com/cameron1729/moodle
Matteo Scaramuccia [Sat, 29 Oct 2022 16:49:05 +0000 (18:49 +0200)]
MDL-72461 core: Required JS files in $PAGE served by the Moodle handler
Paul Holden [Thu, 1 Dec 2022 12:12:59 +0000 (12:12 +0000)]
MDL-76536 enrol: prevent invalid role assignments in course creation.
Upgrade step to fixup existing bad data.
Paul Holden [Wed, 19 Oct 2022 08:47:20 +0000 (09:47 +0100)]
MDL-75805 admin: allow multiselect when editing site administrators.
Paul Holden [Tue, 8 Nov 2022 20:57:57 +0000 (20:57 +0000)]
MDL-76235 core: compare email diversion exceptions case-insensitively.
Co-authored-by: Jan Kristoffer Roth <roth@dhbw-mosbach.de>
Eloy Lafuente (stronk7) [Wed, 19 Oct 2022 09:46:10 +0000 (11:46 +0200)]
MDL-71096 core: Add meta information about APIs to core
Right now we have the information only in docs:
- https://docs.moodle.org/dev/Core_APIs
- https://moodledev.io/docs/apis
And, in fact, we are crawling those pages to get the information
from various tools (moodlecheck, CiBoT...). Obviously, that's far
from ideal, the source only has the current list of APIs, and
there isn't much information there but the names.
So we are moving the source of information to be in core, so it
can be modified between branches, and contains richer information:
- The component the API belongs to, usually a subsystem or core.
- If the API can be used as level 2 namespace.
- If the API can be used as level 2 namespace out from its component.
Note that all that information has NO USES right now in core (and maybe
never will), but tools/checkers will benefit enormously by having that
information at hand, so we can check for namespaces, categories and
other bits way better.
Also, once we have this, the APIs dev documents linked above, surely
can be improved by being automatically generated and include all the
meta-information available.
It also includes a very basic json schema validating the basis. It can
be tried online @ https://www.jsonschemavalidator.net , or any other
tool. PHP requires extra libraries to be able to perform the validation.
Covered with unit tests, both api-related functions and structure validation.
Sara Arjona [Fri, 9 Dec 2022 07:56:53 +0000 (08:56 +0100)]
weekly release 4.2dev
Jun Pataleta [Thu, 8 Dec 2022 02:07:52 +0000 (10:07 +0800)]
Merge branch 'MDL-76556-master' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 8 Dec 2022 00:08:19 +0000 (08:08 +0800)]
Merge branch 'MDL-76491' of https://github.com/paulholden/moodle
Andrew Nicols [Wed, 7 Dec 2022 23:53:09 +0000 (07:53 +0800)]
Merge branch 'MDL-76550' of https://github.com/AnupamaSarjoshi/moodle
Andrew Nicols [Wed, 7 Dec 2022 23:26:24 +0000 (07:26 +0800)]
Merge branch 'MDL-76074-master' of https://github.com/srobotta/moodle
Andrew Nicols [Wed, 7 Dec 2022 22:14:24 +0000 (06:14 +0800)]
Merge branch 'MDL-76116-master' of https://github.com/meirzamoodle/moodle
Sara Arjona [Wed, 7 Dec 2022 18:31:04 +0000 (19:31 +0100)]
Merge branch 'MDL-75588-master' of https://github.com/HuongNV13/moodle
Sara Arjona [Wed, 7 Dec 2022 17:32:13 +0000 (18:32 +0100)]
Merge branch 'MDL-76575-master' of https://github.com/HuongNV13/moodle
Sara Arjona [Wed, 7 Dec 2022 17:27:46 +0000 (18:27 +0100)]
Merge branch 'MDL-76500' of https://github.com/paulholden/moodle
Trevor Jones [Fri, 2 Dec 2022 17:53:39 +0000 (10:53 -0700)]
MDL-72906 Quiz: Prevent scrollbar on multichoice
Remove negative margin from the "clear my choice" anchor.
With the negative margin, when the containing box height is calculated
the anchor's hidden style overflows beyond the boundary and triggers
the overflow:auto to add a scroll bar.
Sara Arjona [Wed, 7 Dec 2022 16:26:11 +0000 (17:26 +0100)]
Merge branch 'MDL-76193-master' of https://github.com/JBThong/moodle
Sara Arjona [Wed, 7 Dec 2022 16:17:23 +0000 (17:17 +0100)]
Merge branch 'MDL-76571' of https://github.com/timhunt/moodle
Tim Hunt [Mon, 5 Dec 2022 15:41:52 +0000 (15:41 +0000)]
MDL-76571 quiz reports: should not show description items
... or anything else with length = 0. This got broken in MDL-71696.
The only way to fix this kind-of involves and API change to
quiz_report_get_significant_questions. However, it is only changing
the external API of this function back to how it was before the 4.0 release,
and the chnages in 4.0 were never documented, nor, I would guess, intended,
since they just broke things.
Jun Pataleta [Wed, 7 Dec 2022 14:41:20 +0000 (22:41 +0800)]
Merge branch 'MDL-76559-master' of https://github.com/andrewnicols/moodle
Andrew Nicols [Wed, 7 Dec 2022 13:40:01 +0000 (21:40 +0800)]
MDL-76559 core: validate_email does not take false either
Sara Arjona [Wed, 7 Dec 2022 11:51:08 +0000 (12:51 +0100)]
Merge branch 'MDL-76273' of https://github.com/paulholden/moodle
Huong Nguyen [Wed, 7 Dec 2022 03:34:36 +0000 (10:34 +0700)]
MDL-75588 assign: Reset completion status when resetting a submission
Huong Nguyen [Wed, 7 Dec 2022 08:50:01 +0000 (15:50 +0700)]
MDL-76575 tiny_media: Remove unnecessary console log
Jun Pataleta [Wed, 7 Dec 2022 05:47:04 +0000 (13:47 +0800)]
Merge branch 'MDL-73017_add-environment-check-for-versions-not-supporting-php-8-1' of https://github.com/ziegenberg/moodle