David Matamoros [Tue, 23 Mar 2021 14:09:20 +0000 (15:09 +0100)]
MDL-71153 task: convert task logs table to a system report.
Convert to system report API provided by Report builder. The entity
defined the column and filters, which are used by the system
report class we have created.
Report actions are also defined in the system report.
abgreeve [Mon, 2 Aug 2021 04:39:32 +0000 (12:39 +0800)]
Merge branch 'MDL-70794' of git://github.com/paulholden/moodle
abgreeve [Mon, 2 Aug 2021 02:11:15 +0000 (10:11 +0800)]
Merge branch 'MDL-71621-master' of git://github.com/aanabit/moodle
Ilya Tregubov [Fri, 30 Jul 2021 12:34:16 +0000 (14:34 +0200)]
Merge branch 'MDL-72070-master' of git://github.com/lucaboesch/moodle
Ilya Tregubov [Fri, 30 Jul 2021 10:24:35 +0000 (12:24 +0200)]
Merge branch 'MDL-70271-master' of git://github.com/peterRd/moodle
Víctor Déniz [Fri, 30 Jul 2021 07:51:47 +0000 (08:51 +0100)]
Merge branch 'MDL-72085-master' of https://github.com/dmitriim/moodle
Jun Pataleta [Thu, 29 Jul 2021 08:24:19 +0000 (16:24 +0800)]
Merge branch 'MDL-72052' of git://github.com/danmarsden/moodle
Jun Pataleta [Thu, 29 Jul 2021 07:53:43 +0000 (15:53 +0800)]
Merge branch 'MDL-72054' of git://github.com/danmarsden/moodle
Dmitrii Metelkin [Thu, 29 Jul 2021 01:51:49 +0000 (11:51 +1000)]
MDL-72085 core_phpunit: reset session notifications
Luca Bösch [Thu, 1 Jul 2021 19:14:54 +0000 (21:14 +0200)]
MDL-72070 core_calendar: Calendar footer links • separator colour
Mikel Martín [Tue, 20 Apr 2021 10:00:53 +0000 (12:00 +0200)]
MDL-70794 theme_boost: SCSS for Report builder filters dropdown.
Paul Holden [Tue, 20 Apr 2021 09:01:21 +0000 (09:01 +0000)]
MDL-70794 reportbuilder: user interface for using report filters.
The report filter form is implemented as a dynamic form. Implement
accompanying AMD module for interacting with it here (applying and
resetting report filters).
Co-Authored-By: Mikel Martín <mikel@moodle.com>
David Matamoros [Fri, 16 Apr 2021 07:42:38 +0000 (09:42 +0200)]
MDL-70794 reportbuilder: privacy provider implementation.
Note that although system report persistents store user modified
and created fields, these are not the values of the user who did
either. Merely the user who first viewed the report.
Sara Arjona [Fri, 12 Feb 2021 14:55:15 +0000 (15:55 +0100)]
MDL-70794 reportbuilder: introduce the concept of report entities.
Entities are re-usable collections of report columns and filters. When
creating system reports, we can re-use those elements from entities
without having to know specific details about their implementation.
They can be joined to reports, or other entities, using standard SQL
query syntax.
Define base classes, and create two example entities: course and user.
Co-Authored-By: David Matamoros <davidmc@moodle.com>
Paul Holden [Fri, 11 Dec 2020 15:06:05 +0000 (15:06 +0000)]
MDL-70794 reportbuilder: output components and classes.
This change contains most of the output components required for
reports such as exporters, templates, AMD modules.
Also included are classes within the component table namespace which
are required for extending the dynamic table API.
Paul Holden [Wed, 9 Dec 2020 14:23:10 +0000 (14:23 +0000)]
MDL-70794 reportbuilder: management and further utility classes.
We define the base classes and APIs for reports, that can contain
columns and filters instances themselves.
David Matamoros [Tue, 16 Mar 2021 11:12:10 +0000 (11:12 +0000)]
MDL-70794 reportbuilder: implement report filters and filter types.
Implement base filter classes as well as commonly used filter types
(e.g. text, date, select, etc).
Filters are used in reports to allow users to narrow down the data
that is being displayed.
Co-Authored-By: Paul Holden <paulh@moodle.com>
Paul Holden [Mon, 11 Jan 2021 16:05:40 +0000 (16:05 +0000)]
MDL-70794 reportbuilder: implement report column and action classes.
The column class encapsulates all data related to a report column. It
allows developers to define the type of data contained within it, in
addition to how that data is retrieved and formatted for users.
Report actions are used to define action elements that are added to
each report row. They define an icon and link, and can be used to
direct users to related pages according to the current row data.
Paul Holden [Tue, 10 Nov 2020 09:24:12 +0000 (09:24 +0000)]
MDL-70794 reportbuilder: register new core sub-system.
In addition to housekeeping for the new sub-system, define our
table schema to be used in later persistents.
Ilya Tregubov [Wed, 28 Jul 2021 14:48:19 +0000 (16:48 +0200)]
weekly release 4.0dev
Ilya Tregubov [Wed, 28 Jul 2021 14:48:17 +0000 (16:48 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jun Pataleta [Wed, 28 Jul 2021 03:26:42 +0000 (11:26 +0800)]
Merge branch 'MDL-72203-master-2' of git://github.com/mickhawkins/moodle
AMOS bot [Wed, 28 Jul 2021 00:07:48 +0000 (00:07 +0000)]
Automatically generated installer lang files
Michael Hawkins [Tue, 27 Jul 2021 14:39:44 +0000 (22:39 +0800)]
MDL-72203 curl: Improve redirect unit testing and update upgrade.txt
lib/upgrade.txt was updated to reflect the fact that all cURL redirects
will be emulated.
David Mudrák [Thu, 22 Jul 2021 23:04:06 +0000 (01:04 +0200)]
MDL-72203 curl: Remove duplicate unit tests for emulated redirects
Before, we had each redirect test duplicated: one for the native
redirects via native cURL, second for our emulated implementation. Now
all redirects are always emulated so there is no need to have them
tested twice.
David Mudrák [Thu, 22 Jul 2021 21:28:23 +0000 (23:28 +0200)]
MDL-72203 curl: Check each URL in redirect chain to see if it is blocked
The security problem here was that only the first and the last URL in
the redirect chain was checked by the security helper. This patch forces
the curl wrapper to always emulate cURL redirects and check every
redirect URL in the chain before actually visiting it.
David Mudrák [Thu, 22 Jul 2021 21:20:14 +0000 (23:20 +0200)]
MDL-72203 curl: Warn if someone actually started to use $maxredirects
The new parameter of curl_security_helper::url_is_blocked() introduced
in MDL-71916 became part of the API. Even if we reverted it quickly,
someone can use a released Moodle version that has that parameter in
place. For that reason and also to avoid potential troubles in the
future (e.g. when yet another argument would be added to this method),
we need to make it clear that the second parameter of this method should
never be used again.
Poor $maxredirects, you did not live long with us. Oh well.
David Mudrák [Thu, 22 Jul 2021 21:10:11 +0000 (23:10 +0200)]
MDL-72203 curl: Revert original fix of redirects to blocked URLs
This reverts the original fix introduced in MDL-71916. It introduced an
extra native cURL call inside curl_security_helper to check if the given
URL triggers a redirect to a blocked URL or not.
Shortly after the release, a couple of regressions were reported as a
result of the integrated solution. It was agreed to revert the fix and
progress with implementing an alternative approach.
Ilya Tregubov [Tue, 27 Jul 2021 11:41:05 +0000 (13:41 +0200)]
Merge branch 'MDL-71946-master' of git://github.com/dcai/moodle
Ilya Tregubov [Tue, 27 Jul 2021 10:36:38 +0000 (12:36 +0200)]
Merge branch 'MDL-72179-master' of git://github.com/andrewnicols/moodle
Ilya Tregubov [Tue, 27 Jul 2021 09:59:15 +0000 (11:59 +0200)]
Merge branch 'MDL-71672-master-2' of git://github.com/rezaies/moodle
Andrew Nicols [Wed, 21 Jul 2021 03:36:34 +0000 (11:36 +0800)]
MDL-72179 behat: Make use of page resolvers
Andrew Nicols [Fri, 23 Jul 2021 02:58:00 +0000 (10:58 +0800)]
MDL-72179 behat: Add page resolvers for activity roles/perms
Andrew Nicols [Tue, 20 Jul 2021 09:12:05 +0000 (17:12 +0800)]
MDL-72179 behat: Add page resolver for activity names
Andrew Nicols [Tue, 20 Jul 2021 06:15:59 +0000 (14:15 +0800)]
MDL-72179 behat: Add activity editing page resolution
Andrew Nicols [Tue, 20 Jul 2021 05:09:46 +0000 (13:09 +0800)]
MDL-72179 behat: Fix page resolvers to remove ambiguity
The simple pattern matches were conflicting in some situations. To make
this backwards compatable we need to convert it to a Regex pattern match
instead, and provide the quoted and unquoted variants.
Andrew Nicols [Tue, 20 Jul 2021 04:49:45 +0000 (12:49 +0800)]
MDL-72179 behat: Correct course category page resolving
There were two issues here:
* I am on the [categoryname] category page page (duplicated page)
* the wrong URL was being used
Since an incorrect URL was used I felt it safe to rename the step from
'category page page' to 'category page'.
Andrew Nicols [Tue, 20 Jul 2021 10:25:17 +0000 (18:25 +0800)]
MDL-72179 behat: Lowercase all page instance resolvers
Andrew Nicols [Mon, 19 Jul 2021 06:06:37 +0000 (14:06 +0800)]
MDL-72179 behat: Improve core page resolvers
This commit makes the following improvements to core page resolverss:
* allows for mixed case naming (course, Course, etc.)
* allows fields other than the idnumber to be specified:
** course: idnumber, shortname, fullname
** course category: idnumber, name
Whilst some of these fields are not unique, they will typically be
unique in most test scenarios. Where they are not then the idnumber
should be used in preference.
Amaia Anabitarte [Fri, 14 May 2021 12:02:02 +0000 (14:02 +0200)]
MDL-71621 core_user: Parents could edit custom fields in child profile
Ilya Tregubov [Fri, 23 Jul 2021 09:30:58 +0000 (11:30 +0200)]
weekly release 4.0dev
Ilya Tregubov [Fri, 23 Jul 2021 09:30:56 +0000 (11:30 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jun Pataleta [Thu, 22 Jul 2021 09:25:41 +0000 (17:25 +0800)]
MDL-71817 calendar: Use root node to find the target elements
Instead of passing querying for the root element again by its ID
which changed in this issue, use the already existing root element
at the beginning of this Mustache JS code. It also makes maintenance
simpler in the future.
Jun Pataleta [Thu, 22 Jul 2021 03:27:08 +0000 (11:27 +0800)]
Merge branch 'MDL-71817-master' of git://github.com/lameze/moodle
Andrew Nicols [Thu, 22 Jul 2021 03:22:13 +0000 (11:22 +0800)]
Merge branch 'MDL-70427' of git://github.com/paulholden/moodle
Jun Pataleta [Thu, 22 Jul 2021 03:11:20 +0000 (11:11 +0800)]
Merge branch 'MDL-72154-master' of git://github.com/mickhawkins/moodle
Jun Pataleta [Wed, 21 Jul 2021 15:49:23 +0000 (23:49 +0800)]
MDL-71817 calendar: Set the calendar view mode properly for month view
* Store the view mode of the calendar in the calendar_information
object.
* Let the month exporter handle the production of context data by
moving 'viewingmonth', 'showviewselector', and 'viewinginblock'
inside it.
* Set the proper calendar view mode in the core_calendar/month_detailed
template.
* Pass the calendar view mode to the
core_calendar_get_calendar_monthly_view WS function.
Simey Lameze [Wed, 21 Jul 2021 05:45:31 +0000 (13:45 +0800)]
MDL-71817 calendar: change the calendar heading to h4 in the block
This commit adds the logic that change the size of the calendar
header depending if the user is viewing in the block or in the
full view.
Simey Lameze [Mon, 19 Jul 2021 00:28:06 +0000 (08:28 +0800)]
MDL-71817 calendar: behat changes for calendar block
This commit does few things:
1) Remove unnecessary "I hover over today in the calendar"
steps as it's not necessary to hover onto the day to see the events
any more.
2) Replace "I follow This month" steps to "I follow Full calendar"
3) Update i_create_a_calendar_event_with_form_data() to use the new
fullcalendar lang string.
Jun Pataleta [Mon, 19 Jul 2021 17:52:25 +0000 (01:52 +0800)]
MDL-71817 calendar: Fix duplicate IDs for multiple calendar blocks
Done by:
* Designating instance IDs for each month_exporter instances and
assigning these instance IDs in templates.
* Adding the instance ID as an optional parameter for the
core_calendar_renderer::course_filter_selector() to generate
course filters with unique element IDs.
Simey Lameze [Thu, 15 Jul 2021 11:53:10 +0000 (19:53 +0800)]
MDL-71817 calendar: clicking on day link should redirect to day view
This patch prevents the full day view to be loaded
in the calendar block as this won't be supported.
When clicking in the day link it will redirect the
user to day view in the full calendar.
Simey Lameze [Wed, 30 Jun 2021 06:01:11 +0000 (14:01 +0800)]
MDL-71817 calendar: make calendar block look like full calendar
This commit does few things:
1) Removes .path-calendar specificity styles from full view can
work on the Dashboard.
2) The new event button colour has been changed to btn-primary.
3) CSS fix to make the calendar controls inline on small block.
Simey Lameze [Thu, 1 Jul 2021 03:17:54 +0000 (11:17 +0800)]
MDL-71817 calendar: remove year from prev/next links
Simey Lameze [Wed, 30 Jun 2021 05:59:25 +0000 (13:59 +0800)]
MDL-71817 calendar: only update url on full view
This patch prevents the URL from being updated on the calendar
block. It only updates the url if viewing the full calendar.
Simey Lameze [Thu, 1 Jul 2021 02:56:52 +0000 (10:56 +0800)]
MDL-71817 block_calendar_month: load month view in the block
AMOS bot [Thu, 22 Jul 2021 00:07:56 +0000 (00:07 +0000)]
Automatically generated installer lang files
Víctor Déniz [Wed, 21 Jul 2021 22:04:51 +0000 (23:04 +0100)]
Merge branch 'MDL-72001-master' of git://github.com/roland04/moodle
Víctor Déniz [Wed, 21 Jul 2021 18:25:54 +0000 (19:25 +0100)]
Merge branch 'MDL-72108-master' of git://github.com/andrewnicols/moodle
Michael Hawkins [Thu, 15 Jul 2021 06:50:07 +0000 (14:50 +0800)]
MDL-72154 calendar: Add manage subscription to export page breadcrumbs
Michael Hawkins [Thu, 15 Jul 2021 06:13:17 +0000 (14:13 +0800)]
MDL-72154 calendar: Remove unnecessary strings/link from import page
Ilya Tregubov [Tue, 20 Jul 2021 12:09:11 +0000 (14:09 +0200)]
Merge branch 'MDL-71604-master' of git://github.com/rezaies/moodle
Ilya Tregubov [Mon, 19 Jul 2021 11:03:46 +0000 (13:03 +0200)]
Merge branch 'MDL-72125-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 8 Jul 2021 05:05:57 +0000 (13:05 +0800)]
MDL-72125 mod_assign: Use assign submission data generators
Andrew Nicols [Thu, 8 Jul 2021 04:29:28 +0000 (12:29 +0800)]
MDL-72125 mod_assign: Add data generator for assign submissions
Andrew Nicols [Mon, 19 Jul 2021 08:42:21 +0000 (16:42 +0800)]
MDL-72125 testing: Make global $CFG available when including generators
This will remove the requirement to add the global $CFG call to the top
of generator scripts.
Ilya Tregubov [Mon, 19 Jul 2021 08:28:51 +0000 (10:28 +0200)]
Merge branch 'MDL-72078-master' of git://github.com/rezaies/moodle
Shamim Rezaie [Thu, 1 Jul 2021 09:34:27 +0000 (19:34 +1000)]
MDL-72078 editor_atto: Use role=application and aria-describedby in Atto
According to https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Application_Role
WYSIWYG web editors are proper use of the application role.
Shamim Rezaie [Wed, 23 Jun 2021 15:02:13 +0000 (01:02 +1000)]
MDL-71604 editor_atto: Move accessibility buttons to the first row
Shamim Rezaie [Mon, 14 Jun 2021 11:58:12 +0000 (21:58 +1000)]
MDL-71672 javascript: Fix the markup in the header of YUI dialogs
Move the close button out of the element that is set as the
aria-labelledby for the dialog.
Also used h5 for the dialog titles so they are consistent with
AMD modals.
Shamim Rezaie [Fri, 18 Jun 2021 20:59:45 +0000 (06:59 +1000)]
MDL-71672 atto_equation: Fix the markup and the initial focused element
The initial focused element should be the first operator button.
This commit also fixes the accessibility issues that previously were
wrongly fixed by a redundant click on the first tab using javascript.
Shamim Rezaie [Mon, 7 Jun 2021 02:37:11 +0000 (12:37 +1000)]
MDL-71672 atto_managefiles: Focus the first file manager button
Shamim Rezaie [Sun, 6 Jun 2021 21:55:08 +0000 (07:55 +1000)]
MDL-71672 atto_emojipicker: Focus the search bar initially
Shamim Rezaie [Wed, 2 Jun 2021 10:11:58 +0000 (20:11 +1000)]
MDL-71672 atto_recordrtc: focus Atto button after hide
Shamim Rezaie [Wed, 2 Jun 2021 07:59:04 +0000 (17:59 +1000)]
MDL-71672 javascript: Fix the issue of focusOnShowSelector being ignored
When focusOnShowSelector is not present, as a fallback, focus the first
focusable element in YUI dialogues
Ref:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
Mikel Martín [Wed, 23 Jun 2021 14:51:46 +0000 (16:51 +0200)]
MDL-72001 my: Add '__default' name check when retrieving default page
Andrew Nicols [Fri, 9 Jul 2021 01:27:03 +0000 (09:27 +0800)]
MDL-72125 behat: Add get_activity_id() behat generators helper
Andrew Nicols [Thu, 8 Jul 2021 03:50:17 +0000 (11:50 +0800)]
MDL-72125 testing: Set a default idnumber when creating activities
The activity generator currently requires an idnumber when creating
activities, but this is not a requirement when creating the same
activity through the UI. The requirement comes because we want to
provide a way to refer to activities in subsequent steps.
This commit modifies the behaviour such that the generator uses the name
of the activity as the default idnumber.
This has two main benefits:
1. it simplfies generation of activities; and
2. it makes the language used when writing behat tests much more natural.
With this change, steps will refer to the activity by its idnumber/title
in all cases, rather than sometimes by an idnumber which bears no
relevance to the title.
Andrew Nicols [Thu, 8 Jul 2021 04:20:50 +0000 (12:20 +0800)]
MDL-72125 testing: Add helper to run generators as a user
abgreeve [Fri, 16 Jul 2021 02:16:35 +0000 (10:16 +0800)]
weekly release 4.0dev
abgreeve [Fri, 16 Jul 2021 02:16:34 +0000 (10:16 +0800)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
AMOS bot [Fri, 16 Jul 2021 00:07:50 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Thu, 15 Jul 2021 07:39:31 +0000 (09:39 +0200)]
Merge branch 'MDL-71788-master-fix' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 15 Jul 2021 03:40:25 +0000 (11:40 +0800)]
Merge branch 'MDL-63770-master' of /home/jun/moodles/stable_master/moodle
Jun Pataleta [Thu, 15 Jul 2021 03:09:39 +0000 (11:09 +0800)]
Merge branch 'MDL-71456-master' of /home/jun/moodles/stable_master/moodle
Jun Pataleta [Thu, 15 Jul 2021 02:23:27 +0000 (10:23 +0800)]
Merge branch 'MDL-71775-master' of git://github.com/lameze/moodle
Jun Pataleta [Thu, 15 Jul 2021 06:49:07 +0000 (14:49 +0800)]
MDL-71788 calendar: Remove ready state listener
Adding a document ready state change listener might be too late by the
time this AMD module gets loaded. So there's really no point listening
for it. It's better to enable the Copy URL button by the time this
the calendar export module gets loaded since at this point, the
copy to clipboard JS module would have been loaded as well.
Matteo Scaramuccia [Sun, 3 May 2020 21:46:18 +0000 (23:46 +0200)]
MDL-63770 core: 'port' should be an integer like in parse_url()
Plus trivial comment cleanup.
Simey Lameze [Tue, 13 Jul 2021 06:14:33 +0000 (14:14 +0800)]
MDL-71775 block_calendar_month: add footer options
Eloy Lafuente (stronk7) [Thu, 15 Jul 2021 00:56:58 +0000 (02:56 +0200)]
Merge branch 'MDL-71788-master-7' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Wed, 14 Jul 2021 22:33:57 +0000 (00:33 +0200)]
Merge branch 'MDL-67338' of git://github.com/paulholden/moodle
Paul Holden [Thu, 8 Apr 2021 21:37:53 +0000 (22:37 +0100)]
MDL-67338 message: re-implement block page type patterns.
The `page_type_list` method for the message component was deprecated
in
5b0769db as part of MDL-54744. However it is still required when
trying to configure blocks on any messaging pages.
Eloy Lafuente (stronk7) [Wed, 14 Jul 2021 17:25:47 +0000 (19:25 +0200)]
Merge branch 'MDL-71790-master' of git://github.com/HuongNV13/moodle
Eloy Lafuente (stronk7) [Wed, 14 Jul 2021 11:59:50 +0000 (13:59 +0200)]
Merge branch 'MDL-72139-master' of git://github.com/cescobedo/moodle
Bas Brands [Thu, 8 Jul 2021 08:01:10 +0000 (10:01 +0200)]
MDL-71456 core: fix behats with new drawers
The new drawers structure shows that some elements
are dependant from the page structure and broke some
behats. This commit fixes those components and tests.
Bas Brands [Thu, 20 May 2021 14:22:24 +0000 (16:22 +0200)]
MDL-71456 theme_boost: usertour fixes for pages with drawers
Bas Brands [Thu, 29 Apr 2021 10:03:06 +0000 (12:03 +0200)]
MDL-71456 theme_boost: drawers for blocks and the course index
cescobedo [Tue, 13 Jul 2021 09:05:32 +0000 (11:05 +0200)]
MDL-72139 core_message: Fix encoding UTF-8 in prevent unclosed tags
Eloy Lafuente (stronk7) [Tue, 13 Jul 2021 21:46:54 +0000 (23:46 +0200)]
Merge branch 'MDL-71984-master' of https://github.com/nguyenphuctien/moodle
Eloy Lafuente (stronk7) [Tue, 13 Jul 2021 18:38:01 +0000 (20:38 +0200)]
Merge branch 'MDL-71874-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Tue, 13 Jul 2021 16:41:58 +0000 (00:41 +0800)]
Merge branch 'MDL-71931-master' of git://github.com/andrewnicols/moodle