Andrew Nicols [Fri, 16 Dec 2022 03:00:58 +0000 (11:00 +0800)]
MDL-76583 core: Update uses of external_* classes
Andrew Nicols [Wed, 7 Dec 2022 13:32:18 +0000 (21:32 +0800)]
MDL-76583 core_external: Note deprecations and renames
Andrew Nicols [Wed, 7 Dec 2022 03:46:03 +0000 (11:46 +0800)]
MDL-76583 core_external: External API Test coding style fixes
Andrew Nicols [Fri, 16 Dec 2022 02:50:04 +0000 (10:50 +0800)]
MDL-76583 core_external: Update service management functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:50 +0000 (14:43 +0800)]
MDL-76583 core_external: Update util string formatting functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:38 +0000 (14:43 +0800)]
MDL-76583 core_external: Update token functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:19 +0000 (14:43 +0800)]
MDL-76583 core_external: util class coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:56:49 +0000 (14:56 +0800)]
MDL-76583 core_external: external_files coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 07:53:33 +0000 (15:53 +0800)]
MDL-76583 core_external: external_value coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:23 +0000 (14:52 +0800)]
MDL-76583 core_external: external_format_value coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:49 +0000 (14:52 +0800)]
MDL-76583 core_external: external_single_structure coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:44 +0000 (14:52 +0800)]
MDL-76583 core_external: external_multiple_structure coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:32 +0000 (14:52 +0800)]
MDL-76583 core_external: external_function_params coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:41:38 +0000 (14:41 +0800)]
MDL-76583 core_external: external_warnings coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:40:56 +0000 (14:40 +0800)]
MDL-76583 core_external: external_api unit tests coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 04:06:18 +0000 (12:06 +0800)]
MDL-76583 core_external: external_description coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 07:46:11 +0000 (15:46 +0800)]
MDL-76583 core_external: external settings coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 02:52:59 +0000 (10:52 +0800)]
MDL-76583 core_external: core_external\external_api coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 21:32:28 +0000 (05:32 +0800)]
MDL-76583 core_external: Implement Privacy API for core_external
AMOS BEGIN
MOV [privacy:metadata:serviceusers,core_webservice],[privacy:metadata:serviceusers,core_external]
MOV [privacy:metadata:serviceusers:iprestriction,core_webservice],[privacy:metadata:serviceusers:iprestriction,core_external]
MOV [privacy:metadata:serviceusers:timecreated,core_webservice],[privacy:metadata:serviceusers:timecreated,core_external]
MOV [privacy:metadata:serviceusers:userid,core_webservice],[privacy:metadata:serviceusers:userid,core_external]
MOV [privacy:metadata:serviceusers:validuntil,core_webservice],[privacy:metadata:serviceusers:validuntil,core_external]
MOV [privacy:metadata:tokens,core_webservice],[privacy:metadata:tokens,core_external]
MOV [privacy:metadata:tokens:creatorid,core_webservice],[privacy:metadata:tokens:creatorid,core_external]
MOV [privacy:metadata:tokens:iprestriction,core_webservice],[privacy:metadata:tokens:iprestriction,core_external]
MOV [privacy:metadata:tokens:lastaccess,core_webservice],[privacy:metadata:tokens:lastaccess,core_external]
MOV [privacy:metadata:tokens:privatetoken,core_webservice],[privacy:metadata:tokens:privatetoken,core_external]
MOV [privacy:metadata:tokens:timecreated,core_webservice],[privacy:metadata:tokens:timecreated,core_external]
MOV [privacy:metadata:tokens:token,core_webservice],[privacy:metadata:tokens:token,core_external]
MOV [privacy:metadata:tokens:tokentype,core_webservice],[privacy:metadata:tokens:tokentype,core_external]
MOV [privacy:metadata:tokens:userid,core_webservice],[privacy:metadata:tokens:userid,core_external]
MOV [privacy:metadata:tokens:validuntil,core_webservice],[privacy:metadata:tokens:validuntil,core_external]
MOV [privacy:request:notexportedsecurity,core_webservice],[privacy:request:notexportedsecurity,core_external]
AMOS END
Andrew Nicols [Fri, 16 Dec 2022 02:49:02 +0000 (10:49 +0800)]
MDL-76583 core_external: Migrate service management to util
Andrew Nicols [Wed, 7 Dec 2022 08:47:50 +0000 (16:47 +0800)]
MDL-76583 core_external: Migrate string formatting functions to util
Andrew Nicols [Wed, 7 Dec 2022 07:15:04 +0000 (15:15 +0800)]
MDL-76583 core_external: Migrate token functions class
Andrew Nicols [Wed, 7 Dec 2022 05:34:17 +0000 (13:34 +0800)]
MDL-76583 core_external: Move util test and update
Andrew Nicols [Wed, 7 Dec 2022 05:27:52 +0000 (13:27 +0800)]
MDL-76583 core_external: Move files test and update
Andrew Nicols [Wed, 7 Dec 2022 05:25:13 +0000 (13:25 +0800)]
MDL-76583 core_external: Move settings test and update
Andrew Nicols [Wed, 7 Dec 2022 05:14:18 +0000 (13:14 +0800)]
MDL-76583 core_external: Migrate external_settings class
Andrew Nicols [Wed, 7 Dec 2022 05:10:17 +0000 (13:10 +0800)]
MDL-76583 core_external: Migrate external_format_value class
Andrew Nicols [Wed, 7 Dec 2022 04:51:13 +0000 (12:51 +0800)]
MDL-76583 core_external: Migrate external_warnings class
Andrew Nicols [Wed, 7 Dec 2022 04:33:43 +0000 (12:33 +0800)]
MDL-76583 core_external: Migrate external_files class
Andrew Nicols [Wed, 7 Dec 2022 13:30:09 +0000 (21:30 +0800)]
MDL-76583 core_external: Migrate external_util class
Andrew Nicols [Wed, 7 Dec 2022 04:28:45 +0000 (12:28 +0800)]
MDL-76583 core_external: Migrate restricted_context_exception class
Andrew Nicols [Wed, 7 Dec 2022 04:24:31 +0000 (12:24 +0800)]
MDL-76583 core_external: Migrate external_function_parameters class
Andrew Nicols [Wed, 7 Dec 2022 04:13:48 +0000 (12:13 +0800)]
MDL-76583 core_external: Migrate external_multiple_structure class
Andrew Nicols [Wed, 7 Dec 2022 04:13:13 +0000 (12:13 +0800)]
MDL-76583 core_external: Migrate external_single_structure class
Andrew Nicols [Wed, 7 Dec 2022 04:07:35 +0000 (12:07 +0800)]
MDL-76583 core_external: Migrate external_value class
Andrew Nicols [Wed, 7 Dec 2022 03:49:40 +0000 (11:49 +0800)]
MDL-76583 core_external: Migrate external_description class
Andrew Nicols [Wed, 7 Dec 2022 03:07:54 +0000 (11:07 +0800)]
MDL-76583 core_external: Move external_api unit tests
Andrew Nicols [Wed, 7 Dec 2022 02:32:02 +0000 (10:32 +0800)]
MDL-76583 core_external: Migrate external_api to core_external\external_api
Andrew Nicols [Wed, 7 Dec 2022 02:28:07 +0000 (10:28 +0800)]
MDL-76583 core_external: Add new core_external subsystem
Jun Pataleta [Fri, 13 Jan 2023 02:52:09 +0000 (10:52 +0800)]
weekly release 4.2dev
Paul Holden [Thu, 12 Jan 2023 12:09:15 +0000 (12:09 +0000)]
Merge branch 'MDL-76739-master-fix' of https://github.com/junpataleta/moodle
Jun Pataleta [Thu, 12 Jan 2023 09:09:58 +0000 (17:09 +0800)]
Merge branch 'MDL-76649-master-fix' of https://github.com/junpataleta/moodle
Jun Pataleta [Thu, 12 Jan 2023 08:51:47 +0000 (16:51 +0800)]
MDL-76739 mod_data: Split comments test into two
MDL-75596 added an "Insert an activity or resource before ..." button
that allows adding an activity or a resource before or after another
activity in a course. This renders the button in the DOM (although
hidden and shown only on mouseover) when there's at least one activity
in the course.
In this issue, the button's label was renamed to "Add an activity or
resource before ..." and it now obscures the normal "Add an activity or
resource" button at the bottom of the course section from being
interacted on when running Behat tests.
This failure happens in the create_activity.feature file as it creates
two DB activities in a single scenario – one when "usecomments" is
turned on and one when it's turned off. Given this limitation, a
workaround is to split the "Teacher cannot enable comments if they are
disabled at site level" scenario into two scenarios with the first one
testing when "usecomments" is on while the second scenario testing when
"usecomments" is turned off.
Jun Pataleta [Thu, 12 Jan 2023 07:17:35 +0000 (15:17 +0800)]
MDL-76649 mod_quiz: Use correct quizid attribute from attempt
Andrew Nicols [Thu, 12 Jan 2023 04:09:11 +0000 (12:09 +0800)]
Merge branch 'MDL-76820-master' of https://github.com/cameron1729/moodle
Jun Pataleta [Thu, 12 Jan 2023 04:06:35 +0000 (12:06 +0800)]
Merge branch 'MDL-76649' of https://github.com/timhunt/moodle
Jun Pataleta [Thu, 12 Jan 2023 03:55:29 +0000 (11:55 +0800)]
Merge branch 'MDL-76474-master-2' of https://github.com/HuongNV13/moodle
Huong Nguyen [Wed, 4 Jan 2023 05:01:11 +0000 (12:01 +0700)]
MDL-76474 tiny_h5p: Prevent H5P Formatter placeholder to be assessed
Huong Nguyen [Wed, 4 Jan 2023 04:52:43 +0000 (11:52 +0700)]
MDL-76474 tiny_accessibilitychecker: Prevent placeholders to be assessed
Huong Nguyen [Wed, 4 Jan 2023 03:54:04 +0000 (10:54 +0700)]
MDL-76474 editor_tiny: Implement placeholder selector list
We created a list of placeholder selectors in placeholderSelectors option.
The purpose of this list is to indicate the contents that are only shown
in the editor and not to the users, by that way, we can decide to apply or
not to apply rules, styles, etc... to these contents
Michael Hawkins [Wed, 11 Jan 2023 17:59:42 +0000 (01:59 +0800)]
MDL-76861 blog: Ensure correct escaping applied to search string
Jake Dallimore [Thu, 12 Jan 2023 03:28:37 +0000 (11:28 +0800)]
MDL-76862 user: Unit test for setting user home page preferences
Paul Holden [Wed, 11 Jan 2023 22:40:49 +0000 (22:40 +0000)]
MDL-76862 user: ensure user can only update own preferred start page.
Andrew Nicols [Thu, 12 Jan 2023 02:56:33 +0000 (10:56 +0800)]
Merge branch 'MDL-76839' of https://github.com/paulholden/moodle
Cameron Ball [Thu, 12 Jan 2023 02:41:39 +0000 (10:41 +0800)]
MDL-76820 core_search: Reset manager::$coursedeleting between tests
Jun Pataleta [Thu, 12 Jan 2023 02:17:08 +0000 (10:17 +0800)]
Merge branch 'MDL-76739-master-test' of https://github.com/junpataleta/moodle
Jun Pataleta [Thu, 12 Jan 2023 01:26:18 +0000 (09:26 +0800)]
MDL-76739 behat: Replace occurrences of "surname" in Behat tests
Replace occurrences of "surname" in Behat tests with "last name"
David Mudrák [Mon, 9 Jan 2023 17:24:23 +0000 (18:24 +0100)]
MDL-76739 lang: Use the fixed strings in the tests, too
Helen Foster [Sun, 8 Jan 2023 20:36:41 +0000 (21:36 +0100)]
MDL-76739 lang: Import fixed English strings (en_fix)
Ilya Tregubov [Wed, 11 Jan 2023 12:11:49 +0000 (19:11 +0700)]
Merge branch 'MDL-76607-master' of https://github.com/davewoloszyn/moodle
Andrew Nicols [Wed, 11 Jan 2023 07:52:41 +0000 (15:52 +0800)]
Merge branch '66924-view-own-private-reply-master' of https://github.com/DSI-Universite-Rennes2/moodle
Tim Hunt [Fri, 6 Jan 2023 12:55:40 +0000 (12:55 +0000)]
MDL-76810 redirect handling: ensure return URLs are properly sanitised
Andrew Nicols [Wed, 11 Jan 2023 02:32:42 +0000 (10:32 +0800)]
Merge branch 'MDL-76614' of https://github.com/timhunt/moodle
Andrew Nicols [Wed, 11 Jan 2023 02:26:20 +0000 (10:26 +0800)]
Merge branch 'MDL-76356' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 11 Jan 2023 02:12:20 +0000 (10:12 +0800)]
Merge branch 'MDL-76597-master-2' of https://github.com/junpataleta/moodle
Paul Holden [Tue, 10 Jan 2023 16:40:05 +0000 (16:40 +0000)]
Merge branch 'MDL-76811-master' of https://github.com/andrewnicols/moodle
Paul Holden [Tue, 10 Jan 2023 16:24:09 +0000 (16:24 +0000)]
Merge branch 'MDL-76803-master' of https://github.com/junpataleta/moodle
Paul Holden [Tue, 10 Jan 2023 15:29:15 +0000 (15:29 +0000)]
Merge branch 'MDL-76653-master' of https://github.com/lameze/moodle
Marina Glancy [Thu, 17 Nov 2022 14:49:48 +0000 (15:49 +0100)]
MDL-76356 various: avoid implicit conversion to int
PHP before version 8.1 automatically converted to int if the function
parameter (or array key) is expected to be int. PHP 8.1 shows notice in
this case
Paul Holden [Tue, 10 Jan 2023 12:59:06 +0000 (12:59 +0000)]
MDL-76839 mod_data: correct external test class coverage notation.
Paul Holden [Tue, 10 Jan 2023 12:29:17 +0000 (12:29 +0000)]
Merge branch 'MDL-76833-master' of https://github.com/andrewnicols/moodle
Marina Glancy [Thu, 17 Nov 2022 14:44:35 +0000 (15:44 +0100)]
MDL-76356 various: avoid implicit conversion to arrays
PHP before version 8.1 automatically converted stdClass or 'false' to arrays if
function parameter expects array (for example, "reset").
PHP 8.1 shows notices in these situations
Jun Pataleta [Fri, 6 Jan 2023 03:02:33 +0000 (11:02 +0800)]
MDL-76803 lang: Update usages of reworded email display options
Andrew Nicols [Tue, 10 Jan 2023 04:09:00 +0000 (12:09 +0800)]
MDL-76833 core: Bump phpunit/php-code-coverage version
This includes a bug fix for a display issue with code coverage reporting
in phpunit's HTML output report.
Andrew Nicols [Tue, 10 Jan 2023 03:19:02 +0000 (11:19 +0800)]
MDL-76811 mod_data: Remove duplicate tests
Andrew Nicols [Fri, 6 Jan 2023 04:51:21 +0000 (12:51 +0800)]
MDL-76811 mod_data: Stop testing template creation on field creation
The default template is no longer created when creating the fields with
the generator, so we should stop testing that it is.
Andrew Nicols [Tue, 10 Jan 2023 03:18:36 +0000 (11:18 +0800)]
MDL-76811 mod_data: Generator test cleanup
Jun Pataleta [Thu, 5 Jan 2023 15:55:54 +0000 (23:55 +0800)]
MDL-76803 lang: Make email display options more concise
Simey Lameze [Tue, 20 Dec 2022 08:34:02 +0000 (16:34 +0800)]
MDL-76653 behat: add coverage for SCORM availability
Jun Pataleta [Tue, 10 Jan 2023 01:41:37 +0000 (09:41 +0800)]
Merge branch 'MDL-76061-master' of https://github.com/PhMemmel/moodle
Tim Hunt [Mon, 9 Jan 2023 17:48:26 +0000 (17:48 +0000)]
fixup! MDL-76614 quiz: deprecate class moodle_quiz_exception
Philipp Memmel [Thu, 15 Dec 2022 19:09:05 +0000 (20:09 +0100)]
MDL-76061 core_calendar: Fix changing event type from 'user'
Julien Boulen [Mon, 9 Jan 2023 13:41:01 +0000 (14:41 +0100)]
MDL-66924 mod_forum: Allow users to see their own private messages
Allow users to see their own private messages even if they don't have
mod/forum:readprivatereplies capability
Add behat test to avoid MDL-67109 issue.
Co-authored-by: Martin Putzlocher <mputzi@users.noreply.github.com>
Tim Hunt [Mon, 12 Dec 2022 18:11:38 +0000 (18:11 +0000)]
MDL-76649 quiz statistics task: output more useful trace info
At the moment, quiz_statistics\task\recalculate gives no useful
information about what it is doing, which makes it hard to investigate
if the task fails. This commit makes it more usefully verbose.
Also, following this change, one instance of this task will not
run for more than one hour at a time.
As part of this commit, I have added a new helper mtrace_exception.
to consistently log exceptions in scheduled tasks. It is sad to
add a new function to moodlelib.php, but that seemed the logical place.
Looking at other tasks, this method is badly needed. Many are just
logging the ->getMessage() which is normaly insufficient for proper
debugging. However, swiching all existing tasks to use the new function
will need to wait for a future MDL.
Paul Holden [Mon, 9 Jan 2023 11:50:58 +0000 (11:50 +0000)]
Merge branch 'MDL-75532-master' of https://github.com/snake/moodle
Jun Pataleta [Mon, 9 Jan 2023 11:38:36 +0000 (19:38 +0800)]
Merge branch 'MDL-76785' of https://github.com/paulholden/moodle
Jun Pataleta [Mon, 9 Jan 2023 11:34:07 +0000 (19:34 +0800)]
Merge branch 'MDL-76506' of https://github.com/jrchamp/moodle
Paul Holden [Tue, 3 Jan 2023 21:08:18 +0000 (21:08 +0000)]
MDL-76785 tiny_media: define video width/height language strings.
AMOS BEGIN
CPY [videoheight,atto_media],[videoheight,tiny_media]
CPY [videowidth,atto_media],[videowidth,tiny_media]
AMOS END
Jun Pataleta [Mon, 9 Jan 2023 10:39:32 +0000 (18:39 +0800)]
Merge branch 'MDL-76787' of https://github.com/paulholden/moodle
Paul Holden [Mon, 9 Jan 2023 10:11:11 +0000 (10:11 +0000)]
Merge branch 'MDL-76601-master' of https://github.com/junpataleta/moodle
Jun Pataleta [Mon, 9 Jan 2023 09:46:29 +0000 (17:46 +0800)]
Merge branch 'MDL-76812' of https://github.com/paulholden/moodle
Jun Pataleta [Mon, 9 Jan 2023 07:41:27 +0000 (15:41 +0800)]
MDL-76597 mod_quiz: Add a default heading name for Behat tests
Ilya Tregubov [Mon, 9 Jan 2023 07:39:28 +0000 (14:39 +0700)]
Merge branch 'MDL-76134-abstract' of https://github.com/Chocolate-lightning/moodle
Jake Dallimore [Fri, 19 Aug 2022 04:24:40 +0000 (12:24 +0800)]
MDL-75532 enrol_lti: fix optional lineitemsurl in grade sync task
As in MDL-74691, we need either or both of these fields, meaning either
one could be omitted. This just supports that as per the fix made in
MDL-74691.
Jake Dallimore [Fri, 19 Aug 2022 04:21:52 +0000 (12:21 +0800)]
MDL-75532 enrol_lti: add tests for coupled and decoupled line items
This covers the following cases:
1. Where only the 'lineitem' service endpoint is provided
2. Where only the 'lineitems' service endpoint is provided.
Existing tests already cover the case where both are provided.
Mathew May [Fri, 25 Nov 2022 01:22:22 +0000 (09:22 +0800)]
MDL-76134 gradebook: Modify user story behat tests into passable runs
Mathew May [Thu, 24 Nov 2022 08:08:39 +0000 (16:08 +0800)]
MDL-76134 gradebook: Hook into tertiary dropdown item
Mathew May [Thu, 24 Nov 2022 08:07:40 +0000 (16:07 +0800)]
MDL-76134 gradebook: Add a bare dropdown component
Mathew May [Thu, 24 Nov 2022 04:59:54 +0000 (12:59 +0800)]
MDL-76134 core: Provide a option to render initials bars smaller
Mathew May [Wed, 9 Nov 2022 04:10:23 +0000 (12:10 +0800)]
MDL-76134 core: User story behat test