moodle.git
2 years agoMDL-78151 core: account for timezone differences in intl extension. d5ec3594cc3cf1d39218181c4e2327dd4973bf58
Paul Holden [Tue, 9 May 2023 10:23:32 +0000 (11:23 +0100)]
MDL-78151 core: account for timezone differences in intl extension.

Recent additions to timezones from the IANA TZDB are not necessarily
reflected in those used by the intl extension and/or ICU zones:

 * America/Ciudad_Juarez
 * America/Nuuk
 * Europe/Kyiv
 * Pacific/Kanton

Create mapping to allow these zones to be used without errors.

2 years agoweekly release 4.2+
Sara Arjona [Thu, 4 May 2023 10:42:42 +0000 (12:42 +0200)]
weekly release 4.2+

2 years agoMDL-78054 airnotifier: Fix data encrypted several times
Dani Palou [Thu, 27 Apr 2023 12:44:43 +0000 (14:44 +0200)]
MDL-78054 airnotifier: Fix data encrypted several times

2 years agoMerge branch 'MDL-78002_402' of https://github.com/stronk7/moodle into MOODLE_402_STABLE
Jake Dallimore [Thu, 4 May 2023 02:08:09 +0000 (10:08 +0800)]
Merge branch 'MDL-78002_402' of https://github.com/stronk7/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78094-402' of https://github.com/snake/moodle into MOODLE_402_STABLE
Ilya Tregubov [Thu, 4 May 2023 00:54:07 +0000 (08:54 +0800)]
Merge branch 'MDL-78094-402' of https://github.com/snake/moodle into MOODLE_402_STABLE

2 years agoMDL-77781 core_completion: Completion view must be deleted too
Laurent David [Thu, 20 Apr 2023 05:28:54 +0000 (07:28 +0200)]
MDL-77781 core_completion: Completion view must be deleted too

When resetting a course, completion view entries should also be
deleted

Co-authored-by: Georg Moser <georg@moser.link>
2 years agoMerge branch 'MDL-77398-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jun Pataleta [Wed, 3 May 2023 12:36:28 +0000 (20:36 +0800)]
Merge branch 'MDL-77398-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77384-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jake Dallimore [Wed, 3 May 2023 08:52:21 +0000 (16:52 +0800)]
Merge branch 'MDL-77384-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78023-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jake Dallimore [Wed, 3 May 2023 08:15:42 +0000 (16:15 +0800)]
Merge branch 'MDL-78023-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77312-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Sara Arjona [Wed, 3 May 2023 07:59:17 +0000 (09:59 +0200)]
Merge branch 'MDL-77312-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78049-MOODLE_402_STABLE' of https://github.com/PhMemmel/moodle...
Sara Arjona [Wed, 3 May 2023 07:45:16 +0000 (09:45 +0200)]
Merge branch 'MDL-78049-MOODLE_402_STABLE' of https://github.com/PhMemmel/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77320-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Ilya Tregubov [Wed, 3 May 2023 07:36:34 +0000 (15:36 +0800)]
Merge branch 'MDL-77320-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch '42_MDL-78057' of https://github.com/danmarsden/moodle into MOODLE_402_S...
Sara Arjona [Wed, 3 May 2023 07:22:39 +0000 (09:22 +0200)]
Merge branch '42_MDL-78057' of https://github.com/danmarsden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-76971-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Sara Arjona [Wed, 3 May 2023 07:18:23 +0000 (09:18 +0200)]
Merge branch 'MDL-76971-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78006-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Sara Arjona [Wed, 3 May 2023 07:04:35 +0000 (09:04 +0200)]
Merge branch 'MDL-78006-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77810-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Ilya Tregubov [Wed, 3 May 2023 05:08:32 +0000 (13:08 +0800)]
Merge branch 'MDL-77810-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77987_402' of https://github.com/AnupamaSarjoshi/moodle into MOODLE...
Ilya Tregubov [Wed, 3 May 2023 04:40:12 +0000 (12:40 +0800)]
Merge branch 'MDL-77987_402' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78052-402' of https://github.com/sarjona/moodle into MOODLE_402_STABLE
Jake Dallimore [Wed, 3 May 2023 04:06:45 +0000 (12:06 +0800)]
Merge branch 'MDL-78052-402' of https://github.com/sarjona/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77546-402' of https://github.com/mihailges/moodle into MOODLE_402_S...
Ilya Tregubov [Wed, 3 May 2023 02:57:05 +0000 (10:57 +0800)]
Merge branch 'MDL-77546-402' of https://github.com/mihailges/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77394-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jun Pataleta [Wed, 3 May 2023 02:31:07 +0000 (10:31 +0800)]
Merge branch 'MDL-77394-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78038-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jun Pataleta [Wed, 3 May 2023 02:25:37 +0000 (10:25 +0800)]
Merge branch 'MDL-78038-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77936-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Ilya Tregubov [Wed, 3 May 2023 02:07:40 +0000 (10:07 +0800)]
Merge branch 'MDL-77936-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78011-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Jun Pataleta [Wed, 3 May 2023 01:58:10 +0000 (09:58 +0800)]
Merge branch 'MDL-78011-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMDL-78094 webservice_soap: fix use of core_external in locallib
Jake Dallimore [Wed, 3 May 2023 01:41:50 +0000 (09:41 +0800)]
MDL-78094 webservice_soap: fix use of core_external in locallib

2 years agoMerge branch 'MDL-76835-402' of https://github.com/aya-saad1/moodle into MOODLE_402_S...
Ilya Tregubov [Wed, 3 May 2023 01:29:32 +0000 (09:29 +0800)]
Merge branch 'MDL-76835-402' of https://github.com/aya-saad1/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77858-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Sara Arjona [Tue, 2 May 2023 14:49:48 +0000 (16:49 +0200)]
Merge branch 'MDL-77858-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-77791_402' of https://github.com/dvdcastro/moodle into MOODLE_402_S...
Sara Arjona [Tue, 2 May 2023 10:03:53 +0000 (12:03 +0200)]
Merge branch 'MDL-77791_402' of https://github.com/dvdcastro/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-76857-402' of https://github.com/sarjona/moodle into MOODLE_402_STABLE
Jun Pataleta [Tue, 2 May 2023 07:45:09 +0000 (15:45 +0800)]
Merge branch 'MDL-76857-402' of https://github.com/sarjona/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78025_402' of https://github.com/timhunt/moodle into MOODLE_402_STABLE
Ilya Tregubov [Tue, 2 May 2023 03:43:12 +0000 (11:43 +0800)]
Merge branch 'MDL-78025_402' of https://github.com/timhunt/moodle into MOODLE_402_STABLE

2 years agoMDL-78057 core_user: Use correct class for context check.
Dan Marsden [Fri, 28 Apr 2023 01:15:56 +0000 (13:15 +1200)]
MDL-78057 core_user: Use correct class for context check.

2 years agoMDL-78002 phpunit: Ensure that all uses of psr streams are closed
Eloy Lafuente (stronk7) [Sat, 29 Apr 2023 18:20:56 +0000 (20:20 +0200)]
MDL-78002 phpunit: Ensure that all uses of psr streams are closed

While the uses here were not causing too much problem with PHPUnit
execution in any OS, better have them explicitly closed to better
serve as reference for other, future uses anywhere in codebase.

Always that a stream is used, better we close it as soon as possible,
not relying on destructors, gc and friends.

2 years agoMDL-78002 moodlenet: Always close the request stream explicitly
Eloy Lafuente (stronk7) [Sat, 29 Apr 2023 17:27:36 +0000 (19:27 +0200)]
MDL-78002 moodlenet: Always close the request stream explicitly

And do it as soon as it's not needed any more. Else, only
_destruct() / shutdown / gc will, and that can be problematic
if many streams are open, or, under some environments like
Windows that consider the stream underlying files still busy,
because they have not been closed.

2 years agoMDL-77810 gradereport_summary: show localised plugin name in report.
Paul Holden [Mon, 3 Apr 2023 09:09:21 +0000 (10:09 +0100)]
MDL-77810 gradereport_summary: show localised plugin name in report.

2 years agoweekly release 4.2+
Ilya Tregubov [Thu, 27 Apr 2023 11:28:33 +0000 (19:28 +0800)]
weekly release 4.2+

2 years agoMDL-78052 lib: Set Moodle files after Font Awesome upgrade
Sara Arjona [Thu, 27 Apr 2023 11:11:58 +0000 (13:11 +0200)]
MDL-78052 lib: Set Moodle files after Font Awesome upgrade

2 years agoMDL-78052 theme: Update FontAwesome to 6.4.0
Sara Arjona [Thu, 27 Apr 2023 10:51:23 +0000 (12:51 +0200)]
MDL-78052 theme: Update FontAwesome to 6.4.0

This version also fixes a regression in 6.3.0 where a number of
icons weren't centered properly in their viewboxes.

2 years agoMDL-76857 filter_displayh5p: Improve behat tests
Sara Arjona [Fri, 14 Apr 2023 10:20:32 +0000 (12:20 +0200)]
MDL-76857 filter_displayh5p: Improve behat tests

Although the screenshots in the failures for some of the scenarios in
filter/displayh5p/tests/behat/h5p_filter.feature, like "Render a local
H5P file as teacher" were displaying the expected result, there were
some javascript errors (probably due to behat is quicker and the
iframes were not always ready).
I've added one extra step before accessing the iframe to give more
time to the H5P player to load and confirm the page is displayed
properly.

2 years agoMDL-77320 tool_licensemanager: restrict exposure of user sesskey.
Paul Holden [Mon, 20 Feb 2023 12:41:18 +0000 (12:41 +0000)]
MDL-77320 tool_licensemanager: restrict exposure of user sesskey.

2 years agoMDL-77936 grade: omit second cell action divider when not required.
Paul Holden [Mon, 17 Apr 2023 10:22:57 +0000 (11:22 +0100)]
MDL-77936 grade: omit second cell action divider when not required.

2 years agoMDL-78049 core_external: Run test_all_external_info in separate process
Philipp Memmel [Thu, 27 Apr 2023 06:30:57 +0000 (08:30 +0200)]
MDL-78049 core_external: Run test_all_external_info in separate process

2 years agoMDL-77546 gradereport_singleview: Fix item order in grade item selector
Mihail Geshoski [Wed, 26 Apr 2023 08:15:39 +0000 (16:15 +0800)]
MDL-77546 gradereport_singleview: Fix item order in grade item selector

2 years agoMDL-77883 forms: fix display of client-side validation for textareas
danghieu1407 [Mon, 24 Apr 2023 06:14:08 +0000 (13:14 +0700)]
MDL-77883 forms: fix display of client-side validation for textareas

2 years agoMerge branch 'MDL-77997_402' of https://github.com/timhunt/moodle into MOODLE_402_STABLE
Jun Pataleta [Thu, 27 Apr 2023 02:40:49 +0000 (10:40 +0800)]
Merge branch 'MDL-77997_402' of https://github.com/timhunt/moodle into MOODLE_402_STABLE

2 years agoMDL-78038 mod_bigbluebuttonbn: observe course format section config.
Paul Holden [Tue, 3 Jan 2023 17:34:01 +0000 (17:34 +0000)]
MDL-78038 mod_bigbluebuttonbn: observe course format section config.

2 years agoMDL-78025 questions: improve the comment on question_references.version
Tim Hunt [Wed, 26 Apr 2023 14:26:08 +0000 (15:26 +0100)]
MDL-78025 questions: improve the comment on question_references.version

2 years agoMDL-78025 questions: fix PHPdoc on question_require_capability_on
Tim Hunt [Wed, 26 Apr 2023 09:46:44 +0000 (10:46 +0100)]
MDL-78025 questions: fix PHPdoc on question_require_capability_on

2 years agoMDL-78025 quiz: fix the quiz_questions_in_use logic
Tim Hunt [Tue, 25 Apr 2023 17:11:57 +0000 (18:11 +0100)]
MDL-78025 quiz: fix the quiz_questions_in_use logic

2 years agoMDL-78025 questions: questions_in_use should check question_references
Tim Hunt [Tue, 25 Apr 2023 17:04:11 +0000 (18:04 +0100)]
MDL-78025 questions: questions_in_use should check question_references

This avoids the needs for plugins to do separate queries, which is
easier for them, and better performing.

2 years agoMDL-78025 question generator: make the behaviour less surprising
Tim Hunt [Tue, 25 Apr 2023 16:58:58 +0000 (17:58 +0100)]
MDL-78025 question generator: make the behaviour less surprising

* The object returned by update_question is alwasy a new clone
  and the $question passed in will not be modified.

* The returned object has the fields like questionbankentryid and
  the ones related to versionning, so it is more like the data
  returned by question_bank::load_question_data.

2 years agoMDL-78025 question: move hiding logic into question_delete_question
Tim Hunt [Wed, 26 Apr 2023 09:42:11 +0000 (10:42 +0100)]
MDL-78025 question: move hiding logic into question_delete_question

This logic belongs in the API, so it is applied consistently.

Also this avoids calling the expensive function questions_in_use
twice per question.

2 years agoMDL-76835 theme: Fix unordered lists indentation
Aya Saad [Wed, 26 Apr 2023 12:01:47 +0000 (14:01 +0200)]
MDL-76835 theme: Fix unordered lists indentation

2 years agoMerge branch 'MDL-76929-402' of https://github.com/ilyatregubov/moodle into MOODLE_40...
Ilya Tregubov [Wed, 26 Apr 2023 01:28:52 +0000 (09:28 +0800)]
Merge branch 'MDL-76929-402' of https://github.com/ilyatregubov/moodle into MOODLE_402_STABLE

2 years agoMDL-76929 Libraries: Upgrade phpxmlrpc to 4.10.1
Matt Porritt [Thu, 2 Mar 2023 07:25:52 +0000 (18:25 +1100)]
MDL-76929 Libraries: Upgrade phpxmlrpc to 4.10.1

2 years agoMDL-77791 data: Fix file attachment to search doc
David Castro [Thu, 13 Apr 2023 19:03:38 +0000 (14:03 -0500)]
MDL-77791 data: Fix file attachment to search doc

2 years agoMDL-78023 tool_policy: cast timemodified column on table download.
Paul Holden [Tue, 25 Apr 2023 13:48:38 +0000 (14:48 +0100)]
MDL-78023 tool_policy: cast timemodified column on table download.

2 years agoMerge branch 'MDL-77313-402' of https://github.com/paulholden/moodle into MOODLE_402_...
Sara Arjona [Tue, 25 Apr 2023 13:18:35 +0000 (15:18 +0200)]
Merge branch 'MDL-77313-402' of https://github.com/paulholden/moodle into MOODLE_402_STABLE

2 years agoMerge branch 'MDL-78007-402' of https://github.com/HuongNV13/moodle into MOODLE_402_S...
Paul Holden [Tue, 25 Apr 2023 11:36:08 +0000 (12:36 +0100)]
Merge branch 'MDL-78007-402' of https://github.com/HuongNV13/moodle into MOODLE_402_STABLE

2 years agoMDL-73331 tool_brickfield: Update advanced tab display
Max Larkin [Wed, 8 Dec 2021 11:42:23 +0000 (11:42 +0000)]
MDL-73331 tool_brickfield: Update advanced tab display

2 years agoMerge branch 'MDL-77766-402-2' of https://github.com/junpataleta/moodle into MOODLE_4...
Paul Holden [Tue, 25 Apr 2023 08:38:36 +0000 (09:38 +0100)]
Merge branch 'MDL-77766-402-2' of https://github.com/junpataleta/moodle into MOODLE_402_STABLE

2 years agoMDL-77987 Backup: add progress tracking to some slow steps
Anupama Sarjoshi [Thu, 20 Apr 2023 17:22:03 +0000 (18:22 +0100)]
MDL-77987 Backup: add progress tracking to some slow steps

2 years agoMDL-77384 check: clarify statistics check name.
Paul Holden [Thu, 23 Feb 2023 10:47:55 +0000 (10:47 +0000)]
MDL-77384 check: clarify statistics check name.

2 years agoMDL-76971 reportbuilder: switch remaining classes to external_api.
Paul Holden [Fri, 20 Jan 2023 11:05:15 +0000 (11:05 +0000)]
MDL-76971 reportbuilder: switch remaining classes to external_api.

Continues on the work started in a3cc26f8, to remove the last
remnants of usage of previous external API classes.

2 years agoMDL-78011 qbank_managecategories: require library for pagesize const.
Paul Holden [Mon, 24 Apr 2023 14:34:23 +0000 (15:34 +0100)]
MDL-78011 qbank_managecategories: require library for pagesize const.

2 years agoMDL-77766 qtype_truefalse: Respect showstandardinstruction
Jun Pataleta [Mon, 24 Apr 2023 12:07:57 +0000 (20:07 +0800)]
MDL-77766 qtype_truefalse: Respect showstandardinstruction

* When showstandardinstruction is set to no, replace the standard
instruction with the generic "Answer" text for the answer options
fieldset's legend.

2 years agoMDL-77766 qtype_multichoice: Respect showstandardinstruction
Jun Pataleta [Mon, 24 Apr 2023 12:07:38 +0000 (20:07 +0800)]
MDL-77766 qtype_multichoice: Respect showstandardinstruction

* When showstandardinstruction is set to no, replace the standard
instruction with the generic "Answer" text for the answer options
fieldset's legend.

2 years agoMDL-78006 course: test for adding activity in a new section
Marina Glancy [Sun, 23 Apr 2023 19:53:03 +0000 (20:53 +0100)]
MDL-78006 course: test for adding activity in a new section

2 years agoMDL-78006 course: register activity chooser listeners just once.
Paul Holden [Mon, 24 Apr 2023 10:39:18 +0000 (11:39 +0100)]
MDL-78006 course: register activity chooser listeners just once.

2 years agoMDL-77997 questions: add back Export as XML to the preview screen
Tim Hunt [Fri, 21 Apr 2023 17:39:44 +0000 (18:39 +0100)]
MDL-77997 questions: add back Export as XML to the preview screen

The used the exist in Moodle up to 3.11, but then was removed with
insufficient thought in 4.0 (because we had grander long-term plans
which still have not happened). Until those plans happen, this
commit adds the simple link back on the preview screen.

2 years agoMDL-77312 files: exclude drafts when determining license usage.
Paul Holden [Mon, 20 Feb 2023 14:40:58 +0000 (14:40 +0000)]
MDL-77312 files: exclude drafts when determining license usage.

2 years agoMDL-77313 restore: re-add field to indicate course/category search.
Paul Holden [Tue, 21 Feb 2023 12:12:16 +0000 (12:12 +0000)]
MDL-77313 restore: re-add field to indicate course/category search.

When the two restore forms for searching courses and categories were
converted to core templates in eb9935c9 they lost the named submit
button, which broke searching.

2 years agoMDL-77858 javascript: correct `core/notification` exception imports.
Paul Holden [Wed, 5 Apr 2023 17:57:57 +0000 (18:57 +0100)]
MDL-77858 javascript: correct `core/notification` exception imports.

2 years agoMDL-77394 mod_forum: de-couple discussion pinned/starred options.
Paul Holden [Tue, 28 Feb 2023 09:43:51 +0000 (09:43 +0000)]
MDL-77394 mod_forum: de-couple discussion pinned/starred options.

2 years agoMDL-77398 mod_assign: disable form submit protection for batch options.
Paul Holden [Fri, 24 Feb 2023 09:19:53 +0000 (09:19 +0000)]
MDL-77398 mod_assign: disable form submit protection for batch options.

2 years agoMDL-78007 tiny_media: Fix wrong condition for the Tiny Media
Huong Nguyen [Mon, 24 Apr 2023 08:53:37 +0000 (15:53 +0700)]
MDL-78007 tiny_media: Fix wrong condition for the Tiny Media

Including in this commit:
 - Switched to Tiny editor in manually_mark_question.feature

2 years agoMDL-78000 upgrade: add the 4.2.0 separation line to all upgrade scripts
Jun Pataleta [Sat, 22 Apr 2023 15:17:17 +0000 (23:17 +0800)]
MDL-78000 upgrade: add the 4.2.0 separation line to all upgrade scripts

2 years agoMoodle release 4.2 v4.2.0
Jun Pataleta [Sat, 22 Apr 2023 09:06:54 +0000 (17:06 +0800)]
Moodle release 4.2

2 years agoMoodle release 4.2rc2 v4.2.0-rc2
Eloy Lafuente (stronk7) [Fri, 21 Apr 2023 17:19:59 +0000 (19:19 +0200)]
Moodle release 4.2rc2

2 years agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Fri, 21 Apr 2023 17:19:53 +0000 (19:19 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

2 years agoMerge branch 'MDL-77889-integration-master-fix' of https://github.com/mihailges/moodle
Jake Dallimore [Fri, 21 Apr 2023 09:15:26 +0000 (17:15 +0800)]
Merge branch 'MDL-77889-integration-master-fix' of https://github.com/mihailges/moodle

2 years agoMDL-77889 gradebook: Tighten up backward compatibility checks
Mihail Geshoski [Fri, 21 Apr 2023 08:53:47 +0000 (16:53 +0800)]
MDL-77889 gradebook: Tighten up backward compatibility checks

2 years agoMerge branch 'MDL-77229-patch' of https://github.com/ilyatregubov/moodle
Jun Pataleta [Fri, 21 Apr 2023 08:44:22 +0000 (16:44 +0800)]
Merge branch 'MDL-77229-patch' of https://github.com/ilyatregubov/moodle

2 years agoMDL-77229 mod_lesson: Black list detailed statistics in classic Behat.
Ilya Tregubov [Fri, 21 Apr 2023 07:03:02 +0000 (15:03 +0800)]
MDL-77229 mod_lesson: Black list detailed statistics in classic Behat.

The nav element to go to detailed stats page is missing in classic

2 years agoMDL-77889 gradereport: restore backwards compatibility in searchwidget
Shamim Rezaie [Wed, 19 Apr 2023 11:20:40 +0000 (21:20 +1000)]
MDL-77889 gradereport: restore backwards compatibility in searchwidget

The widgetbase module was intended to be a generic search widget,
despite its location in grade/amd/src. As such, other modules may
depend on this. This was modified in MDL-76246, which added new
requires params to the js, and changed the js to expect certain new
data attributes in the templates. This broke b/c for existing
dependents.

This patch makes sure the existing uses of the basewidget continue
to work by adding b/c code. See MDL-77991 which deals with deprecating
this search widget and replacing it with one that just implements the
desired combobox logic, without the b/c code. That issue should also
make it abundantly clear that this widget is for public consumption.

2 years agoMerge branch 'MDL-77989-master' of https://github.com/andrewnicols/moodle
Jun Pataleta [Fri, 21 Apr 2023 05:44:51 +0000 (13:44 +0800)]
Merge branch 'MDL-77989-master' of https://github.com/andrewnicols/moodle

2 years agoMDL-77989 core: Fix uses of legacy external API
Andrew Nicols [Fri, 21 Apr 2023 02:26:48 +0000 (10:26 +0800)]
MDL-77989 core: Fix uses of legacy external API

2 years agoMDL-77989 testing: Add test file isolation helper
Andrew Nicols [Fri, 21 Apr 2023 02:11:18 +0000 (10:11 +0800)]
MDL-77989 testing: Add test file isolation helper

When we deprecate the use of a file, we often include tests which ensure
that the legacy behaviour is maintained. There are also legacy uses
in the community where people would like to use the deprecated API for a
period.

The issue that we face is that, if the deprecated file is included once,
then it will be included for all other, unrelated, tests. This means
that other tests may not detect cases where the deprecated file was
included.

We can solve these cases by running the test that performs the inclusion
in a deprecated process. This means that the inclusion is only performed
in that isolated process, and other unrelated tests do not include the
file.

However, we also then need to detect which files which are including the
file and which we do not know about.

This change introduces:
- an override to the TestCase::setInIsolation method to define a
  constant when the test is running in isolation
- a new function that a file can call when it is included, to make sure
  that the test process was isolated, where there is any test.

2 years agoMerge branch 'MDL-77903' of https://github.com/Chocolate-lightning/moodle
Ilya Tregubov [Fri, 21 Apr 2023 05:18:14 +0000 (13:18 +0800)]
Merge branch 'MDL-77903' of https://github.com/Chocolate-lightning/moodle

2 years agoMerge branch 'MDL-77927-master' of https://github.com/stevandoMoodle/moodle
Jun Pataleta [Fri, 21 Apr 2023 05:11:43 +0000 (13:11 +0800)]
Merge branch 'MDL-77927-master' of https://github.com/stevandoMoodle/moodle

2 years agoMDL-77903 gradereport_grader: Keyboard accessibility
Mathew May [Wed, 19 Apr 2023 02:16:04 +0000 (10:16 +0800)]
MDL-77903 gradereport_grader: Keyboard accessibility

2 years agoMDL-77927 core: Delete other mod_assignment subplugins
Jun Pataleta [Thu, 20 Apr 2023 23:39:17 +0000 (07:39 +0800)]
MDL-77927 core: Delete other mod_assignment subplugins

Non-core mod_assignment subplugin data may still be present on the
database. We need to make sure to remove these too during upgrade.

2 years agoMDL-77927 core: mod_assignment subplugins environment check
Jun Pataleta [Thu, 20 Apr 2023 15:30:45 +0000 (23:30 +0800)]
MDL-77927 core: mod_assignment subplugins environment check

2 years agoMDL-77927 core: Move assignment removal upgrade code
Jun Pataleta [Thu, 20 Apr 2023 12:34:06 +0000 (20:34 +0800)]
MDL-77927 core: Move assignment removal upgrade code

Move the fixed assignment removal upgrade code to the end of the upgrade
script as a new upgrade step. Already upgraded sites with mod_assignment
removed should just be able to rerun this without any issues.

2 years agoMDL-77927 grade: Delete mod_assignment orphaned data before its removal
Stevani Andolo [Thu, 20 Apr 2023 04:22:01 +0000 (12:22 +0800)]
MDL-77927 grade: Delete mod_assignment orphaned data before its removal

2 years agoMerge branch 'MDL-77229-master' of https://github.com/ilyatregubov/moodle
Ilya Tregubov [Fri, 21 Apr 2023 04:11:59 +0000 (12:11 +0800)]
Merge branch 'MDL-77229-master' of https://github.com/ilyatregubov/moodle

2 years agoMDL-77229 lesson: Add Behat test
Ilya Tregubov [Fri, 21 Apr 2023 03:59:27 +0000 (11:59 +0800)]
MDL-77229 lesson: Add Behat test

2 years agoMerge branch 'MDL-77849-master' of https://github.com/ilyatregubov/moodle
Andrew Nicols [Fri, 21 Apr 2023 03:31:22 +0000 (11:31 +0800)]
Merge branch 'MDL-77849-master' of https://github.com/ilyatregubov/moodle

2 years agoMerge branch 'MDL-77896' of https://github.com/paulholden/moodle
Jun Pataleta [Fri, 21 Apr 2023 03:21:40 +0000 (11:21 +0800)]
Merge branch 'MDL-77896' of https://github.com/paulholden/moodle

2 years agoMDL-77849 gradereport_grader: Align content in user identity cells
Mihail Geshoski [Thu, 20 Apr 2023 16:28:58 +0000 (00:28 +0800)]
MDL-77849 gradereport_grader: Align content in user identity cells

2 years agoMDL-77849 gradereport_grader: Align properly grade display types
Ilya Tregubov [Fri, 14 Apr 2023 06:42:24 +0000 (14:42 +0800)]
MDL-77849 gradereport_grader: Align properly grade display types

2 years agoMDL-77849 gradereport_grader: Make menus aligned with text
Ilya Tregubov [Thu, 13 Apr 2023 08:50:37 +0000 (16:50 +0800)]
MDL-77849 gradereport_grader: Make menus aligned with text