From b2cf2b807f7a7c8d1a02ebb52038c61cc63a1494 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Thu, 14 Jun 2012 10:52:59 +0800
Subject: [PATCH] MDL-33513 repositories - fix misleading phpdocs

---
 lib/boxlib.php                   | 5 ++---
 repository/flickr/lib.php        | 2 +-
 repository/flickr_public/lib.php | 2 +-
 repository/lib.php               | 4 ++--
 repository/s3/lib.php            | 4 ++--
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/lib/boxlib.php b/lib/boxlib.php
index 22250382f52..e1e8387516a 100644
--- a/lib/boxlib.php
+++ b/lib/boxlib.php
@@ -192,8 +192,7 @@ class boxclient {
      * Get box.net file info
      *
      * @param string $fileid
-     * @param array $params
-     * @return array|null
+     * @return string|null
      */
     function get_file_info($fileid) {
         $this->_clearErrors();
@@ -205,7 +204,7 @@ class boxclient {
         $http = new curl(array('debug'=>$this->debug, 'cache'=>true, 'module_cache'=>'repository'));
         $xml = $http->get($this->_box_api_url, $params);
         $o = simplexml_load_string(trim($xml));
-        if($o->status == 's_get_file_info') {
+        if ($o->status == 's_get_file_info') {
             return $o->info;
         } else {
             return null;
diff --git a/repository/flickr/lib.php b/repository/flickr/lib.php
index 368e8ec2bb8..688663899a3 100644
--- a/repository/flickr/lib.php
+++ b/repository/flickr/lib.php
@@ -318,7 +318,7 @@ class repository_flickr extends repository {
     /**
      * Return the source information
      *
-     * @param stdClass $url
+     * @param string $photoid
      * @return string|null
      */
     public function get_file_source_info($photoid) {
diff --git a/repository/flickr_public/lib.php b/repository/flickr_public/lib.php
index f10bd516ba9..4ec7939da5a 100644
--- a/repository/flickr_public/lib.php
+++ b/repository/flickr_public/lib.php
@@ -529,7 +529,7 @@ class repository_flickr_public extends repository {
     /**
      * Return the source information
      *
-     * @param stdClass $url
+     * @param string $photoid photo id
      * @return string|null
      */
     public function get_file_source_info($photoid) {
diff --git a/repository/lib.php b/repository/lib.php
index f7aa41aea81..446e4315dc9 100644
--- a/repository/lib.php
+++ b/repository/lib.php
@@ -2211,8 +2211,8 @@ abstract class repository {
      * File manager needs to know the original file information before copying
      * to draft area, so we append these information in mdl_files.source field
      *
-     * @param string $sourcefield
-     * @param string
+     * @param string $source
+     * @return string serialised source field
      */
     public static function build_source_field($source) {
         $sourcefield = new stdClass;
diff --git a/repository/s3/lib.php b/repository/s3/lib.php
index b5604c91f06..55586200c08 100644
--- a/repository/s3/lib.php
+++ b/repository/s3/lib.php
@@ -122,8 +122,8 @@ class repository_s3 extends repository {
     /**
      * Return the source information
      *
-     * @param stdClass $url
-     * @return string|null
+     * @param stdClass $filepath
+     * @return string
      */
     public function get_file_source_info($filepath) {
         return 'Amazon S3:' . $filepath;
-- 
2.43.0