From ba30b66e19188620bfe12dcbcf1cfe0e6849a928 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Mikel=20Mart=C3=ADn?= <mikel@moodle.com>
Date: Tue, 28 Jan 2025 08:53:56 +0100
Subject: [PATCH] MDL-75669 theme_boost: Fix list-group usages for BS5

- The .list-group-item elements in BS5 require an outer .list-group container.
  Some uses in core were missing the outer group item and need fixing.
---
 blocks/myoverview/templates/view-summary.mustache |  2 +-
 course/classes/management_renderer.php            | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/blocks/myoverview/templates/view-summary.mustache b/blocks/myoverview/templates/view-summary.mustache
index 55ff68452a9..7d7480528ab 100644
--- a/blocks/myoverview/templates/view-summary.mustache
+++ b/blocks/myoverview/templates/view-summary.mustache
@@ -36,7 +36,7 @@
         ]
     }
 }}
-<div role="list">
+<div class="list-group" role="list">
 {{#courses}}
     <div class="course-summaryitem list-group-item course-listitem border-start-0 border-end-0 border-top-0 px-2 rounded-0" role="listitem"
         data-region="course-content"
diff --git a/course/classes/management_renderer.php b/course/classes/management_renderer.php
index e4fb804893a..a9f8ecb520a 100644
--- a/course/classes/management_renderer.php
+++ b/course/classes/management_renderer.php
@@ -119,11 +119,11 @@ class core_course_management_renderer extends plugin_renderer_base {
 
         $listing = core_course_category::top()->get_children();
 
-        $attributes = array(
-                'class' => 'ms-1 list-unstyled',
-                'role' => 'tree',
-                'aria-labelledby' => 'category-listing-title'
-        );
+        $attributes = [
+            'class' => 'ms-1 list-unstyled list-group',
+            'role' => 'tree',
+            'aria-labelledby' => 'category-listing-title',
+        ];
 
         $html  = html_writer::start_div('category-listing card w-100');
         $html .= html_writer::tag('h3', get_string('categories'),
@@ -525,7 +525,7 @@ class core_course_management_renderer extends plugin_renderer_base {
         $html .= html_writer::start_div('card-body');
         $html .= $this->course_listing_actions($category, $course, $perpage);
         $html .= $this->listing_pagination($category, $page, $perpage, false, $viewmode);
-        $html .= html_writer::start_tag('ul', array('class' => 'ml course-list'));
+        $html .= html_writer::start_tag('ul', ['class' => 'course-list list-group', 'role' => 'list']);
         foreach ($category->get_courses($options) as $listitem) {
             $html .= $this->course_listitem($category, $listitem, $courseid);
         }
-- 
2.43.0