From c6bcbad07a7fd437991ee7a2a1a98973949fac43 Mon Sep 17 00:00:00 2001
From: Andrew Nicols <andrew@nicols.co.uk>
Date: Tue, 3 Feb 2015 13:21:40 +0800
Subject: [PATCH] MDL-48484 admin: Improve coding style

---
 lib/adminlib.php | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lib/adminlib.php b/lib/adminlib.php
index ecb240dee48..192b66b128a 100644
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -3231,18 +3231,20 @@ class admin_setting_configtime extends admin_setting {
             $defaultinfo = NULL;
         }
 
-        $return = '<div class="form-time defaultsnext">'.
-            '<label class="accesshide" for="' . $this->get_id().'h">' . get_string('hours') . '</label>' .
-            '<select id="'.$this->get_id().'h" name="'.$this->get_full_name().'[h]">';
+        $return  = '<div class="form-time defaultsnext">';
+        $return .= '<label class="accesshide" for="' . $this->get_id() . 'h">' . get_string('hours') . '</label>';
+        $return .= '<select id="' . $this->get_id() . 'h" name="' . $this->get_full_name() . '[h]">';
         for ($i = 0; $i < 24; $i++) {
-            $return .= '<option value="'.$i.'"'.($i == $data['h'] ? ' selected="selected"' : '').'>'.$i.'</option>';
+            $return .= '<option value="' . $i . '"' . ($i == $data['h'] ? ' selected="selected"' : '') . '>' . $i . '</option>';
         }
-        $return .= '</select>:<label class="accesshide" for="' . $this->get_id().'m">' . get_string('minutes');
-        $return .= '</label><select id="'.$this->get_id().'m" name="'.$this->get_full_name().'[m]">';
+        $return .= '</select>:';
+        $return .= '<label class="accesshide" for="' . $this->get_id() . 'm">' . get_string('minutes') . '</label>';
+        $return .= '<select id="' . $this->get_id() . 'm" name="' . $this->get_full_name() . '[m]">';
         for ($i = 0; $i < 60; $i += 5) {
-            $return .= '<option value="'.$i.'"'.($i == $data['m'] ? ' selected="selected"' : '').'>'.$i.'</option>';
+            $return .= '<option value="' . $i . '"' . ($i == $data['m'] ? ' selected="selected"' : '') . '>' . $i . '</option>';
         }
-        $return .= '</select></div>';
+        $return .= '</select>';
+        $return .= '</div>';
         return format_admin_setting($this, $this->visiblename, $return, $this->description,
             $this->get_id() . 'h', '', $defaultinfo, $query);
     }
-- 
2.43.0