Commit | Line | Data |
---|---|---|
6b7df0b5 EL |
1 | <?php |
2 | // This file is part of Moodle - http://moodle.org/ | |
3 | // | |
4 | // Moodle is free software: you can redistribute it and/or modify | |
5 | // it under the terms of the GNU General Public License as published by | |
6 | // the Free Software Foundation, either version 3 of the License, or | |
7 | // (at your option) any later version. | |
8 | // | |
9 | // Moodle is distributed in the hope that it will be useful, | |
10 | // but WITHOUT ANY WARRANTY; without even the implied warranty of | |
11 | // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
12 | // GNU General Public License for more details. | |
13 | // | |
14 | // You should have received a copy of the GNU General Public License | |
15 | // along with Moodle. If not, see <http://www.gnu.org/licenses/>. | |
16 | ||
17 | /** | |
f5700877 | 18 | * Unit tests for the lib/upgradelib.php library. |
6b7df0b5 EL |
19 | * |
20 | * @package core | |
21 | * @category phpunit | |
22 | * @copyright 2013 onwards Eloy Lafuente (stronk7) {@link http://stronk7.com} | |
23 | * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | |
24 | */ | |
25 | ||
26 | defined('MOODLE_INTERNAL') || die(); | |
27 | ||
28 | global $CFG; | |
29 | require_once($CFG->libdir.'/upgradelib.php'); | |
30 | ||
31 | ||
32 | /** | |
f5700877 | 33 | * Tests various classes and functions in upgradelib.php library. |
6b7df0b5 | 34 | */ |
f5700877 | 35 | class core_upgradelib_testcase extends advanced_testcase { |
6b7df0b5 EL |
36 | |
37 | /** | |
38 | * Test the {@link upgrade_stale_php_files_present() function | |
39 | */ | |
40 | public function test_upgrade_stale_php_files_present() { | |
41 | // Just call the function, must return bool false always | |
42 | // if there aren't any old files in the codebase. | |
43 | $this->assertFalse(upgrade_stale_php_files_present()); | |
44 | } | |
2a9d7a42 DP |
45 | |
46 | /** | |
47 | * Test the {@link upgrade_grade_item_fix_sortorder() function with | |
48 | * faked duplicate sortorder data. | |
49 | */ | |
50 | public function test_upgrade_grade_item_fix_sortorder() { | |
51 | global $DB; | |
52 | ||
53 | $this->resetAfterTest(true); | |
54 | ||
b35ef82f MG |
55 | // The purpose of this test is to make sure that after upgrade script |
56 | // there is no duplicates in the field grade_items.sortorder (for each course) | |
57 | // and the result of query "SELECT id FROM grade_items WHERE courseid=? ORDER BY sortorder, id" does not change. | |
58 | $sequencesql = 'SELECT id FROM {grade_items} WHERE courseid=? ORDER BY sortorder, id'; | |
59 | ||
60 | // Each set is used for filling the db with fake data and will be representing the result of query: | |
61 | // "SELECT sortorder from {grade_items} WHERE courseid=? ORDER BY id". | |
62 | $testsets = array( | |
63 | // Items that need no action. | |
64 | array(1,2,3), | |
65 | array(5,6,7), | |
66 | array(7,6,1,3,2,5), | |
67 | // Items with sortorder duplicates | |
68 | array(1,2,2,3,3,4,5), | |
69 | // Only one sortorder duplicate. | |
70 | array(1,1), | |
71 | array(3,3), | |
72 | // Non-sequential sortorders with one or multiple duplicates. | |
73 | array(3,3,7,5,6,6,9,10,8,3), | |
74 | array(7,7,3), | |
75 | array(3,4,5,3,5,4,7,1) | |
76 | ); | |
77 | $origsequences = array(); | |
78 | ||
79 | // Generate the data and remember the initial sequence or items. | |
80 | foreach ($testsets as $testset) { | |
81 | $course = $this->getDataGenerator()->create_course(); | |
82 | foreach ($testset as $sortorder) { | |
83 | $this->insert_fake_grade_item_sortorder($course->id, $sortorder); | |
84 | } | |
85 | $DB->get_records('grade_items'); | |
86 | $origsequences[$course->id] = $DB->get_fieldset_sql($sequencesql, array($course->id)); | |
87 | } | |
2a9d7a42 DP |
88 | |
89 | $duplicatedetectionsql = "SELECT courseid, sortorder | |
90 | FROM {grade_items} | |
91 | GROUP BY courseid, sortorder | |
92 | HAVING COUNT(id) > 1"; | |
93 | ||
94 | // Verify there are duplicates before we start the fix. | |
95 | $dupes = $DB->record_exists_sql($duplicatedetectionsql); | |
96 | $this->assertTrue($dupes); | |
97 | ||
98 | // Do the work. | |
99 | upgrade_grade_item_fix_sortorder(); | |
100 | ||
101 | // Verify that no duplicates are left in the database. | |
102 | $dupes = $DB->record_exists_sql($duplicatedetectionsql); | |
103 | $this->assertFalse($dupes); | |
104 | ||
b35ef82f MG |
105 | // Verify that sequences are exactly the same as they were before upgrade script. |
106 | $idx = 0; | |
107 | foreach ($origsequences as $courseid => $origsequence) { | |
108 | if (count(($testsets[$idx])) == count(array_unique($testsets[$idx]))) { | |
109 | // If there were no duplicates for this course verify that sortorders are not modified. | |
110 | $newsortorders = $DB->get_fieldset_sql("SELECT sortorder from {grade_items} WHERE courseid=? ORDER BY id", array($courseid)); | |
111 | $this->assertEquals($testsets[$idx], $newsortorders); | |
112 | } | |
113 | $newsequence = $DB->get_fieldset_sql($sequencesql, array($courseid)); | |
114 | $this->assertEquals($origsequence, $newsequence, | |
115 | "Sequences do not match for test set $idx : ".join(',', $testsets[$idx])); | |
116 | $idx++; | |
2a9d7a42 DP |
117 | } |
118 | } | |
119 | ||
120 | /** | |
121 | * Populate some fake grade items into the database with specified | |
122 | * sortorder and course id. | |
123 | * | |
124 | * NOTE: This function doesn't make much attempt to respect the | |
125 | * gradebook internals, its simply used to fake some data for | |
126 | * testing the upgradelib function. Please don't use it for other | |
127 | * purposes. | |
128 | * | |
129 | * @param int $courseid id of course | |
130 | * @param int $sortorder numeric sorting order of item | |
131 | * @return stdClass grade item object from the database. | |
132 | */ | |
133 | private function insert_fake_grade_item_sortorder($courseid, $sortorder) { | |
134 | global $DB, $CFG; | |
135 | require_once($CFG->libdir.'/gradelib.php'); | |
136 | ||
137 | $item = new stdClass(); | |
138 | $item->courseid = $courseid; | |
139 | $item->sortorder = $sortorder; | |
140 | $item->gradetype = GRADE_TYPE_VALUE; | |
141 | $item->grademin = 30; | |
142 | $item->grademax = 110; | |
143 | $item->itemnumber = 1; | |
144 | $item->iteminfo = ''; | |
145 | $item->timecreated = time(); | |
146 | $item->timemodified = time(); | |
147 | ||
148 | $item->id = $DB->insert_record('grade_items', $item); | |
149 | ||
150 | return $DB->get_record('grade_items', array('id' => $item->id)); | |
151 | } | |
6b7df0b5 | 152 | } |