MDL-28687 questions avoid fatal errors when reviewing attempts at deleted questions.

[moodle.git] / lib / questionlib.php

diff --git a/lib/questionlib.php b/lib/questionlib.php
index fe52dfe..446fa95 100644 (file)
--- a/lib/questionlib.php
+++ b/lib/questionlib.php
@@ -1343,6 +1343,11 @@ function question_has_capability_on($question, $cap, $cachecat = -1) {
         }
         $question = $questions[$question];
     }
         }
         $question = $questions[$question];
     }

+    if (empty($question->category)) {
+        // This can happen when we have created a fake 'missingtype' question to
+        // take the place of a deleted question.
+        return false;
+    }

     if (!isset($categories[$question->category])) {
         if (!$categories[$question->category] = $DB->get_record('question_categories',
                 array('id'=>$question->category))) {
     if (!isset($categories[$question->category])) {
         if (!$categories[$question->category] = $DB->get_record('question_categories',
                 array('id'=>$question->category))) {