MDL-30955 rating: corrected /rating/index.php as it was determining the maximum ratin...

[moodle.git] / rating / index.php

diff --git a/rating/index.php b/rating/index.php
index 78a8b86..db41d98 100644 (file)
--- a/rating/index.php
+++ b/rating/index.php
@@ -102,8 +102,10 @@ if (!$ratings) {
     $table->colclasses = array('', 'firstname', 'rating', 'time');
     $table->data = array();
 
     $table->colclasses = array('', 'firstname', 'rating', 'time');
     $table->data = array();
 

-    //if the scale was changed after ratings were submitted some ratings may have a value above the current maximum
-    $maxrating = count($scalemenu) - 1;
+    // If the scale was changed after ratings were submitted some ratings may have a value above the current maximum
+    // We can't just do count($scalemenu) - 1 as custom scales start at index 1, not 0
+    $maxrating = max(array_keys($scalemenu));
+

     foreach ($ratings as $rating) {
         //Undo the aliasing of the user id column from user_picture::fields()
         //we could clone the rating object or preserve the rating id if we needed it again
     foreach ($ratings as $rating) {
         //Undo the aliasing of the user id column from user_picture::fields()
         //we could clone the rating object or preserve the rating id if we needed it again