Merge branch 'MDL-26461_change_rating_scale' of git://github.com/andyjdavis/moodle

[moodle.git] / rating / index.php

diff --git a/rating/index.php b/rating/index.php
index 50a63be..ff9b121 100644 (file)
--- a/rating/index.php
+++ b/rating/index.php
@@ -92,7 +92,8 @@ if (!$ratings) {
     echo "<th class=\"header\" scope=\"col\"><a href=\"index.php?$sortargs&amp;sort=time\">$strtime</a></th>";
     echo "</tr>";
 
     echo "<th class=\"header\" scope=\"col\"><a href=\"index.php?$sortargs&amp;sort=time\">$strtime</a></th>";
     echo "</tr>";
 

-    $maxrating = count($scalemenu);
+    //if the scale was changed after ratings were submitted some ratings may have a value above the current maximum
+    $maxrating = count($scalemenu) - 1;

     foreach ($ratings as $rating) {
         //Undo the aliasing of the user id column from user_picture::fields()
         //we could clone the rating object or preserve the rating id if we needed it again
     foreach ($ratings as $rating) {
         //Undo the aliasing of the user id column from user_picture::fields()
         //we could clone the rating object or preserve the rating id if we needed it again