MDL-55839 behat: Behat fixes for theme_noname
authorDamyon Wiese <damyon@moodle.com>
Mon, 29 Aug 2016 06:57:46 +0000 (14:57 +0800)
committerDan Poltawski <dan@moodle.com>
Fri, 23 Sep 2016 09:55:16 +0000 (10:55 +0100)
commit63e4df60f691727b68e578ec5c7d756280bcb33b
tree4b2fbc998de1117b31907bb6f896bbc28bd61271
parent428de3dcc3f79fc3baa75d8f8320e048522e8aaf
MDL-55839 behat: Behat fixes for theme_noname

This is a squash of many small fixes.
The list of changes are:

Initial set of behat selectors overrides required for new theme.

set core behat selectors if not overridden by theme

Remove pause

Fix for checkboxes not saving properly

Custom override for click in the user menu

Fix for behat guessing the field type.

Behat fix for guessing the correct field type.

Fix for missing closeElementBefore mforms mess.

Fix for textareas not displaying their contents.

Fix availability form element

Fix action menu selectors for activities in a course page

Fix textareas not retaining their values

Fix selector for blocks

I had to change the single select template to use an input instead of a button because of a
behat bug we have not tracked down yet.

Fix for frozen attribute in form elements

Use input instead of button while behat is still broken

Fix for navigation selector override

Behat selector fixes and multi-select fixes for templated select

Fix for configure blocks selector + booleans for autocomplete

Fixes for course_summary behat tests

Allow optgroups in single_select

Behat fixes for block_navigation

Fixes for url form element and activity chooser selectors

blocks_social - fix specific selector for behat

Fix export_for_template for selectgroups element.

Dont set empty id on the form

Fix direct call to behat_navigation in backup context

Checkbox empty value fix

Fix for assign grading panel popouts

file picker overrides to find a file manager in the page

Fix chat tests to use element name

Make selectors in mod_data behat less specific

MDL-55839: recent activity behat test relies on time()

SQUASH Honour mform element "class" attribute on the container

SQUASH Fixes for behat in mod_forum

SQUASH search form template showing value as text next to the button

SQUASH undo double selectgroup fix

SQUASH - The slightly different structure to action menus breaks course drag and drop

SQUASH Wrap loading icon in a span so the selector still works.

SQUASH Fix fragile javascript in report_loglive

SQUASH Fix tabtree, and selectgroups for mod_feedback

Also - do-not enhance the action menu - we are dropping support for this.

SQUASH Fix filemanager selector and pix_icon template for mod_forum tests.

SQUASH Fixes to breadcrumb and add formid to single select (fixes mod_glossary tests)

SQUASH lesson behat fixes. 95% of lesson styles were rubbish so they were disgarded.

SQUASH Fix lti behat tests - they were cheating and using a context step from quiz

SQUASH Behat fixes for quiz with new theme

SQUASH behat fixes for mod_wiki

SQUASH Workshop behat fixes

SQUASH Frozen form elements cannot use a readonly form element because it screws with the form JS "disabledIf" stuff.

SQUASH Fixes for grades behat tests

SQUASH behat fixes for groups

SQUASH blacklist action menu tests

SQUASH Fix for tag form element missing "manage standard tags" link

SQUASH Incomplete fixes for course behat tests

SQUASH behat fixes for badges

SQUASH Tags fixes for behat

SQUASH filepicker fixes for behat

SQUASH Abort guessing field type when we hit 'html'

SQUASH Fix for admin/tool/behat tests

SQUASH fix for admin tool behat tests

SQUASH fix for availabilty conditions hiding "aria-hidden" elements

SQUASH give the blocks more room. We get behat files because nav tree nodes are not in view

SQUASH Blocks fixed

Fix behaviour of unchecked checkboxes

SQUASH Remove incorrect step in user test

SQUASH behat fixes for course tests

Part of MDL-55071
203 files changed:
admin/tool/behat/tests/behat/data_generators.feature
availability/condition/completion/yui/build/moodle-availability_completion-form/moodle-availability_completion-form-debug.js
availability/condition/completion/yui/build/moodle-availability_completion-form/moodle-availability_completion-form-min.js
availability/condition/completion/yui/build/moodle-availability_completion-form/moodle-availability_completion-form.js
availability/condition/completion/yui/src/form/js/form.js
availability/condition/date/yui/build/moodle-availability_date-form/moodle-availability_date-form-debug.js
availability/condition/date/yui/build/moodle-availability_date-form/moodle-availability_date-form-min.js
availability/condition/date/yui/build/moodle-availability_date-form/moodle-availability_date-form.js
availability/condition/date/yui/src/form/js/form.js
availability/condition/grade/yui/build/moodle-availability_grade-form/moodle-availability_grade-form-debug.js
availability/condition/grade/yui/build/moodle-availability_grade-form/moodle-availability_grade-form-min.js
availability/condition/grade/yui/build/moodle-availability_grade-form/moodle-availability_grade-form.js
availability/condition/grade/yui/src/form/js/form.js
availability/condition/group/yui/build/moodle-availability_group-form/moodle-availability_group-form-debug.js
availability/condition/group/yui/build/moodle-availability_group-form/moodle-availability_group-form-min.js
availability/condition/group/yui/build/moodle-availability_group-form/moodle-availability_group-form.js
availability/condition/group/yui/src/form/js/form.js
availability/condition/grouping/yui/build/moodle-availability_grouping-form/moodle-availability_grouping-form-debug.js
availability/condition/grouping/yui/build/moodle-availability_grouping-form/moodle-availability_grouping-form-min.js
availability/condition/grouping/yui/build/moodle-availability_grouping-form/moodle-availability_grouping-form.js
availability/condition/grouping/yui/src/form/js/form.js
availability/condition/profile/yui/build/moodle-availability_profile-form/moodle-availability_profile-form-debug.js
availability/condition/profile/yui/build/moodle-availability_profile-form/moodle-availability_profile-form-min.js
availability/condition/profile/yui/build/moodle-availability_profile-form/moodle-availability_profile-form.js
availability/condition/profile/yui/src/form/js/form.js
availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-debug.js
availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-min.js
availability/yui/build/moodle-core_availability-form/moodle-core_availability-form.js
availability/yui/src/form/meta/form.json
badges/tests/behat/award_badge.feature
blocks/comments/tests/behat/behat_block_comments.php
blocks/course_summary/tests/behat/block_course_summary_course.feature
blocks/course_summary/tests/behat/block_course_summary_frontpage.feature
blocks/recent_activity/tests/behat/structural_changes.feature
blocks/site_main_menu/tests/behat/edit_activities.feature
blocks/social_activities/tests/behat/edit_activities.feature
blocks/tests/behat/configure_block_throughout_site.feature
blocks/tests/behat/manage_blocks.feature
blocks/tests/behat/move_blocks.feature [new file with mode: 0644]
course/classes/management_renderer.php
course/tests/behat/course_controls.feature
course/tests/behat/course_resort.feature
course/yui/build/moodle-course-dragdrop/moodle-course-dragdrop-debug.js
course/yui/build/moodle-course-dragdrop/moodle-course-dragdrop-min.js
course/yui/build/moodle-course-dragdrop/moodle-course-dragdrop.js
course/yui/build/moodle-course-modchooser/moodle-course-modchooser-debug.js
course/yui/build/moodle-course-modchooser/moodle-course-modchooser-min.js
course/yui/build/moodle-course-modchooser/moodle-course-modchooser.js
course/yui/src/dragdrop/js/section.js
course/yui/src/modchooser/js/modchooser.js
grade/edit/tree/lib.php
grade/report/singleview/tests/behat/bulk_insert_grades.feature
grade/tests/behat/grade_calculated_grade_items.feature
grade/tests/behat/grade_calculated_grade_items_20150627.feature
grade/tests/behat/grade_category_validation.feature
grade/tests/behat/grade_item_validation.feature
grade/tests/behat/grade_letter_boundary.feature
grade/tests/behat/grade_letter_boundary_20160518.feature
grade/tests/behat/grade_to_pass.feature
lib/amd/build/tag.min.js
lib/amd/src/tag.js
lib/behat/behat_base.php
lib/behat/behat_field_manager.php
lib/behat/behat_files.php
lib/behat/classes/behat_selectors.php
lib/behat/form_field/behat_form_filemanager.php
lib/form/advcheckbox.php
lib/form/autocomplete.php
lib/form/cancel.php
lib/form/editor.php
lib/form/form.js
lib/form/group.php
lib/form/select.php
lib/form/tags.php
lib/form/templatable_form_element.php
lib/form/templates/editor_textarea.mustache
lib/form/textarea.php
lib/form/url.php
lib/formslib.php
lib/javascript-static.js
lib/outputcomponents.php
lib/templates/action_link.mustache
lib/tests/behat/behat_action_menu.php [new file with mode: 0644]
lib/tests/behat/behat_deprecated.php
lib/tests/behat/behat_hooks.php
mod/assign/amd/build/grading_panel.min.js
mod/assign/amd/src/grading_panel.js
mod/chat/tests/behat/chat_course_reset.feature
mod/data/tests/behat/required_entries.feature
mod/feedback/classes/complete_form.php
mod/feedback/styles.css
mod/feedback/tests/behat/coursemapping.feature
mod/feedback/tests/behat/multichoice.feature
mod/feedback/yui/dragdrop/dragdrop.js
mod/lesson/locallib.php
mod/lesson/mod_form.php
mod/lesson/styles.css [deleted file]
mod/lesson/tests/behat/lesson_student_resume.feature
mod/lesson/tests/behat/questions_images.feature
mod/lti/tests/behat/addtool.feature
mod/lti/tests/behat/addtype.feature
mod/quiz/renderer.php
mod/quiz/tests/behat/behat_mod_quiz.php
mod/quiz/tests/behat/editing_add.feature
mod/quiz/tests/behat/editing_move_by_click.feature
mod/quiz/tests/behat/editing_repaginate.feature
mod/quiz/tests/behat/editing_section_headings.feature
mod/quiz/yui/build/moodle-mod_quiz-util-page/moodle-mod_quiz-util-page-debug.js
mod/quiz/yui/build/moodle-mod_quiz-util-page/moodle-mod_quiz-util-page-min.js
mod/quiz/yui/build/moodle-mod_quiz-util-page/moodle-mod_quiz-util-page.js
mod/quiz/yui/src/util/js/page.js
mod/quiz/yui/src/util/meta/util.json
mod/wiki/editors/wikieditor.php
mod/wiki/tests/behat/wiki_formats.feature
mod/workshop/tests/behat/behat_mod_workshop.php
mod/workshop/tests/behat/workshop_assessment.feature
report/loglive/classes/renderer.php
report/loglive/yui/build/moodle-report_loglive-fetchlogs/moodle-report_loglive-fetchlogs-debug.js
report/loglive/yui/build/moodle-report_loglive-fetchlogs/moodle-report_loglive-fetchlogs-min.js
report/loglive/yui/build/moodle-report_loglive-fetchlogs/moodle-report_loglive-fetchlogs.js
report/loglive/yui/src/fetchlogs/js/fetchlogs.js
repository/tests/behat/cancel_add_file.feature
repository/upload/tests/behat/behat_repository_upload.php
tag/classes/collections_table.php
theme/bootstrapbase/less/moodle/modules.less
theme/bootstrapbase/style/moodle.css
theme/noname/classes/output/core_renderer.php
theme/noname/layout/columns2.php
theme/noname/scss/moodle/course.scss
theme/noname/scss/moodle/forms.scss
theme/noname/scss/moodle/modules.scss
theme/noname/templates/block_settings/search_form.mustache
theme/noname/templates/columns2.mustache
theme/noname/templates/core/block.mustache
theme/noname/templates/core/filemanager_page_generallayout.mustache
theme/noname/templates/core/navbar.mustache
theme/noname/templates/core/pix_icon.mustache
theme/noname/templates/core/single_button.mustache
theme/noname/templates/core/single_select.mustache
theme/noname/templates/core/tabtree.mustache
theme/noname/templates/core/url_select.mustache
theme/noname/templates/core_form/editor_textarea.mustache
theme/noname/templates/core_form/element-advcheckbox-inline.mustache
theme/noname/templates/core_form/element-advcheckbox.mustache
theme/noname/templates/core_form/element-autocomplete-inline.mustache [new file with mode: 0644]
theme/noname/templates/core_form/element-autocomplete.mustache
theme/noname/templates/core_form/element-button-inline.mustache
theme/noname/templates/core_form/element-button.mustache
theme/noname/templates/core_form/element-checkbox-inline.mustache
theme/noname/templates/core_form/element-checkbox.mustache
theme/noname/templates/core_form/element-date_selector.mustache
theme/noname/templates/core_form/element-date_time_selector-inline.mustache
theme/noname/templates/core_form/element-date_time_selector.mustache
theme/noname/templates/core_form/element-duration-inline.mustache
theme/noname/templates/core_form/element-duration.mustache
theme/noname/templates/core_form/element-editor.mustache
theme/noname/templates/core_form/element-filemanager.mustache
theme/noname/templates/core_form/element-filepicker.mustache
theme/noname/templates/core_form/element-grading.mustache
theme/noname/templates/core_form/element-group-inline.mustache
theme/noname/templates/core_form/element-group.mustache
theme/noname/templates/core_form/element-modgrade.mustache
theme/noname/templates/core_form/element-modvisible.mustache
theme/noname/templates/core_form/element-password.mustache
theme/noname/templates/core_form/element-passwordunmask.mustache
theme/noname/templates/core_form/element-questioncategory-inline.mustache
theme/noname/templates/core_form/element-questioncategory.mustache
theme/noname/templates/core_form/element-radio-inline.mustache
theme/noname/templates/core_form/element-radio.mustache
theme/noname/templates/core_form/element-recaptcha.mustache
theme/noname/templates/core_form/element-select-inline.mustache
theme/noname/templates/core_form/element-select.mustache
theme/noname/templates/core_form/element-selectgroups-inline.mustache
theme/noname/templates/core_form/element-selectgroups.mustache
theme/noname/templates/core_form/element-selectwithlink.mustache
theme/noname/templates/core_form/element-selectyesno-inline.mustache
theme/noname/templates/core_form/element-selectyesno.mustache
theme/noname/templates/core_form/element-static.mustache
theme/noname/templates/core_form/element-submit-inline.mustache
theme/noname/templates/core_form/element-submit.mustache
theme/noname/templates/core_form/element-tags-inline.mustache [new file with mode: 0644]
theme/noname/templates/core_form/element-tags.mustache [new file with mode: 0644]
theme/noname/templates/core_form/element-template-inline.mustache
theme/noname/templates/core_form/element-template.mustache
theme/noname/templates/core_form/element-text-inline.mustache
theme/noname/templates/core_form/element-text.mustache
theme/noname/templates/core_form/element-textarea.mustache
theme/noname/templates/core_form/element-url.mustache
theme/noname/templates/core_form/element-wikieditor.mustache [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_action_menu.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_admin.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_auth.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_backup.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_blocks.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_course.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_filepicker.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_files.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_grade.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_mod_quiz.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_navigation.php [new file with mode: 0644]
theme/noname/tests/behat/behat_theme_noname_behat_repository_upload.php [new file with mode: 0644]
theme/noname/tests/behat/blacklist.json [new file with mode: 0644]
user/tests/behat/reset_page.feature