MDL-30854 quiz/question editing: fix create calc question & add on page.
authorTim Hunt <T.J.Hunt@open.ac.uk>
Wed, 18 Jan 2012 16:47:45 +0000 (16:47 +0000)
committerTim Hunt <T.J.Hunt@open.ac.uk>
Mon, 30 Jan 2012 12:32:12 +0000 (12:32 +0000)
commit72553162baa28538028d3b4e59f85e4aa64ea5f6
treeeb6c6842e92e537e6703434dfc4f7426671cd5cd
parent216f6d8e9d7e7473890ce0cb42332396e33740a0
MDL-30854 quiz/question editing: fix create calc question & add on page.

This was one of those innocent seeming issues where, once you start
digging, you find a mess. In this case, the code that is now in
question_wizard_form::add_hidden_fields used to exist in four different
places, in four inconsistent versions. This is now all nicely
re-factored, and that solves the problem.

Along the way, I found and fixed some wrong string references in
qtype_random, and stripped out some unnecessary &s in function
declarations.
question/type/calculated/datasetdefinitions_form.php
question/type/calculated/datasetitems_form.php
question/type/calculated/questiontype.php
question/type/calculatedsimple/edit_calculatedsimple_form.php
question/type/calculatedsimple/questiontype.php
question/type/edit_question_form.php
question/type/missingtype/questiontype.php
question/type/random/edit_random_form.php
question/type/random/questiontype.php