MDL-68070 messaging: Ensure that error is shown on first messages
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Wed, 14 Oct 2020 09:22:23 +0000 (11:22 +0200)
committerSara Arjona <sara@moodle.com>
Wed, 14 Oct 2020 16:57:16 +0000 (18:57 +0200)
commit19b0f08cc2c6e469e91ae7347b48b136f250793e
tree27b6c768360afdda8b7933c86344122974d43237
parent33a4c4a3b9c3a8674229ec643bf91acd23175ea3
MDL-68070 messaging: Ensure that error is shown on first messages

Before there is a conversation, messages between users are sent
using core_message_send_instant_messages instead of
core_message_send_messages_to_conversation.

That method had an undefined $errormessage variable, ultimately
causing the problem detected on message_post_message()/message_send()
to never been returned by the external.

This just adds the same error than already existing conversations do,
but returning it as warning, for BC, JS will show it.
message/externallib.php