MDL-67673 phpunit: Remove deprecated assertEquals() params
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Tue, 1 Sep 2020 23:14:14 +0000 (01:14 +0200)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Wed, 21 Oct 2020 10:46:00 +0000 (12:46 +0200)
commit3a5641cb74cc27453be4a83c98aae2a104678ed1
tree0ec63652d0db473368d8aa39920fd3764affa587
parent40de097e6522091bd5918ae7ba4c84721d453b19
MDL-67673 phpunit: Remove deprecated assertEquals() params

The optional parameters of assertEquals() and assertNotEquals()
are deprecated in PHPUnit 8 (to be removed in PHPUnit 9):

- delta => use assertEqualsWithDelta()
- canonicalize => use assertEqualsCanonicalizing()
- ignoreCase => use assertEqualsIgnoringCase
- maxDepth => removed without replacement.

More info @ https://github.com/sebastianbergmann/phpunit/issues/3341

Initial search done with:

ag 'assert(Not)?Equals\(.*,.*,' --php

Then, running tests and fixing remaining cases.
70 files changed:
admin/roles/tests/privacy_test.php
admin/tool/cohortroles/tests/privacy_test.php
admin/tool/dataprivacy/tests/manager_observer_test.php
admin/tool/policy/tests/privacy_provider_test.php
admin/tool/uploadcourse/tests/course_test.php
auth/oauth2/tests/auth_test.php
backup/tests/privacy_provider_test.php
blocks/comments/tests/privacy_provider_test.php
blog/tests/privacy_test.php
cache/tests/fixtures/stores.php
calendar/tests/lib_test.php
calendar/tests/raw_event_retrieval_strategy_test.php
course/tests/externallib_test.php
customfield/tests/privacy_test.php
enrol/flatfile/tests/privacy_provider_test.php
enrol/lti/tests/privacy_provider_test.php
enrol/meta/tests/privacy_test.php
enrol/paypal/tests/privacy_provider_test.php
enrol/tests/enrollib_test.php
enrol/tests/externallib_test.php
favourites/tests/privacy_test.php
grade/tests/edittreelib_test.php
grade/tests/privacy_test.php
group/tests/privacy_provider_test.php
iplookup/tests/geoplugin_test.php
lib/ddl/tests/ddl_test.php
lib/dml/tests/dml_test.php
lib/grade/tests/grade_item_test.php
lib/phpunit/tests/basic_test.php
lib/tests/accesslib_test.php
lib/tests/blocklib_test.php
lib/tests/filterlib_test.php
lib/tests/grouplib_test.php
lib/tests/mathslib_test.php
lib/tests/moodlelib_test.php
lib/tests/session_manager_test.php
lib/tests/time_splittings_test.php
message/tests/privacy_provider_test.php
mod/data/tests/lib_test.php
mod/glossary/tests/external_test.php
mod/quiz/report/statistics/tests/statistics_test.php
mod/quiz/report/statistics/tests/stats_from_steps_walkthrough_test.php
mod/quiz/tests/local_structure_slot_random_test.php
mod/quiz/tests/locallib_test.php
mod/quiz/tests/privacy_provider_test.php
mod/quiz/tests/tags_test.php
mod/wiki/tests/lib_test.php
mod/wiki/tests/privacy_test.php
mod/workshop/tests/privacy_provider_test.php
question/behaviour/adaptive/tests/walkthrough_test.php
question/behaviour/adaptivenopenalty/tests/walkthrough_test.php
question/behaviour/deferredcbm/tests/question_cbm_test.php
question/behaviour/deferredcbm/tests/walkthrough_test.php
question/behaviour/deferredfeedback/tests/walkthrough_test.php
question/behaviour/immediatecbm/tests/walkthrough_test.php
question/behaviour/immediatefeedback/tests/walkthrough_test.php
question/behaviour/interactive/tests/walkthrough_test.php
question/engine/tests/helpers.php
question/engine/tests/questionattemptstep_test.php
question/engine/tests/unitofwork_test.php
question/tests/privacy_provider_test.php
question/type/ddwtos/tests/questiontype_test.php
question/type/gapselect/tests/questiontype_test.php
question/type/match/tests/questiontype_test.php
question/type/multianswer/tests/questiontype_test.php
question/type/multichoice/tests/question_multi_test.php
question/type/multichoice/tests/question_single_test.php
question/type/numerical/tests/answerprocessor_test.php
repository/contentbank/tests/browser_test.php
repository/contentbank/tests/search_test.php