MDL-63658 core_favourites: properly define interface methods and cleanup
authorJake Dallimore <jake@moodle.com>
Thu, 18 Oct 2018 07:31:55 +0000 (15:31 +0800)
committerJake Dallimore <jake@moodle.com>
Thu, 18 Oct 2018 07:39:57 +0000 (15:39 +0800)
commit68eaa3150eadece016c5504e0e8a7a885ffbf992
treef451405f2a55b8a6e2144b45abfc95b66087da17
parent1f3c76f0ecbbc0df02a3c2c9e34400902d76d317
MDL-63658 core_favourites: properly define interface methods and cleanup

This gets rid of specific repo functions which were unused, and makes
sure the following methods are defined on the interface, implemented
and tested:
- exists_by($criteria)
- find_by($criteria)
- delete_by($crtieria)
Also, added missing tests for find_favourite() repo method.
favourites/classes/local/repository/favourite_repository.php
favourites/classes/local/repository/favourite_repository_interface.php
favourites/tests/repository_test.php