question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.
authorTim Hunt <T.J.Hunt@open.ac.uk>
Thu, 11 Nov 2010 17:32:25 +0000 (17:32 +0000)
committerTim Hunt <T.J.Hunt@open.ac.uk>
Thu, 11 Nov 2010 17:32:25 +0000 (17:32 +0000)
commita9efae50e3264bdfd6abdaf66efa2b9e0e8314cd
tree94a0c9c21bbdb393bc4cdecdb22966e26314bb3e
parentd39c6513788275221f48b04e039d937792249275
question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.

There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
20 files changed:
lib/db/upgrade.php
lib/questionlib.php
mod/quiz/attemptlib.php
mod/quiz/comment.php
mod/quiz/db/upgrade.php
mod/quiz/report/grading/report.php
question/type/calculated/db/upgrade.php
question/type/description/questiontype.php
question/type/essay/questiontype.php
question/type/match/db/upgrade.php
question/type/missingtype/questiontype.php
question/type/multianswer/questiontype.php
question/type/multichoice/db/upgrade.php
question/type/multichoice/questiontype.php
question/type/numerical/db/upgrade.php
question/type/numerical/display.html
question/type/numerical/questiontype.php
question/type/questiontype.php
question/type/shortanswer/questiontype.php
question/type/truefalse/questiontype.php