MDL-62680 output: Only hide icons with no label
authorDamyon Wiese <damyon@moodle.com>
Thu, 10 Jan 2019 02:22:48 +0000 (10:22 +0800)
committerDamyon Wiese <damyon@moodle.com>
Thu, 7 Feb 2019 02:08:19 +0000 (10:08 +0800)
commitef96eb02fb3998f8e1cebe8657cffbbfbefe6b2b
tree272ff6cc114ec8f8e1d645af1fd3f4eacf8d2c91
parent4c5b60a0f9e2efc2128f41dc0c8b5d06ea50cc48
MDL-62680 output: Only hide icons with no label

For accessibility we don't want to read an icon with a label immediately next to the label,
but in this case it's clearer for the icon to have no alt text / title for both
screen readers and non-screen readers. Worse is not reading important information just
because it's displayed as an icon.
lib/classes/output/icon_system_fontawesome.php
lib/outputcomponents.php
lib/outputrenderers.php
lib/templates/pix_icon_fontawesome.mustache
lib/tests/outputcomponents_test.php
lib/upgrade.txt