MDL-42560 Events: Removed use of role->name

role->name is usually empty or localized, so should not be used in events

diff --git a/admin/roles/define.php b/admin/roles/define.php
index 265b100..d30ad3e 100644 (file)
--- a/admin/roles/define.php
+++ b/admin/roles/define.php
@@ -201,8 +201,7 @@ if (optional_param('savechanges', false, PARAM_BOOL) && confirm_sesskey() && $de
     $event = \core\event\role_capabilities_updated::create(
         array(
             'context' => $systemcontext,
-            'objectid' => $roleid,
-            'other' => array('name' => $definitiontable->get_role_name())
+            'objectid' => $roleid
         )
     );
     $event->set_legacy_logdata(array(SITEID, 'role', $action, 'admin/roles/define.php?action=view&roleid=' . $tableroleid,

diff --git a/admin/roles/override.php b/admin/roles/override.php
index bc506f1..e75b0fd 100644 (file)
--- a/admin/roles/override.php
+++ b/admin/roles/override.php
@@ -130,8 +130,7 @@ if (optional_param('savechanges', false, PARAM_BOOL) && confirm_sesskey()) {
         array(
             'context' => $context,
             'objectid' => $roleid,
-            'courseid' => $courseid,
-            'other' => array('name' => $rolename)
+            'courseid' => $courseid
         )
     );
 

diff --git a/lib/accesslib.php b/lib/accesslib.php
index 7d7bb69..45f07b4 100644 (file)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -1528,7 +1528,6 @@ function delete_role($roleid) {
             'objectid' => $roleid,
             'other' =>
                 array(
-                    'name' => $role->name,
                     'shortname' => $role->shortname,
                     'description' => $role->description,
                     'archetype' => $role->archetype

diff --git a/lib/tests/accesslib_test.php b/lib/tests/accesslib_test.php
index d3c3c1e..5525061 100644 (file)
--- a/lib/tests/accesslib_test.php
+++ b/lib/tests/accesslib_test.php
@@ -699,7 +699,6 @@ class core_accesslib_testcase extends advanced_testcase {
         $this->assertSame('role', $event->objecttable);
         $this->assertSame($role->id, $event->objectid);
         $this->assertEquals(context_system::instance(), $event->get_context());
-        $this->assertSame($role->name, $event->other['name']);
         $this->assertSame($role->shortname, $event->other['shortname']);
         $this->assertSame($role->description, $event->other['description']);
         $this->assertSame($role->archetype, $event->other['archetype']);