MDL-25708 recordsets - folder module

diff --git a/mod/folder/db/upgradelib.php b/mod/folder/db/upgradelib.php
index 016f079..0be56e1 100644 (file)
--- a/mod/folder/db/upgradelib.php
+++ b/mod/folder/db/upgradelib.php
@@ -48,7 +48,10 @@ function folder_20_migrate() {
         return;
     }
 
-    if (!$candidates = $DB->get_recordset('resource_old', array('type'=>'directory', 'migrated'=>0))) {
+    $candidates = $DB->get_recordset('resource_old', array('type'=>'directory', 'migrated'=>0));
+
+    if (!$candidates->valid()) {
+        $candidates->close(); // Not going to iterate (but exit), close rs
         return;
     }
 
@@ -101,4 +104,4 @@ function folder_20_migrate() {
 
     // clear all course modinfo caches
     rebuild_course_cache(0, true);
-}
\ No newline at end of file
+}