MDL-27084: mod/feedback fix bad syntax in database query
authorTony Levi <tony.levi@netspot.com.au>
Tue, 5 Apr 2011 02:11:24 +0000 (11:41 +0930)
committerTony Levi <tony.levi@netspot.com.au>
Tue, 5 Apr 2011 02:44:16 +0000 (12:14 +0930)
mod/feedback/lib.php

index 1d238e9..a75d8c9 100644 (file)
@@ -1786,10 +1786,10 @@ function feedback_get_page_to_continue($feedbackid, $courseid = false, $guestid
 
     $params = array();
     if($courseid) {
-        $courseselect = "fv.course_id = :courseid";
+        $courseselect = "AND fv.course_id = :courseid";
         $params['courseid'] = $courseid;
     }else {
-        $courseselect = "1";
+        $courseselect = '';
     }
 
     if($guestid) {
@@ -1807,7 +1807,7 @@ function feedback_get_page_to_continue($feedbackid, $courseid = false, $guestid
               WHERE fc.id = fv.completed
                     $userselect
                     AND fc.feedback = :feedbackid
-                    AND $courseselect
+                    $courseselect
                     AND fi.id = fv.item
          $usergroup";
     $params['feedbackid'] = $feedbackid;
@@ -2779,4 +2779,4 @@ function feedback_init_feedback_session() {
             $SESSION->feedback = new stdClass();
         }
     }
-}
\ No newline at end of file
+}