MDL-63422 auth_cas: review core loop / switch / case / continue
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Sun, 14 Oct 2018 10:44:47 +0000 (12:44 +0200)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Tue, 30 Oct 2018 23:17:59 +0000 (00:17 +0100)
Created https://github.com/apereo/phpCAS/pull/278 upstream, applied locally.

auth/cas/CAS/CAS/Client.php
auth/cas/CAS/moodle_readme.txt

index 8cce608..b850955 100644 (file)
@@ -3380,7 +3380,7 @@ class CAS_Client
                 case 'user':
                 case 'proxies':
                 case 'proxyGrantingTicket':
-                    continue;
+                    break;
                 default:
                     if (strlen(trim($attr_node->nodeValue))) {
                         phpCas :: trace(
index b368b32..15a8917 100644 (file)
@@ -1,4 +1,5 @@
 Description of phpCAS 1.3.5 library import
 
 * downloaded from http://downloads.jasig.org/cas-clients/php/current/
-* applied patch https://github.com/apereo/phpCAS/pull/247 for PHP 7.2 compatibility (MDL-60280)
\ No newline at end of file
+* applied patch https://github.com/apereo/phpCAS/pull/247 for PHP 7.2 compatibility (MDL-60280)
+* applied patch https://github.com/apereo/phpCAS/pull/278 for PHP 7.3 compatibility (MDL-63422)