MDL-31317 original_site_identifier_hash falls back to null during the backup conversion
authorDavid Mudrak <david@moodle.com>
Thu, 26 Jan 2012 13:09:04 +0000 (14:09 +0100)
committerDavid Mudrak <david@moodle.com>
Fri, 27 Jan 2012 07:48:37 +0000 (08:48 +0100)
Even if the site identifier is not defined in the source 1.9 backup then the
converted 2.0 version should still contain the element to prevent PHP
notices on direct assignment.

backup/converter/moodle1/handlerlib.php

index a6b7788..f0c9754 100644 (file)
@@ -345,6 +345,8 @@ class moodle1_root_handler extends moodle1_xml_handler {
         // {@see backup_general_helper::backup_is_samesite()}
         if (isset($backupinfo['original_site_identifier_hash'])) {
             $this->xmlwriter->full_tag('original_site_identifier_hash', $backupinfo['original_site_identifier_hash']);
+        } else {
+            $this->xmlwriter->full_tag('original_site_identifier_hash', null);
         }
         $this->xmlwriter->full_tag('original_course_id', $originalcourseinfo['original_course_id']);
         $this->xmlwriter->full_tag('original_course_fullname', $originalcourseinfo['original_course_fullname']);