MDL-37838 block_courseoverview: fix pluaralisation logic
authorDan Poltawski <dan@moodle.com>
Mon, 12 May 2014 09:42:14 +0000 (17:42 +0800)
committerDan Poltawski <dan@moodle.com>
Mon, 12 May 2014 09:42:14 +0000 (17:42 +0800)
Note that this kind of handling of plurals is extremely limited, see:

https://moodle.org/mod/forum/discuss.php?d=85897
http://search.cpan.org/~petdance/Locale-Maketext-1.12/lib/Locale/Maketext/TPJ13.pod

However, this is a simple fix to the existing logic

blocks/course_overview/renderer.php

index 3efcd95..76ef098 100644 (file)
@@ -315,11 +315,11 @@ class block_course_overview_renderer extends plugin_renderer_base {
         $plural = 's';
         if ($msgcount > 0) {
             $output .= get_string('youhavemessages', 'block_course_overview', $msgcount);
-        } else {
-            $output .= get_string('youhavenomessages', 'block_course_overview');
             if ($msgcount == 1) {
                 $plural = '';
             }
+        } else {
+            $output .= get_string('youhavenomessages', 'block_course_overview');
         }
         $output .= html_writer::link(new moodle_url('/message/index.php'), get_string('message'.$plural, 'block_course_overview'));
         $output .= $this->output->box_end();