MDL-36061 - remove master-only unit tests
authorDan Poltawski <dan@moodle.com>
Thu, 15 Nov 2012 07:19:28 +0000 (15:19 +0800)
committerDan Poltawski <dan@moodle.com>
Thu, 15 Nov 2012 07:19:28 +0000 (15:19 +0800)
lib/grade/tests/grade_item_test.php
lib/tests/gradelib_test.php

index 35d527b..78bfa20 100644 (file)
@@ -489,11 +489,6 @@ class grade_item_testcase extends grade_base_testcase {
         $grade_item = new grade_item($this->grade_items[0], false);
         $this->assertTrue(method_exists($grade_item, 'refresh_grades'));
         $this->assertTrue($grade_item->refresh_grades());
-
-        // Break the grade item and check error handling.
-        $grade_item->iteminstance = 123456789;
-        $this->assertFalse($grade_item->refresh_grades());
-        $this->assertDebuggingCalled();
     }
 
     protected function sub_test_grade_item_is_calculated() {
index 14173cf..659efc7 100644 (file)
@@ -34,25 +34,17 @@ class gradelib_testcase extends advanced_testcase {
 
         $this->resetAfterTest(true);
 
-        // Create a broken module instance.
-        $modinstance = new stdClass();
-        $modinstance->modname = 'doesntexist';
-
-        $this->assertFalse(grade_update_mod_grades($modinstance));
-        // A debug message should have been generated.
-        $this->assertDebuggingCalled();
-
-        // Create a course and instance of mod_assign.
+        // Create a course and instance of mod_assignment.
         $course = $this->getDataGenerator()->create_course();
 
         $assigndata['course'] = $course->id;
         $assigndata['name'] = 'lightwork assignment';
-        $modinstance = self::getDataGenerator()->create_module('assign', $assigndata);
+        $modinstance = self::getDataGenerator()->create_module('assignment', $assigndata);
 
         // grade_update_mod_grades() requires 2 additional properties, cmidnumber and modname.
-        $cm = get_coursemodule_from_instance('assign', $modinstance->id, 0, false, MUST_EXIST);
+        $cm = get_coursemodule_from_instance('assignment', $modinstance->id, 0, false, MUST_EXIST);
         $modinstance->cmidnumber = $cm->id;
-        $modinstance->modname = 'assign';
+        $modinstance->modname = 'assignment';
 
         $this->assertTrue(grade_update_mod_grades($modinstance));
     }