MDL-22504 Course drag and drop upload - experimental setting is now a checkbox

diff --git a/admin/settings/development.php b/admin/settings/development.php
index dcddf32..e55e1f2 100644 (file)
--- a/admin/settings/development.php
+++ b/admin/settings/development.php
@@ -13,9 +13,7 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
     $temp->add(new admin_setting_configcheckbox('enablesafebrowserintegration', new lang_string('enablesafebrowserintegration', 'admin'), new lang_string('configenablesafebrowserintegration', 'admin'), 0));
     $temp->add(new admin_setting_configcheckbox('enablegroupmembersonly', new lang_string('enablegroupmembersonly', 'admin'), new lang_string('configenablegroupmembersonly', 'admin'), 0));
 
-    $dndopts = array(0 => new lang_string('dnduploadfiles', 'admin'),
-                     1 => new lang_string('dnduploadfilestextlink', 'admin'));
-    $temp->add(new admin_setting_configselect('dndallowtextandlinks', new lang_string('dndallowtextandlinks', 'admin'), new lang_string('configdndallowtextandlinks', 'admin'), 0, $dndopts));
+    $temp->add(new admin_setting_configcheckbox('dndallowtextandlinks', new lang_string('dndallowtextandlinks', 'admin'), new lang_string('configdndallowtextandlinks', 'admin'), 0));
 
     $ADMIN->add('experimental', $temp);
 

diff --git a/course/dnduploadlib.php b/course/dnduploadlib.php
index d82da35..01eb3c1 100644 (file)
--- a/course/dnduploadlib.php
+++ b/course/dnduploadlib.php
@@ -312,7 +312,7 @@ class dndupload_handler {
         uasort($this->types, array($this, 'type_compare'));
 
         $ret->types = array();
-        if ($CFG->dndallowtextandlinks) {
+        if (!empty($CFG->dndallowtextandlinks)) {
             foreach ($this->types as $type) {
                 if (empty($type->handlers)) {
                     continue; // Skip any types without registered handlers.

diff --git a/lang/en/admin.php b/lang/en/admin.php
index 9ae4445..2ac7b1e 100644 (file)
--- a/lang/en/admin.php
+++ b/lang/en/admin.php
@@ -432,9 +432,7 @@ $string['devicetype'] = 'Device type';
 $string['disableuserimages'] = 'Disable user profile images';
 $string['displayerrorswarning'] = 'Enabling the PHP setting <em>display_errors</em> is not recommended on production sites because some error messages may reveal sensitive information about your server.';
 $string['displayloginfailures'] = 'Display login failures to';
-$string['dndallowtextandlinks'] = 'Drag and drop upload allows';
-$string['dnduploadfiles'] = 'files only';
-$string['dnduploadfilestextlink'] = 'files, text and links';
+$string['dndallowtextandlinks'] = 'Drag and drop upload of text/links';
 $string['docroot'] = 'Moodle Docs document root';
 $string['doctonewwindow'] = 'Open in new window';
 $string['download'] = 'Download';