MDL-41517 Do not call fix_course_sortorder unnecessarily

Thanks to Thomas Worthington

diff --git a/course/lib.php b/course/lib.php
index a0b5f5a..52462a2 100644 (file)
--- a/course/lib.php
+++ b/course/lib.php
@@ -2408,7 +2408,10 @@ function update_course($data, $editoroptions = NULL) {
         $context->update_moved($newparent);
     }
 
-    fix_course_sortorder();
+    if ($movecat || (isset($data->sortorder) && $oldcourse->sortorder != $data->sortorder)) {
+        fix_course_sortorder();
+    }
+
     // purge appropriate caches in case fix_course_sortorder() did not change anything
     cache_helper::purge_by_event('changesincourse');
     if ($changesincoursecat) {