MDL-61364 question: adjust code and fix phpunit errors
authorSimey Lameze <simey@moodle.com>
Mon, 26 Mar 2018 03:31:24 +0000 (11:31 +0800)
committerSimey Lameze <simey@moodle.com>
Tue, 27 Mar 2018 08:14:46 +0000 (16:14 +0800)
question/classes/bank/view.php
question/engine/tests/helpers.php
question/question.php
question/type/calculatedsimple/tests/helper.php
question/type/gapselect/tests/edit_form_test.php

index e8df555..518e36c 100644 (file)
@@ -929,7 +929,7 @@ class view {
                 if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
                     $key = $matches[1];
                     $questionlist .= $key.',';
-                    question_require_capability_on($key, 'edit');
+                    question_require_capability_on((int)$key, 'edit');
                     if (questions_in_use(array($key))) {
                         $questionnames .= '* ';
                         $inuse = true;
index 8a89633..0614f60 100644 (file)
@@ -119,6 +119,7 @@ abstract class question_test_helper {
         $catcontext = context::instance_by_id($cat->contextid, MUST_EXIST);
         $contexts = new question_edit_contexts($catcontext);
         $dataforformconstructor = new stdClass();
+        $dataforformconstructor->createdby = $questiondata->createdby;
         $dataforformconstructor->qtype = $questiondata->qtype;
         $dataforformconstructor->contextid = $questiondata->contextid = $catcontext->id;
         $dataforformconstructor->category = $questiondata->category = $cat->id;
index acbabce..2a02d92 100644 (file)
@@ -162,6 +162,7 @@ if (isset($question->categoryobject)) {
 $question->formoptions = new stdClass();
 
 $categorycontext = context::instance_by_id($category->contextid);
+$question->contextid = $category->contextid;
 $addpermission = has_capability('moodle/question:add', $categorycontext);
 
 if ($id) {
index 53cb8e4..5218994 100644 (file)
@@ -209,9 +209,11 @@ class qtype_calculatedsimple_test_helper extends question_test_helper {
     }
 
     public function get_calculatedsimple_question_data_sumwithvariants() {
+        global $USER;
         $q = new stdClass();
 
         $q->name = 'Calculated simple';
+        $q->createdby = $USER->id;
         $q->questiontext = '<p>This is a simple sum of two variables.</p>';
         $q->questiontextformat = '1';
         $q->generalfeedback = '<p>The answer isĀ  {a} + {b}</p>';
index 97ee86d..7c6dc38 100644 (file)
@@ -43,6 +43,8 @@ class qtype_gapselect_edit_form_base_testable extends qtype_gapselect_edit_form_
         $category = question_make_default_categories(array($syscontext));
         $fakequestion = new stdClass();
         $fakequestion->qtype = 'stack';
+        $fakequestion->contextid = $syscontext->id;
+        $fakequestion->createdby = 2;
         $fakequestion->category = $category->id;
         $fakequestion->questiontext = 'Test [[1]] question [[2]]';
         $fakequestion->options = new stdClass();