MDL-65087 message: add aria-label to some buttons on bootstrapbase
authorSara Arjona <sara@moodle.com>
Fri, 15 Mar 2019 13:39:34 +0000 (14:39 +0100)
committerSara Arjona <sara@moodle.com>
Fri, 29 Mar 2019 08:33:35 +0000 (09:33 +0100)
The aria-label has been added to the settings and search buttons and
also to the starred image displayed when a conversation is favourited.

theme/bootstrapbase/templates/core_message/message_drawer_view_conversation_header_content_type_private.mustache
theme/bootstrapbase/templates/core_message/message_drawer_view_conversation_header_content_type_private_no_controls.mustache
theme/bootstrapbase/templates/core_message/message_drawer_view_conversation_header_content_type_public.mustache
theme/bootstrapbase/templates/core_message/message_drawer_view_overview_header.mustache
theme/bootstrapbase/templates/core_message/message_drawer_view_search_header.mustache

index 5b66b84..d69d818 100644 (file)
@@ -62,7 +62,8 @@
             <div class="w-100 text-truncate ml-2">
                 <div class="d-flex">
                     <strong class="m-0 text-truncate">{{name}}</strong>
-                    <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary" data-region="favourite-icon-container">
+                    <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary" data-region="favourite-icon-container"
+                    aria-label="{{#str}} favourites, core {{/str}}">
                         {{#pix}} i/star, core {{/pix}}
                     </span>
                     <span class="{{^ismuted}}hidden{{/ismuted}} ml-1 text-primary" data-region="muted-icon-container">
index 21fb692..1445deb 100644 (file)
@@ -61,7 +61,8 @@
         <div class="w-100 text-truncate ml-2">
             <div class="d-flex">
                 <strong class="m-0 text-truncate">{{name}}</strong>
-                <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary" data-region="favourite-icon-container">
+                <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary" data-region="favourite-icon-container"
+                aria-label="{{#str}} favourites, core {{/str}}">
                     {{#pix}} i/star, core {{/pix}}
                 </span>
                 <span class="{{^ismuted}}hidden{{/ismuted}} ml-1 text-primary" data-region="muted-icon-container">
index 45181a6..794cfe1 100644 (file)
@@ -60,7 +60,8 @@
                 <div class="w-100 text-truncate ml-2">
                     <div class="d-flex">
                         <strong class="m-0 text-truncate">{{name}}</strong>
-                        <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary" data-region="favourite-icon-container">
+                        <span class="{{^isfavourite}}hidden{{/isfavourite}} ml-1 text-primary"
+                        data-region="favourite-icon-container" aria-label="{{#str}} favourites, core {{/str}}">
                             {{#pix}} i/star, core {{/pix}}
                         </span>
                         <span class="{{^ismuted}}hidden{{/ismuted}} ml-1 text-primary" data-region="muted-icon-container">
index 834e9de..3449430 100644 (file)
@@ -57,6 +57,7 @@
                 href="#"
                 data-route="view-settings"
                 data-route-param="{{loggedinuser.id}}"
+                aria-label="{{#str}} settings, core_message {{/str}}"
                 role="button"
             >
                 {{#pix}} t/edit, core {{/pix}}
index aa94c21..a8a62c9 100644 (file)
@@ -62,6 +62,7 @@
                 class="btn m-0"
                 type="button"
                 data-action="search"
+                aria-label="{{#str}} search, core_search {{/str}}"
             >
                 <span data-region="search-icon-container">
                     {{#pix}} a/search, core {{/pix}}