MDL-63137 mod_feedback: discern between user or id better
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Tue, 30 Apr 2019 00:11:42 +0000 (02:11 +0200)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Tue, 30 Apr 2019 18:47:15 +0000 (20:47 +0200)
is_int('1') => false, so better we invert the check that is safer.

mod/feedback/lib.php

index 10c2219..884dd7d 100644 (file)
@@ -2556,7 +2556,7 @@ function feedback_send_email($cm, $feedback, $course, $user, $completed = null)
         return;
     }
 
-    if (is_int($user)) {
+    if (!is_object($user)) {
         $user = $DB->get_record('user', array('id' => $user));
     }