MDL-38030 new core_user_get_users_by_field function deprecates core_user_get_users_by_id

diff --git a/lib/db/services.php b/lib/db/services.php
index 8cdb376..b0ef0e5 100644 (file)
--- a/lib/db/services.php
+++ b/lib/db/services.php
@@ -304,7 +304,7 @@ $functions = array(
         'classname'   => 'core_user_external',
         'methodname'  => 'get_users_by_id',
         'classpath'   => 'user/externallib.php',
-        'description' => 'Get users by id.',
+        'description' => 'DEPRECATED: this deprecated function will be removed in a future version. This function has been replaced by core_user_get_users_by_field()',
         'type'        => 'read',
         'capabilities'=> 'moodle/user:viewdetails, moodle/user:viewhiddendetails, moodle/course:useremail, moodle/user:update',
     ),

diff --git a/user/externallib.php b/user/externallib.php
index 7bc342e..735290a 100644 (file)
--- a/user/externallib.php
+++ b/user/externallib.php
@@ -640,6 +640,8 @@ class core_user_external extends external_api {
      *
      * @return external_function_parameters
      * @since Moodle 2.2
+     * @deprecated Moodle 2.5 MDL-38030 - Please do not call this function any more.
+     * @see core_user_external::get_users_by_field_parameters()
      */
     public static function get_users_by_id_parameters() {
         return new external_function_parameters(
@@ -658,6 +660,8 @@ class core_user_external extends external_api {
      * @param array $userids  array of user ids
      * @return array An array of arrays describing users
      * @since Moodle 2.2
+     * @deprecated Moodle 2.5 MDL-38030 - Please do not call this function any more.
+     * @see core_user_external::get_users_by_field()
      */
     public static function get_users_by_id($userids) {
         global $CFG, $USER, $DB;
@@ -708,6 +712,8 @@ class core_user_external extends external_api {
      *
      * @return external_description
      * @since Moodle 2.2
+     * @deprecated Moodle 2.5 MDL-38030 - Please do not call this function any more.
+     * @see core_user_external::get_users_by_field_returns()
      */
     public static function get_users_by_id_returns() {
         $additionalfields = array (