MDL-67156 core_h5p: change DIRECTORY_SEPARATOR by slashes

In Windows, the value of DIRECTORY_SEPARATOR is "\", causing failures in
the tests when compared to the path strings that use "/".

diff --git a/h5p/tests/h5p_file_storage_test.php b/h5p/tests/h5p_file_storage_test.php
index 832b4f0..6726fce 100644 (file)
--- a/h5p/tests/h5p_file_storage_test.php
+++ b/h5p/tests/h5p_file_storage_test.php
@@ -462,7 +462,7 @@ class h5p_file_storage_testcase extends \advanced_testcase {
         ];
         $filestorage = new file_storage();
         $fs->create_file_from_string($filerecord, 'test string info');
-        $expectedfilepath = DIRECTORY_SEPARATOR . file_storage::LIBRARY_FILEAREA . $filepath . 'upgrade.js';
+        $expectedfilepath = '/' . file_storage::LIBRARY_FILEAREA . $filepath . 'upgrade.js';
         $this->assertEquals($expectedfilepath, $filestorage->getUpgradeScript($machinename, $majorversion, $minorversion));
         $this->assertNull($filestorage->getUpgradeScript($machinename, $majorversion, 7));
     }
@@ -489,9 +489,9 @@ class h5p_file_storage_testcase extends \advanced_testcase {
         foreach ($files as $file) {
             if (!$file->is_directory) {
                 $stream = $ziparchive->get_stream($file->index);
-                $items = explode(DIRECTORY_SEPARATOR, $file->pathname);
+                $items = explode('/', $file->pathname);
                 array_shift($items);
-                $path = implode(DIRECTORY_SEPARATOR, $items);
+                $path = implode('/', $items);
                 $this->h5p_file_storage->saveFileFromZip($this->h5p_tempath, $path, $stream);
                 $filestocheck[] = $path;
             }