MDL-59685 users: Enrolment info link missing href
authorDamyon Wiese <damyon@moodle.com>
Mon, 14 Aug 2017 03:57:47 +0000 (11:57 +0800)
committerDamyon Wiese <damyon@moodle.com>
Mon, 14 Aug 2017 03:58:28 +0000 (11:58 +0800)
Href is required so that CSS can style these as clickable links (hand icon).

I also used comments to collapse the whitespace before and after the icons.

user/templates/status_field.mustache

index 57fcf8c..04cbf11 100644 (file)
 <div data-fullname="{{fullname}}" data-coursename="{{coursename}}" data-enrolinstancename="{{enrolinstancename}}"
      data-status="{{status}}" data-timestart="{{timestart}}" data-timeend="{{timeend}}">
     <span class="label {{#active}}label-success{{/active}}{{#suspended}}label-warning{{/suspended}}{{#notcurrent}}label-default{{/notcurrent}}">{{status}}</span>
-    <a data-action="showdetails" role="button" tabindex="0">
-        {{#pix}}docs, core, {{#str}}enroldetails, enrol{{/str}}{{/pix}}
-    </a>
+    <a data-action="showdetails" href="#" role="button" tabindex="0">{{!
+        }}{{#pix}}docs, core, {{#str}}enroldetails, enrol{{/str}}{{/pix}}{{!
+    }}</a>
     {{#enrolactions}}
-    <a href="{{url}}" role="button" {{#attributes}}{{name}}="{{value}}" {{/attributes}}>
-        {{{icon}}}
-    </a>
+    <a href="{{url}}" role="button" {{#attributes}}{{name}}="{{value}}" {{/attributes}}>{{!
+        }}{{{icon}}}{{!
+    }}</a>
     {{/enrolactions}}
 </div>