MDL-62294 lib: Take note of cherry-picked upstream commit
authorJun Pataleta <jun@moodle.com>
Wed, 12 Sep 2018 07:21:11 +0000 (15:21 +0800)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Wed, 7 Nov 2018 16:25:03 +0000 (17:25 +0100)
* Make a note of the applied upstream patch in
  lib/lessphp/moodle_readme.txt which fixes the PHP 7.2 compatibility
  issue when counting ruleset rules.

* Amended on integration to put together all the local modifications.

lib/lessphp/moodle_readme.txt

index fcfaf4b..2b9274d 100644 (file)
@@ -8,9 +8,13 @@ All the files from the folder lib/Less are copied in
 this directory. Only exception made for the directory
 '.easymin' which is not included.
 
-Verify that https://github.com/oyejorge/less.php/pull/367 has been applied to the imported version or apply it locally.
-
 Also copy the license file from the project root.
 
 Licensed under the Apache license 2.0.
 
+Modifications:
+* MDL-63422 - Verify that https://github.com/oyejorge/less.php/pull/367 has been applied to the
+    imported version or apply it locally. PHP 7.3 compatibility.
+* MDL-62294 - Cherry-picked upstream commit to fix PHP 7.2 compatibility when counting ruleset rules.
+    https://github.com/oyejorge/less.php/commit/669acc51817a8da162b5f1b7137e79f0e4acc636
+    TODO: Remove this note when this library gets upgraded to the latest release that already includes this fix.