MDL-37539 Assignment upgrade: Disable submission comments if allow notes was not...

For advanced upload of files only - this setting was stored in var2.

diff --git a/mod/assign/submission/comments/locallib.php b/mod/assign/submission/comments/locallib.php
index 16364e2..33f97be 100644 (file)
--- a/mod/assign/submission/comments/locallib.php
+++ b/mod/assign/submission/comments/locallib.php
@@ -110,7 +110,12 @@ class assign_submission_comments extends assign_submission_plugin {
      * @return bool was it a success? (false will trigger a rollback)
      */
     public function upgrade_settings(context $oldcontext, stdClass $oldassignment, & $log) {
-        // No settings to upgrade.
+        if ($oldassignment->assignmenttype == 'upload') {
+            // Disable if allow notes was not enabled.
+            if (!$oldassignment->var2) {
+                $this->disable();
+            }
+        }
         return true;
     }