MDL-48093 HTML 5 video: Firefox now supports .mp4
authorsam marshall <s.marshall@open.ac.uk>
Thu, 6 Nov 2014 11:54:09 +0000 (11:54 +0000)
committersam marshall <s.marshall@open.ac.uk>
Mon, 10 Nov 2014 10:48:28 +0000 (10:48 +0000)
lib/medialib.php

index 9c136f3..9a2ad64 100644 (file)
@@ -1071,8 +1071,11 @@ OET;
                         continue;
                     }
                 } else {
-                    // Formats .m4v and .mp4 are not supported in Firefox or Opera.
-                    if (core_useragent::is_firefox() || core_useragent::is_opera()) {
+                    // Formats .m4v and .mp4 are not supported in Opera, or in Firefox before 27.
+                    // https://developer.mozilla.org/en-US/docs/Web/HTML/Supported_media_formats
+                    // has the details.
+                    if (core_useragent::is_opera() || (core_useragent::is_firefox() &&
+                            !core_useragent::check_firefox_version(27))) {
                         continue;
                     }
                 }
@@ -1140,8 +1143,15 @@ OET;
                         continue;
                     }
                 } else {
-                    // Formats .aac, .mp3, and .m4a are not supported in Firefox or Opera.
-                    if (core_useragent::is_firefox() || core_useragent::is_opera()) {
+                    // Formats .aac, .mp3, and .m4a are not supported in Opera.
+                    if (core_useragent::is_opera()) {
+                        continue;
+                    }
+                    // Formats .mp3 and .m4a were not reliably supported in Firefox before 27.
+                    // https://developer.mozilla.org/en-US/docs/Web/HTML/Supported_media_formats
+                    // has the details. .aac is still not supported.
+                    if (core_useragent::is_firefox() && ($ext === 'aac' ||
+                            !core_useragent::check_firefox_version(27))) {
                         continue;
                     }
                 }