MDL-53566 core: Remove unused ancestorlocked field

This was originalyl intended as a performance improvement, but the
parent is already stored, and once calculated the value of locked is
already returned.

diff --git a/lib/accesslib.php b/lib/accesslib.php
index c5a13fe..c95bdc5 100644 (file)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -4743,15 +4743,6 @@ abstract class context extends stdClass implements IteratorAggregate {
      */
     protected $_locked;
 
-    /**
-     * Whether any parent of the current context is locked.
-     *
-     * Can be accessed publicly through $context->ancestorlocked.
-     *
-     * @var int
-     */
-    protected $_ancestorlocked;
-
     /**
      * @var array Context caching info
      */
@@ -5366,8 +5357,7 @@ abstract class context extends stdClass implements IteratorAggregate {
         }
 
         if ($parent = $this->get_parent_context()) {
-            $this->_ancestorlocked = $parent->is_locked();
-            return $this->_ancestorlocked;
+            return $parent->is_locked();
         }
 
         return false;