MDL-22366 upgrade - always drop DB objects conditionally

diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 40be53e..06295e3 100644 (file)
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -101,7 +101,9 @@ function xmldb_main_upgrade($oldversion) {
         $index = new xmldb_index('contextid-lowerboundary', XMLDB_INDEX_NOTUNIQUE, array('contextid', 'lowerboundary'));
 
     /// Launch drop index contextid-lowerboundary
-        $dbman->drop_index($table, $index);
+        if ($dbman->index_exists($table, $index)) {
+            $dbman->drop_index($table, $index);
+        }
 
     /// Define index contextid-lowerboundary-letter (unique) to be added to grade_letters
         $table = new xmldb_table('grade_letters');

diff --git a/lib/ddl/database_manager.php b/lib/ddl/database_manager.php
index 196c2a0..0e288fa 100644 (file)
--- a/lib/ddl/database_manager.php
+++ b/lib/ddl/database_manager.php
@@ -907,7 +907,7 @@ class database_manager {
         if (!$this->index_exists($xmldb_table, $xmldb_intex)) {
             throw new ddl_exception('ddlunknownerror', null,
                       'Index ' . $xmldb_table->getName() . '->' . $xmldb_intex->getName() .
-                      ' does not exist. Delete skipped');
+                      ' does not exist. Drop skipped');
         }
 
         if (!$sqlarr = $this->generator->getDropIndexSQL($xmldb_table, $xmldb_intex)) {