Merge branch 'MDL-34691_assign_overdue_by' of https://github.com/SWiT/moodle

diff --combined mod/assign/renderer.php
index e90556f,3ca0232..c44f451
--- 1/mod/assign/renderer.php
--- 2/mod/assign/renderer.php
+++ b/mod/assign/renderer.php
@@@ -168,8 -168,11 +168,8 @@@ class mod_assign_renderer extends plugi
  
              $o .= $this->output->continue_button($cancelurl);
          } else {
 -            // All submission plugins ready - confirm the student really does want to submit for marking
 -            $continueurl = new moodle_url('/mod/assign/view.php', array('id' => $page->coursemoduleid,
 -                                                                        'action' => 'confirmsubmit',
 -                                                                        'sesskey' => sesskey()));
 -            $o .= $this->output->confirm(get_string('confirmsubmission', 'mod_assign'), $continueurl, $cancelurl);
 +            // All submission plugins ready - show the confirmation form (may contain submission statement)
 +            $o .= $this->moodleform($page->confirmform);
          }
          $o .= $this->output->container_end();
  
@@@ -321,7 -324,7 +321,7 @@@
          }
  
          foreach ($status->feedbackplugins as $plugin) {
 -            if ($plugin->is_enabled() && $plugin->is_visible() && !$plugin->is_empty($status->grade)) {
 +            if ($plugin->is_enabled() && $plugin->is_visible() && !empty($status->grade) && !$plugin->is_empty($status->grade)) {
                  $row = new html_table_row();
                  $cell1 = new html_table_cell($plugin->get_name());
                  $pluginfeedback = new assign_feedback_plugin_feedback($plugin, $status->grade, assign_feedback_plugin_feedback::SUMMARY, $status->coursemoduleid, $status->returnaction, $status->returnparams);
@@@ -417,7 -420,7 +417,7 @@@
              $row = new html_table_row();
              $cell1 = new html_table_cell(get_string('timeremaining', 'assign'));
              if ($duedate - $time <= 0) {
-                 if (!$status->submission || $status->submission != ASSIGN_SUBMISSION_STATUS_SUBMITTED) {
+                 if (!$status->submission || $status->submission->status != ASSIGN_SUBMISSION_STATUS_SUBMITTED) {
                      if ($status->submissionsenabled) {
                          $cell2 = new html_table_cell(get_string('overdue', 'assign', format_time($time - $duedate)));
                          $cell2->attributes = array('class'=>'overdue');