MDL-62049 core_privacy: use correct lang string for date
authorMark Nelson <markn@moodle.com>
Thu, 19 Apr 2018 06:28:00 +0000 (14:28 +0800)
committerMark Nelson <markn@moodle.com>
Mon, 23 Apr 2018 05:03:23 +0000 (13:03 +0800)
privacy/classes/local/request/transform.php
privacy/tests/request_transform_test.php

index 34a3bd1..48c3865 100644 (file)
@@ -64,7 +64,7 @@ class transform {
      * @return  string      The translated string.
      */
     public static function date($date) {
-        return userdate($date, get_string('strftimetime', 'langconfig'));
+        return userdate($date, get_string('strftimedate', 'langconfig'));
     }
 
     /**
index 15876ad..3926f5f 100644 (file)
@@ -53,14 +53,37 @@ class request_transform_test extends advanced_testcase {
      * Test that the datetime is translated into a string.
      */
     public function test_datetime() {
-        $this->assertInternalType('string', transform::datetime(1));
+        $time = 1;
+
+        $datestr = transform::datetime($time);
+
+        // Assert it is a string.
+        $this->assertInternalType('string', $datestr);
+
+        // To prevent failures on MAC where we are returned with a lower-case 'am' we want to convert this to 'AM'.
+        $datestr = str_replace('am', 'AM', $datestr);
+
+        // Assert the formatted date is correct.
+        $dateobj = new DateTime();
+        $dateobj->setTimestamp($time);
+        $this->assertEquals($dateobj->format('l, j F Y, g:i A'), $datestr);
     }
 
     /**
      * Test that the date is translated into a string.
      */
     public function test_date() {
-        $this->assertInternalType('string', transform::date(1));
+        $time = 1;
+
+        $datestr = transform::date($time);
+
+        // Assert it is a string.
+        $this->assertInternalType('string', $datestr);
+
+        // Assert the formatted date is correct.
+        $dateobj = new DateTime();
+        $dateobj->setTimestamp($time);
+        $this->assertEquals($dateobj->format('j F Y'), $datestr);
     }
 
     /**