MDL-48580 report_log: fix site errors dropdown
authorSimey Lameze <simey@moodle.com>
Tue, 16 Dec 2014 04:37:28 +0000 (12:37 +0800)
committerSimey Lameze <simey@moodle.com>
Tue, 16 Dec 2014 04:37:28 +0000 (12:37 +0800)
Thanks Renaat Debleu for pointing this bug and share a solution.

report/log/classes/renderable.php

index 1a1b95a..d5e99e4 100644 (file)
@@ -188,7 +188,7 @@ class report_log_renderable implements renderable {
 
         // For site just return site errors option.
         $sitecontext = context_system::instance();
 
         // For site just return site errors option.
         $sitecontext = context_system::instance();
-        if (empty($this->course) && has_capability('report/log:view', $sitecontext)) {
+        if ($this->course->id == SITEID && has_capability('report/log:view', $sitecontext)) {
             $activities["site_errors"] = get_string("siteerrors");
             return $activities;
         }
             $activities["site_errors"] = get_string("siteerrors");
             return $activities;
         }