Revert "MDL-42932 core_calendar: introduced calendar type system setting"

This reverts commit bb32a499e10abc3bb88e715fb0575e5b7fb66e8e.

diff --git a/admin/settings/appearance.php b/admin/settings/appearance.php
index 787c0f1..6505c96 100644 (file)
--- a/admin/settings/appearance.php
+++ b/admin/settings/appearance.php
@@ -41,11 +41,8 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
     }
 
 
-    // Calendar settings.
+    // calendar
     $temp = new admin_settingpage('calendar', new lang_string('calendarsettings','admin'));
-
-    $temp->add(new admin_setting_configselect('calendartype', new lang_string('calendartype', 'admin'),
-        new lang_string('configcalendartype', 'admin'), 'gregorian', \core_calendar\type_factory::get_list_of_calendar_types()));
     $temp->add(new admin_setting_special_adminseesall());
     //this is hacky because we do not want to include the stuff from calendar/lib.php
     $temp->add(new admin_setting_configselect('calendar_site_timeformat', new lang_string('pref_timeformat', 'calendar'),

diff --git a/auth/db/auth.php b/auth/db/auth.php
index aa0053c..333142a 100644 (file)
--- a/auth/db/auth.php
+++ b/auth/db/auth.php
@@ -399,9 +399,6 @@ class auth_plugin_db extends auth_plugin_base {
                 if (empty($user->lang)) {
                     $user->lang = $CFG->lang;
                 }
-                if (empty($user->calendartype)) {
-                    $user->calendartype = $CFG->calendartype;
-                }
                 $user->timecreated = time();
                 $user->timemodified = $user->timecreated;
                 if ($collision = $DB->get_record_select('user', "username = :username AND mnethostid = :mnethostid AND auth <> :auth", array('username'=>$user->username, 'mnethostid'=>$CFG->mnet_localhost_id, 'auth'=>$this->authtype), 'id,username,auth')) {

diff --git a/auth/email/auth.php b/auth/email/auth.php
index b071e32..a670cfc 100644 (file)
--- a/auth/email/auth.php
+++ b/auth/email/auth.php
@@ -90,9 +90,6 @@ class auth_plugin_email extends auth_plugin_base {
         require_once($CFG->dirroot.'/user/lib.php');
 
         $user->password = hash_internal_user_password($user->password);
-        if (empty($user->calendartype)) {
-            $user->calendartype = $CFG->calendartype;
-        }
 
         $user->id = user_create_user($user, false);
 

diff --git a/auth/ldap/auth.php b/auth/ldap/auth.php
index f7e089c..f92c08d 100644 (file)
--- a/auth/ldap/auth.php
+++ b/auth/ldap/auth.php
@@ -945,9 +945,6 @@ class auth_plugin_ldap extends auth_plugin_base {
                 if (empty($user->lang)) {
                     $user->lang = $CFG->lang;
                 }
-                if (empty($user->calendartype)) {
-                    $user->calendartype = $CFG->calendartype;
-                }
 
                 $id = user_create_user($user, false);
                 echo "\t"; print_string('auth_dbinsertuser', 'auth_db', array('name'=>$user->username, 'id'=>$id)); echo "\n";

diff --git a/lang/en/admin.php b/lang/en/admin.php
index b81cccc..cd99894 100644 (file)
--- a/lang/en/admin.php
+++ b/lang/en/admin.php
@@ -95,7 +95,6 @@ $string['cachejs_help'] = 'Javascript caching and compression greatly improves p
 $string['cachetext'] = 'Text cache lifetime';
 $string['calendarexportsalt'] = 'Calendar export salt';
 $string['calendarsettings'] = 'Calendar';
-$string['calendartype'] = 'Calendar type';
 $string['calendar_weekend'] = 'Weekend days';
 $string['cannotdeletemodfilter'] = 'You cannot uninstall the \'{$a->filter}\' because it is part of the \'{$a->module}\' module.';
 $string['cannotuninstall'] = '{$a} can not be uninstalled.';
@@ -149,7 +148,6 @@ $string['configbloglevel'] = 'This setting allows you to restrict the level to w
 $string['configcachetext'] = 'For larger sites or sites that use text filters, this setting can really speed things up.  Copies of texts will be retained in their processed form for the time specified here.  Setting this too small may actually slow things down slightly,  but setting it too large may mean texts take too long to refresh (with new links, for example).';
 $string['configcalendarcustomexport'] = 'Enable custom date range export of calendar';
 $string['configcalendarexportsalt'] = 'This random text is used for improving of security of authentication tokens used for exporting of calendars. Please note that all current tokens are invalidated if you change this hash salt.';
-$string['configcalendartype'] = 'Choose a default calendar type for the whole site. This setting can be overridden in the course settings or by users in their personal profile.';
 $string['configclamactlikevirus'] = 'Treat files like viruses';
 $string['configclamdonothing'] = 'Treat files as OK';
 $string['configclamfailureonupload'] = 'If you have configured clam to scan uploaded files, but it is configured incorrectly or fails to run for some unknown reason, how should it behave?  If you choose \'Treat files like viruses\', they\'ll be moved into the quarantine area, or deleted. If you choose \'Treat files as OK\', the files will be moved to the destination directory like normal. Either way, admins will be alerted that clam has failed.  If you choose \'Treat files like viruses\' and for some reason clam fails to run (usually because you have entered an invalid pathtoclam), ALL files that are uploaded will be moved to the given quarantine area, or deleted. Be careful with this setting.';

diff --git a/user/editlib.php b/user/editlib.php
index dde64e4..6f886da 100644 (file)
--- a/user/editlib.php
+++ b/user/editlib.php
@@ -251,7 +251,6 @@ function useredit_shared_definition(&$mform, $editoroptions = null, $filemanager
     // We do not want to show this option unless there is more than one calendar type to display.
     if (count($calendartypes) > 1) {
         $mform->addElement('select', 'calendartype', get_string('preferredcalendar', 'calendar'), $calendartypes);
-        $mform->setDefault('calendartype', $CFG->calendartype);
     }
 
     if (!empty($CFG->allowuserthemes)) {

diff --git a/user/externallib.php b/user/externallib.php
index a569d92..6cc2e04 100644 (file)
--- a/user/externallib.php
+++ b/user/externallib.php
@@ -59,7 +59,6 @@ class core_user_external extends external_api {
                             'auth'                => new external_value(PARAM_PLUGIN, 'Auth plugins include manual, ldap, imap, etc', VALUE_DEFAULT, 'manual', NULL_NOT_ALLOWED),
                             'idnumber'            => new external_value(PARAM_RAW, 'An arbitrary ID code number perhaps from the institution', VALUE_DEFAULT, ''),
                             'lang'                => new external_value(PARAM_SAFEDIR, 'Language code such as "en", must exist on server', VALUE_DEFAULT, $CFG->lang, NULL_NOT_ALLOWED),
-                            'calendartype'        => new external_value(PARAM_PLUGIN, 'Calendar type such as "gregorian", must exist on server', VALUE_DEFAULT, $CFG->calendartype, VALUE_OPTIONAL),
                             'theme'               => new external_value(PARAM_PLUGIN, 'Theme name such as "standard", must exist on server', VALUE_OPTIONAL),
                             'timezone'            => new external_value(PARAM_TIMEZONE, 'Timezone code such as Australia/Perth, or 99 for default', VALUE_OPTIONAL),
                             'mailformat'          => new external_value(PARAM_INT, 'Mail format code is 0 for plain text, 1 for HTML etc', VALUE_OPTIONAL),
@@ -274,6 +273,7 @@ class core_user_external extends external_api {
      * @since Moodle 2.2
      */
     public static function update_users_parameters() {
+        global $CFG;
         return new external_function_parameters(
             array(
                 'users' => new external_multiple_structure(
@@ -288,7 +288,6 @@ class core_user_external extends external_api {
                             'auth'                => new external_value(PARAM_PLUGIN, 'Auth plugins include manual, ldap, imap, etc', VALUE_OPTIONAL, '', NULL_NOT_ALLOWED),
                             'idnumber'            => new external_value(PARAM_RAW, 'An arbitrary ID code number perhaps from the institution', VALUE_OPTIONAL),
                             'lang'                => new external_value(PARAM_SAFEDIR, 'Language code such as "en", must exist on server', VALUE_OPTIONAL, '', NULL_NOT_ALLOWED),
-                            'calendartype'        => new external_value(PARAM_PLUGIN, 'Language code such as "en", must exist on server', VALUE_OPTIONAL, '', NULL_NOT_ALLOWED),
                             'theme'               => new external_value(PARAM_PLUGIN, 'Theme name such as "standard", must exist on server', VALUE_OPTIONAL),
                             'timezone'            => new external_value(PARAM_TIMEZONE, 'Timezone code such as Australia/Perth, or 99 for default', VALUE_OPTIONAL),
                             'mailformat'          => new external_value(PARAM_INT, 'Mail format code is 0 for plain text, 1 for HTML etc', VALUE_OPTIONAL),
@@ -894,7 +893,6 @@ class core_user_external extends external_api {
                     'auth'        => new external_value(PARAM_PLUGIN, 'Auth plugins include manual, ldap, imap, etc', VALUE_OPTIONAL),
                     'confirmed'   => new external_value(PARAM_INT, 'Active user: 1 if confirmed, 0 otherwise', VALUE_OPTIONAL),
                     'lang'        => new external_value(PARAM_SAFEDIR, 'Language code such as "en", must exist on server', VALUE_OPTIONAL),
-                    'calendartype' => new external_value(PARAM_PLUGIN, 'Calendar type such as "gregorian", must exist on server', VALUE_OPTIONAL),
                     'theme'       => new external_value(PARAM_PLUGIN, 'Theme name such as "standard", must exist on server', VALUE_OPTIONAL),
                     'timezone'    => new external_value(PARAM_TIMEZONE, 'Timezone code such as Australia/Perth, or 99 for default', VALUE_OPTIONAL),
                     'mailformat'  => new external_value(PARAM_INT, 'Mail format code is 0 for plain text, 1 for HTML etc', VALUE_OPTIONAL),

diff --git a/user/lib.php b/user/lib.php
index fe7d338..7ab6c0d 100644 (file)
--- a/user/lib.php
+++ b/user/lib.php
@@ -37,7 +37,7 @@ function user_create_user($user, $updatepassword = true) {
 
     // Set the timecreate field to the current time.
     if (!is_object($user)) {
-        $user = (object)$user;
+            $user = (object)$user;
     }
 
     // Check username.
@@ -61,16 +61,6 @@ function user_create_user($user, $updatepassword = true) {
         unset($user->password);
     }
 
-    // Make sure calendartype, if set, is valid.
-    if (!empty($user->calendartype)) {
-        $availablecalendartypes = \core_calendar\type_factory::get_list_of_calendar_types();
-        if (empty($availablecalendartypes[$user->calendartype])) {
-            $user->calendartype = $CFG->calendartype;
-        }
-    } else {
-        $user->calendartype = $CFG->calendartype;
-    }
-
     $user->timecreated = time();
     $user->timemodified = $user->timecreated;
 
@@ -111,7 +101,7 @@ function user_update_user($user, $updatepassword = true) {
 
     // set the timecreate field to the current time
     if (!is_object($user)) {
-        $user = (object)$user;
+            $user = (object)$user;
     }
 
     //check username
@@ -137,18 +127,6 @@ function user_update_user($user, $updatepassword = true) {
         unset($user->password);
     }
 
-    // Make sure calendartype, if set, is valid.
-    if (!empty($user->calendartype)) {
-        $availablecalendartypes = \core_calendar\type_factory::get_list_of_calendar_types();
-        // If it doesn't exist, then unset this value, we do not want to update the user's value.
-        if (empty($availablecalendartypes[$user->calendartype])) {
-            unset($user->calendartype);
-        }
-    } else {
-        // Unset this variable, must be an empty string, which we do not want to update the calendartype to.
-        unset($user->calendartype);
-    }
-
     $user->timemodified = time();
     $DB->update_record('user', $user);