MDL-56889 boostrapbase: remove excessive stylelint-disables

From bs4-compat.less, replace with file level disable instead.

diff --git a/theme/bootstrapbase/less/moodle/bs4-compat.less b/theme/bootstrapbase/less/moodle/bs4-compat.less
index 1d324c7..8da3f49 100644 (file)
--- a/theme/bootstrapbase/less/moodle/bs4-compat.less
+++ b/theme/bootstrapbase/less/moodle/bs4-compat.less
@@ -1,179 +1,179 @@
+// Bootstrap 4 compatibility for bootstrapbased themes.
+// Disable some stylelint rules which are necessary these compatbility classses.
+/* stylelint-disable declaration-no-important, block-no-empty */
 
 // Add support for card. We map it to well.
 // This is not meant to be perfect - but at least applies some styles to a bs4 card.
 .card:extend(.well) {
-    /* stylelint-disable-line no-empty-source */
 }
 
 // Due to lessphp limitations, the following classes must be declared statically without use of a loop.
 .p-l-1 {
-    padding-left: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 1 * @baseFontSize !important;
 }
 .p-r-1 {
-    padding-right: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-right: 1 * @baseFontSize !important;
 }
 .p-t-1 {
-    padding-top: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 1 * @baseFontSize !important;
 }
 .p-b-1 {
-    padding-bottom: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-bottom: 1 * @baseFontSize !important;
 }
 .p-x-1 {
-    padding-left: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-right: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 1 * @baseFontSize !important;
+    padding-right: 1 * @baseFontSize !important;
 }
 .p-y-1 {
-    padding-top: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-bottom: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 1 * @baseFontSize !important;
+    padding-bottom: 1 * @baseFontSize !important;
 }
 .p-a-1 {
-    padding: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding: 1 * @baseFontSize !important;
 }
 
 .m-l-1 {
-    margin-left: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 1 * @baseFontSize !important;
 }
 .m-r-1 {
-    margin-right: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-right: 1 * @baseFontSize !important;
 }
 .m-t-1 {
-    margin-top: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 1 * @baseFontSize !important;
 }
 .m-b-1 {
-    margin-bottom: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-bottom: 1 * @baseFontSize !important;
 }
 .m-x-1 {
-    margin-left: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-right: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 1 * @baseFontSize !important;
+    margin-right: 1 * @baseFontSize !important;
 }
 .m-y-1 {
-    margin-top: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-bottom: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 1 * @baseFontSize !important;
+    margin-bottom: 1 * @baseFontSize !important;
 }
 .m-a-1 {
-    margin: 1 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin: 1 * @baseFontSize !important;
 }
 
 .p-l-2 {
-    padding-left: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 2 * @baseFontSize !important;
 }
 .p-r-2 {
-    padding-right: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-right: 2 * @baseFontSize !important;
 }
 .p-t-2 {
-    padding-top: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 2 * @baseFontSize !important;
 }
 .p-b-2 {
-    padding-bottom: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-bottom: 2 * @baseFontSize !important;
 }
 .p-x-2 {
-    padding-left: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-right: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 2 * @baseFontSize !important;
+    padding-right: 2 * @baseFontSize !important;
 }
 .p-y-2 {
-    padding-top: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-bottom: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 2 * @baseFontSize !important;
+    padding-bottom: 2 * @baseFontSize !important;
 }
 .p-a-2 {
-    padding: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding: 2 * @baseFontSize !important;
 }
 
 .m-l-2 {
-    margin-left: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 2 * @baseFontSize !important;
 }
 .m-r-2 {
-    margin-right: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-right: 2 * @baseFontSize !important;
 }
 .m-t-2 {
-    margin-top: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 2 * @baseFontSize !important;
 }
 .m-b-2 {
-    margin-bottom: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-bottom: 2 * @baseFontSize !important;
 }
 .m-x-2 {
-    margin-left: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-right: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 2 * @baseFontSize !important;
+    margin-right: 2 * @baseFontSize !important;
 }
 .m-y-2 {
-    margin-top: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-bottom: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 2 * @baseFontSize !important;
+    margin-bottom: 2 * @baseFontSize !important;
 }
 .m-a-2 {
-    margin: 2 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin: 2 * @baseFontSize !important;
 }
 
 .p-l-3 {
-    padding-left: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 3 * @baseFontSize !important;
 }
 .p-r-3 {
-    padding-right: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-right: 3 * @baseFontSize !important;
 }
 .p-t-3 {
-    padding-top: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 3 * @baseFontSize !important;
 }
 .p-b-3 {
-    padding-bottom: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-bottom: 3 * @baseFontSize !important;
 }
 .p-x-3 {
-    padding-left: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-right: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-left: 3 * @baseFontSize !important;
+    padding-right: 3 * @baseFontSize !important;
 }
 .p-y-3 {
-    padding-top: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    padding-bottom: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding-top: 3 * @baseFontSize !important;
+    padding-bottom: 3 * @baseFontSize !important;
 }
 .p-a-3 {
-    padding: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    padding: 3 * @baseFontSize !important;
 }
 
 .m-l-3 {
-    margin-left: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 3 * @baseFontSize !important;
 }
 .m-r-3 {
-    margin-right: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-right: 3 * @baseFontSize !important;
 }
 .m-t-3 {
-    margin-top: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 3 * @baseFontSize !important;
 }
 .m-b-3 {
-    margin-bottom: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-bottom: 3 * @baseFontSize !important;
 }
 .m-x-3 {
-    margin-left: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-right: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: 3 * @baseFontSize !important;
+    margin-right: 3 * @baseFontSize !important;
 }
 .m-y-3 {
-    margin-top: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
-    margin-bottom: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin-top: 3 * @baseFontSize !important;
+    margin-bottom: 3 * @baseFontSize !important;
 }
 .m-a-3 {
-    margin: 3 * @baseFontSize !important; /* stylelint-disable-line declaration-no-important */
+    margin: 3 * @baseFontSize !important;
 }
 
 .d-inline {
-    display: inline !important; /* stylelint-disable-line declaration-no-important */
+    display: inline !important;
 }
 .d-block {
-    display: block !important; /* stylelint-disable-line declaration-no-important */
+    display: block !important;
 }
 .d-inline-block {
-    display: inline-block !important; /* stylelint-disable-line declaration-no-important */
+    display: inline-block !important;
 }
 
 // Horizontal centering.
 .m-x-auto {
-    margin-left: auto !important; /* stylelint-disable-line declaration-no-important */
-    margin-right: auto !important; /* stylelint-disable-line declaration-no-important */
+    margin-left: auto !important;
+    margin-right: auto !important;
 }
 
 // Support img-fluid.
 .img-fluid:extend(.img-responsive) {
-    /* stylelint-disable-line no-empty-source */
 }
 
 // Text danger
 .text-danger:extend(.text-error) {
-    /* stylelint-disable-line no-empty-source */
 }
 
 .btn-secondary {
@@ -223,13 +223,11 @@
 
 // Floats
 .pull-xs-left:extend(.pull-left) {
-    /* stylelint-disable-line no-empty-source */
 }
 
 .pull-xs-right:extend(.pull-right) {
-    /* stylelint-disable-line no-empty-source */
 }
 
 .text-nowrap {
-    white-space: nowrap !important; /* stylelint-disable-line declaration-no-important */
+    white-space: nowrap !important;
 }

diff --git a/theme/bootstrapbase/style/moodle.css b/theme/bootstrapbase/style/moodle.css
index aea5397..eef3084 100644 (file)
--- a/theme/bootstrapbase/style/moodle.css
+++ b/theme/bootstrapbase/style/moodle.css
@@ -15874,7 +15874,6 @@ form.search-cohort input[type="text"],
 form.search-cohort input[type="submit"],
 form.search-cohort label {
   margin-top: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 form.search-cohort label {
   margin-bottom: 0;
@@ -19020,224 +19019,157 @@ input[type="reset"] .caret {
 ul.indented-list {
   margin-left: 20px;
 }
-.card {
-  /* stylelint-disable-line no-empty-source */
-}
+/* stylelint-disable declaration-no-important, block-no-empty */
 .p-l-1 {
   padding-left: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-r-1 {
   padding-right: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-t-1 {
   padding-top: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-b-1 {
   padding-bottom: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-x-1 {
   padding-left: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-right: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-y-1 {
   padding-top: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-bottom: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-a-1 {
   padding: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-l-1 {
   margin-left: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-r-1 {
   margin-right: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-t-1 {
   margin-top: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-b-1 {
   margin-bottom: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-x-1 {
   margin-left: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-right: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-y-1 {
   margin-top: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-bottom: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-a-1 {
   margin: 14px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-l-2 {
   padding-left: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-r-2 {
   padding-right: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-t-2 {
   padding-top: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-b-2 {
   padding-bottom: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-x-2 {
   padding-left: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-right: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-y-2 {
   padding-top: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-bottom: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-a-2 {
   padding: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-l-2 {
   margin-left: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-r-2 {
   margin-right: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-t-2 {
   margin-top: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-b-2 {
   margin-bottom: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-x-2 {
   margin-left: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-right: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-y-2 {
   margin-top: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-bottom: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-a-2 {
   margin: 28px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-l-3 {
   padding-left: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-r-3 {
   padding-right: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-t-3 {
   padding-top: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-b-3 {
   padding-bottom: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-x-3 {
   padding-left: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-right: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-y-3 {
   padding-top: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
   padding-bottom: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .p-a-3 {
   padding: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-l-3 {
   margin-left: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-r-3 {
   margin-right: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-t-3 {
   margin-top: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-b-3 {
   margin-bottom: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-x-3 {
   margin-left: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-right: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-y-3 {
   margin-top: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-bottom: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-a-3 {
   margin: 42px !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .d-inline {
   display: inline !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .d-block {
   display: block !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .d-inline-block {
   display: inline-block !important;
-  /* stylelint-disable-line declaration-no-important */
 }
 .m-x-auto {
   margin-left: auto !important;
-  /* stylelint-disable-line declaration-no-important */
   margin-right: auto !important;
-  /* stylelint-disable-line declaration-no-important */
-}
-.img-fluid {
-  /* stylelint-disable-line no-empty-source */
-}
-.text-danger {
-  /* stylelint-disable-line no-empty-source */
 }
 .btn-secondary {
   background-color: #fff;
@@ -19274,13 +19206,6 @@ ul.indented-list {
 .tag-primary[href] {
   background-color: #0378a9;
 }
-.pull-xs-left {
-  /* stylelint-disable-line no-empty-source */
-}
-.pull-xs-right {
-  /* stylelint-disable-line no-empty-source */
-}
 .text-nowrap {
   white-space: nowrap !important;
-  /* stylelint-disable-line declaration-no-important */
 }