MDL-48342 Question: qformat_default::readquestion is broken

diff --git a/mod/lesson/format.php b/mod/lesson/format.php
index 76d56e3..f6c13dd 100644 (file)
--- a/mod/lesson/format.php
+++ b/mod/lesson/format.php
@@ -587,7 +587,8 @@ class qformat_default {
     /// this format, this function converts it into a question
     /// object suitable for processing and insertion into Moodle.
 
-        echo "<p>This flash question format has not yet been completed!</p>";
+        // We should never get there unless the qformat plugin is broken.
+        throw new coding_exception('Question format plugin is missing important code: readquestion.');
 
         return null;
     }

diff --git a/mod/quiz/lang/en/quiz.php b/mod/quiz/lang/en/quiz.php
index 9b94095..f17d5fb 100644 (file)
--- a/mod/quiz/lang/en/quiz.php
+++ b/mod/quiz/lang/en/quiz.php
@@ -360,7 +360,6 @@ $string['finishattemptdots'] = 'Finish attempt...';
 $string['finishreview'] = 'Finish review';
 $string['forceregeneration'] = 'force regeneration';
 $string['formatnotfound'] = 'Import/export format {$a} not found';
-$string['formatnotimplemented'] = 'This format has not been correctly implemented, please post a bug report';
 $string['formulaerror'] = 'Formula errors!';
 $string['fractionsaddwrong'] = 'The positive grades you have chosen do not add up to 100%<br />Instead, they add up to {$a}%<br />Do you want to go back and fix this question?';
 $string['fractionsnomax'] = 'One of the answers should be 100%, so that it is<br />possible to get a full grade for this question.<br />Do you want to go back and fix this question?';

diff --git a/question/format.php b/question/format.php
index 827636f..197ecf6 100644 (file)
--- a/question/format.php
+++ b/question/format.php
@@ -696,9 +696,8 @@ class qformat_default {
      * @return object question object
      */
     protected function readquestion($lines) {
-
-        $formatnotimplemented = get_string('formatnotimplemented', 'question');
-        echo "<p>{$formatnotimplemented}</p>";
+        // We should never get there unless the qformat plugin is broken.
+        throw new coding_exception('Question format plugin is missing important code: readquestion.');
 
         return null;
     }
@@ -930,8 +929,7 @@ class qformat_default {
      */
     protected function writequestion($question) {
         // if not overidden, then this is an error.
-        $formatnotimplemented = get_string('formatnotimplemented', 'question');
-        echo "<p>{$formatnotimplemented}</p>";
+        throw new coding_exception('Question format plugin is missing important code: writequestion.');
         return null;
     }